[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #9 from Mason James m...@kohaaloha.com --- (In reply to comment #8) Created attachment 17878 [details] [review] Bug 10084 - YUI path wrong in CCSR theme with packages Bug 9052 fixed this for prog, CCSR was left aline in the dark (it's friday). Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Worked fine in my test package, good work Tomas Signed-off-by: Mason James m...@kohaaloha.com passing QA - works as promised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #10 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Tomás! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #5) Marcel, this is due to the way pacakges handle yui stuff Thanks for your reply. This is not completely clear to me. I switch this back to Signed off. Could Robin qa this kind of patches perhaps? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- (In reply to comment #6) (In reply to comment #5) Marcel, this is due to the way pacakges handle yui stuff Thanks for your reply. This is not completely clear to me. I switch this back to Signed off. Could Robin qa this kind of patches perhaps? You could see the fix this way: we already did this for the 'prog' theme, I just added the relevant lines so the same is done for 'ccsr'. Anyway, I think Robin should take a look too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Mason James m...@kohaaloha.com changed: What|Removed |Added Attachment #17567|0 |1 is obsolete|| --- Comment #8 from Mason James m...@kohaaloha.com --- Created attachment 17878 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17878action=edit Bug 10084 - YUI path wrong in CCSR theme with packages Bug 9052 fixed this for prog, CCSR was left aline in the dark (it's friday). Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Worked fine in my test package, good work Tomas Signed-off-by: Mason James m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- Few questions: First: install -m 0644 koha-tmpl/opac-tmpl/lib/yui/skin.css \ koha-tmpl/opac-tmpl/lib/yui/reset-fonts-grids.css \ $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/css +install -m 0644 koha-tmpl/opac-tmpl/lib/yui/skin.css \ + koha-tmpl/opac-tmpl/lib/yui/reset-fonts-grids.css \ +$(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/css I have the impression that Koha expects this css to be in lib/yui. So, why install them to prog and ccsr? Better remove the lines before?? Second: sed -i -e 's:url(.*/reset-fonts-grids.css.*):url(/opac-tmpl/lib/yui/reset-fonts-grids/reset-fonts-grids.css):' \ -e 's:url(.*/skin.css.*):url(/opac-tmpl/lib/yui/assets/skins/sam/skin.css):' \ -$(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/css/opac.css \ -$(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/css/sco.css +$(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/*/en/css/opac.css \ +$(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/*/en/css/sco.css I think that this sed should not find anything? I grepped on reset-fonts-grids.css but could not find references to something looking like reset-fonts-grids.css.* Or is that only in the scope of the install?? Third: +sed -i -e 's:href=/opac-tmpl/lib/yui/reset-fonts-grids.css:href=/opac-tmpl/lib/yui/reset-fonts-grids/reset-fonts-grids.css:' \ + -e 's:href=/opac-tmpl/lib/yui/skin.css:href=/opac-tmpl/lib/yui/assets/skins/sam/skin.css:' \ + $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/includes/doc-head-close.inc Why move this skin.css file to assets/skins/sam? Note that I also did not find the skin.css.* occurrences.. Changing status to reflect need for clarification. After that please switch back to Signed off. Thanks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Marcel, this is due to the way pacakges handle yui stuff: it relies on yui provided by libyui-js, and thus instead of using the internal one, it deletes it (scope of the install in the sense you wrote) and creates a symbolic link to the installed via packages one. The main problem (and thus the weirdness of the patch, which mimics what is done already) is that the dir structure Koha uses differs from the standard (the one the package provides), and we need to rearrange things. There should be a patch for arranging yui stuff the same way it is officially arranged, but that needs a lot of rewrite through the code. Conclusion: this fixes the current problem, in the way we handle this in packages. It should be solved for good in a proper way, in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #17562|0 |1 is obsolete|| --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 17567 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17567action=edit Bug 10084 - YUI path wrong in CCSR theme with packages Bug 9052 fixed this for prog, CCSR was left aline in the dark (it's friday). Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Worked fine in my test package, good work Tomas -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Patch complexity|--- |Trivial patch See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9052 Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 17562 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17562action=edit Bug 10084 - YUI path wrong in CCSR theme with packages Bug 9052 fixed this for prog, CCSR was left aline in the dark (it's friday). Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- http://es.koha-community.org/koha-common_3.13-1~git+20130419160748.4fa0b963_all.deb -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Doug Dearden dear...@sarsf.org changed: What|Removed |Added CC||dear...@sarsf.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
