[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

--- Comment #15 from Katrin Fischer  ---
Mason, could you maybe review this one to see if it's still required?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #14 from David Cook  ---
Is this something you still want to do, Mason, or should we close this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

--- Comment #13 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #12)
> Honestly? I don't remember. Probably just have to check with Mirko if it's
> ok?

Yeah, we need to check with Mirko if he is ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

--- Comment #12 from Katrin Fischer  ---
Honestly? I don't remember. Probably just have to check with Mirko if it's ok?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

--- Comment #11 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #9)
> The patch proposes a new dependency libparse-debcontrol-perl and there has
> been some discussion about it.

Where/When/Why?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #65654|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 66704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66704=edit
Bug 10112 - add test for ./debian/control* files

to test, apply patch...

1/ install libparse-debcontrol-perl package
apt-get install libparse-debcontrol-perl

2/ run successful tests
$ perl ./t/00-valid-debian-control-file.t  
1..2
ok 1 - parsed ./debian/control file cleanly
ok 2 - parsed ./debian/control.in file cleanly

3/ add some bad syntax to a file
$ sed -i -e '20i ---\' ./debian/control.in

4/ run failed tests
$ perl ./t/00-valid-debian-control-file.t
1..2
ok 1 - parsed ./debian/control file cleanly
not ok 2 - parsed ./debian/control.in file cleanly

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact||k...@bywatersolutions.com
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

--- Comment #9 from Katrin Fischer  ---
The patch proposes a new dependency libparse-debcontrol-perl and there has been
some discussion about it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64313|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 65654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65654=edit
[SIGNED OFF] Bug 10112 - add test for ./debian/control* files

to test, apply patch...

1/ install libparse-debcontrol-perl package
apt-get install libparse-debcontrol-perl

2/ run successful tests
$ perl ./t/00-valid-debian-control-file.t  
1..2
ok 1 - parsed ./debian/control file cleanly
ok 2 - parsed ./debian/control.in file cleanly

3/ add some bad syntax to a file
$ sed -i -e '20i ---\' ./debian/control.in

4/ run failed tests
$ perl ./t/00-valid-debian-control-file.t
1..2
ok 1 - parsed ./debian/control file cleanly
not ok 2 - parsed ./debian/control.in file cleanly

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64313|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Mason James  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff
  Attachment #17751|0   |1
is obsolete||
  Attachment #64313|0   |1
is obsolete||

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #6 from Mason James  ---
Created attachment 64313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64313=edit
Bug 10112 - add test for ./debian/control* files

to test, apply patch...

1/ install libparse-debcontrol-perl package
apt-get install libparse-debcontrol-perl

2/ run successful tests
$ perl ./t/00-valid-debian-control-file.t  
1..2
ok 1 - parsed ./debian/control file cleanly
ok 2 - parsed ./debian/control.in file cleanly

3/ add some bad syntax to a file
$ sed -i -e '20i ---\' ./debian/control.in

4/ run failed tests
$ perl ./t/00-valid-debian-control-file.t
1..2
ok 1 - parsed ./debian/control file cleanly
not ok 2 - parsed ./debian/control.in file cleanly

--- Comment #7 from Josef Moravec  ---
What is an appropriate statuse of this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m...@kohaaloha.com

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
If we had such tests, they should generate the control file out of the
control.in file as Robin does, and test it instead.  Because we want to test
the control file generation, not the validity of the current file.

It could be done on a temporary directory as other tests do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m, tomasco...@gmail.com

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Tomas, Does this make sense for you?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion
 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm test fails for me, I think Parse::DebControl might be a new dependency?
Do we want to add this dependency for testing an automatically generated file?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

--- Comment #1 from Mason James m...@kohaaloha.com ---
Created attachment 17664
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17664action=edit
Bug 10112 - add test for ./debian/control file

to test, apply patch...

- run successful test
$ perl ./t/00-valid-debian-control-file.t
1..1
ok 1 - parsed ./debian/control file ok

- add bad string to ./debian/control file
$ sed -i -e '20i ---\' ./debian/control

- run failed test
$ perl ./t/00-valid-debian-control-file.t
1..1
not ok 1 - parsed ./debian/control file ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10112] add test for ./debian/control file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Blocks||8158

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/