[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Blocks|10263 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #12 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Blocks|9032| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Blocks|10276 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Blocks||10263 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Blocks|10263 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18356|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #11 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Please note that I adjusted the commit message to include the example usage found in the POD. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #17969|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18356 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18356action=edit Bug 10206 - Add Koha TT Plugin - Koha.Preference This plugin is meant to be a place to put general purpose TT functions directly related to Koha. If a plugin is not a filter, and does not have more than one subroutine, that subroutine most likely belongs in this TT plugin. This first and only function the plugin currently has is Preference, which allows a template to get the value of a system preference without, it needing to be passed in from a perl script. This plugin was already tested and signed off as part of bug 7441. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #7 from Kyle M Hall kyle.m.h...@gmail.com --- My bad ; ) I've removed all the unnecessary code from this new patch. Kyle (In reply to comment #5) Changing status to reflect need for clarification. Why C4::Koha? Are there specific functions in that module you recommend to use? If so, maybe add this in the pod lines? Typo replated. Use Template::Plugin not needed? Use base seems enough. Leaving the name as-is.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18357 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18357action=edit Bug 10206 - Add Koha TT Plugin - Koha.Preference This plugin is meant to be a place to put general purpose TT functions directly related to Koha. If a plugin is not a filter, and does not have more than one subroutine, that subroutine most likely belongs in this TT plugin. This first and only function the plugin currently has is Preference, which allows a template to get the value of a system preference without, it needing to be passed in from a perl script. This plugin was already tested and signed off as part of bug 7441. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- False warning of qa-tools: critic FAIL Code before strictures are enabled at line 42, column 1. See page 429 of PBP. This is not true, since the code contains a use Modern::Perl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- With reference to former comments, adjustments make this patch pass QA. Nice feature, tested with future work for report 9032. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl --- Changing status to reflect need for clarification. Why C4::Koha? Are there specific functions in that module you recommend to use? If so, maybe add this in the pod lines? Typo replated. Use Template::Plugin not needed? Use base seems enough. Leaving the name as-is.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Blocks||9032 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA: Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Kyle, This works fine. Two questions remain: 1) To have this work, you currently do not need to do a use C4::Koha. Without that line, it works too. Why did you add it? 2) If it can be removed, please repair the typo: replated- related :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- Well, just to harass you a little bit more :) Why do you add use Template::Plugin btw? The use base seems to be enough? And could we find a better and still generic name for Koha.pm? I do not directly have the solution.. But just thinking about KohaInterface, Functions, GeneralPurpose, .., .. But we could start with Koha. Just trying to avoid it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Blocks||10276 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Blocks||10263 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Blocks||7441 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 17969 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17969action=edit Bug 10206 - Add Koha TT Plugin - Koha.Preference This plugin is meant to be a place to put general purpose TT functions directly related to Koha. If a plugin is not a filter, and does not have more than one subroutine, that subroutine most likely belongs in this TT plugin. This first and only function the plugin currently has is Preference, which allows a template to get the value of a system preference without, it needing to be passed in from a perl script. This plugin was already tested and signed off as part of bug 7441. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Blocks||10200 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
