[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 --- Comment #11 from Fridolin SOMERS --- (In reply to Tomás Cohen Arazi from comment #10) > It doesn't apply or work on 3.12.x because of its dependency on 9394. Please > provide a patch that applies to the stable branch, or comment if you think > 9394 should be backported (maybe other patches depend on it). Thanks Hie, For me, this bug does not depend on Bug 9394, its a small patch impacting old code. And actually, on 3.12.07, patch applies on 3.12.x branch. Can you confirm ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Koha Team Lyon 3 changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11250 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Depends on||9394 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 --- Comment #10 from Tomás Cohen Arazi --- It doesn't apply or work on 3.12.x because of its dependency on 9394. Please provide a patch that applies to the stable branch, or comment if you think 9394 should be backported (maybe other patches depend on it). Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Kyle M Hall changed: What|Removed |Added Attachment #18827|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 19190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19190&action=edit Bug 10247 - Too many reserves due to syspref does not show warning On intranet, when placing a reserve : If borrower as reached the reserves quota, a warning should appear : Cannot place hold * Too Many Holds: TEST has too many holds. This works when quota defined in circulation rules is reached but not when quota specified in syspref maxreserves is reached, in case this quota is lower than the one defined is circulation rules. This is because template param maxreserves is set twice, this patch corrects this bug. Also moves warnings and messages conditionnal variable from perl to template because it cause the same bug as for maxreserves. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Srdjan Jankovic changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Srdjan Jankovic changed: What|Removed |Added Attachment #18148|0 |1 is obsolete|| --- Comment #7 from Srdjan Jankovic --- Created attachment 18827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18827&action=edit [SIGNED-OFF] Bug 10247 - Too many reserves due to syspref does not show warning On intranet, when placing a reserve : If borrower as reached the reserves quota, a warning should appear : Cannot place hold * Too Many Holds: TEST has too many holds. This works when quota defined in circulation rules is reached but not when quota specified in syspref maxreserves is reached, in case this quota is lower than the one defined is circulation rules. This is because template param maxreserves is set twice, this patch corrects this bug. Also moves warnings and messages conditionnal variable from perl to template because it cause the same bug as for maxreserves. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 --- Comment #6 from Srdjan Jankovic --- Test plan : - Select a borrower and an item - Look at reserve quota for the borrower category, the item branch and the item type - Set maxreserves syspref with a quota lower than the circulation quota - Perform reserves for borrower to reach the quota - Try to perform one more reserve => You get the warning "too many holds" - Set maxreserves syspref with a quota higher than the circulation quota - Try to perform one more reserve => You get the warning "too many holds" Check you get a warning for alreadyreserved, none_available and alreadypossession cases. Check you get a message for expiry and diffbranch cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 --- Comment #5 from Fridolyn SOMERS --- (In reply to comment #4) > Well if it is in circulation rules (where it should be), maybe the syspref > is redundant. It is in circulation rules indeed but I think the syspref is used to temporary reduce reserves for all users, for holidays for example. Changing a syspref is much more easy that all circulation rules. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 --- Comment #4 from Srdjan Jankovic --- Well if it is in circulation rules (where it should be), maybe the syspref is redundant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 --- Comment #3 from Fridolyn SOMERS --- (In reply to comment #2) > Then wouldn't it be better to remove maxreserves syspref alltogether? Why removing such a feature ? this bug is just a small variable problem. Maybe open a discussion on koah-devel mailing list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||srd...@catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- Then wouldn't it be better to remove maxreserves syspref alltogether? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Fridolyn SOMERS changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Fridolyn SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 18148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18148&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
