[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: I never understand why 2 includes files are present. What is the way to keep just one of them? The patch fixes the described issue. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18249|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18306 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18306action=edit Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The Files tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com all tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #8 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #6) QA comment: I never understand why 2 includes files are present. What is the way to keep just one of them? I would agree that moving towards DRY (don't repeat yourself) would nice. Regardless, I've pushed this to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 --- Comment #9 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #6) I never understand why 2 includes files are present. What is the way to keep just one of them? From the original commit of that file: Adds a version of the include circ-menu.inc as circ-menu.tt this has the same functionality as the old include but does not require all the borrowers attributes to be passed as global scoped variables. http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=507c7f422485aaf7ae601b0a84bacdbaedac061c Perhaps there is a better way to handle the scope issue? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #18209|0 |1 is obsolete|| --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Created attachment 18248 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18248action=edit Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The Files tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #18248|0 |1 is obsolete|| --- Comment #5 from Nicole C. Engard neng...@gmail.com --- Created attachment 18249 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18249action=edit [SIGNED-OFF]Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The Files tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com all tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Nicole C. Engard neng...@gmail.com --- The link is there now but the link doesn't include the borrowernumber so it doesn't open right: /cgi-bin/koha/members/files.pl?borrowernumber= -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |ASSIGNED Version|3.10|master Summary|On pay fines tab patron |Link to patron files |tabs are missing|missing from circ-menu.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 18209 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18209action=edit Bug 10261 - Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The Files tab should appear in the left-hand sidebar menu. Other patron pages should show the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- See Bug 9917 for the solution to the problem with the routing lists link. I can't reproduce the problem with the statistics link in master or 3.10.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
