[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18234|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18236 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18236action=edit [PASSED QA] Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Signed-off-by: Magnus Enger mag...@enger.priv.no I have failed to recreate the problem on three different dev installs, both on Ubuntu and Debian, but the current patch does not break anything as far as I can tell, so I'm signing off. I tested with two libraries in the same search domain, with each library owning a different book by the same author. Searching for the author in - all libraries, - individual libraries and - the search domain that contains both libraries all return the expected results. Signed-off-by: Katrin Fischer katrin.fischer...@web.de All tests and QA script pass. I couldn't reproduce the problem, but didn't find any regressions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|gmcha...@gmail.com |jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 --- Comment #1 from Magnus Enger mag...@enger.priv.no --- Here are the errors I get when I limit to a group and get no results: OPAC, simple search: [Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01 2013] opac-search.pl: WARNING: query problem with kw,wrdl,rtrn=tolkien and () ZOOM error 10014 CCL parsing error (addinfo: Search word expected) from diag-set 'ZOOM' at /usr/share/koha/lib/C4/Search.pm line 378., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK OPAC, advanced search: [Sat May 18 14:04:13 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:13 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:13 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:13 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:22 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:22 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl [Sat May 18 14:04:22 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:22 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl [Sat May 18 14:04:23 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:23 2013] opac-search.pl: WARNING: query problem with kw,wrdl,rtrn=tolkien and () ZOOM error 10014 CCL parsing error (addinfo: Search word expected) from diag-set 'ZOOM' at /usr/share/koha/lib/C4/Search.pm line 378., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18227 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18227action=edit Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #18227|0 |1 is obsolete|| --- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18229 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18229action=edit Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Attachment #18229|0 |1 is obsolete|| --- Comment #4 from Magnus Enger mag...@enger.priv.no --- Created attachment 18234 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18234action=edit Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Signed-off-by: Magnus Enger mag...@enger.priv.no I have failed to recreate the problem on three different dev installs, both on Ubuntu and Debian, but the current patch does not break anything as far as I can tell, so I'm signing off. I tested with two libraries in the same search domain, with each library owning a different book by the same author. Searching for the author in - all libraries, - individual libraries and - the search domain that contains both libraries all return the expected results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10281] Search domains do not seem to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
