[Koha-bugs] [Bug 10305] _increment_barcode is called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10305] _increment_barcode is called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10305] _increment_barcode is called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA CC||m.de.r...@rijksmuseum.nl QA Contact||m.de.r...@rijksmuseum.nl --- Comment #5 from M. de Rooy --- Works. Looks good to me. There was no problem before, just a duplicate executing of a select max in the database. Note that the code used for this increment might still be wrong with concurrent edits, since the max calculation and the update of the table are quite separate parts in code. Reminds me of the discussion about the seqno engine.. No complaints from qa tools. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10305] _increment_barcode is called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10305] _increment_barcode is called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 M. de Rooy changed: What|Removed |Added Attachment #20227|0 |1 is obsolete|| --- Comment #4 from M. de Rooy --- Created attachment 21370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21370&action=edit Bug 10305 - _increment_barcode is called twice For some reason, _increment_barcode is called twice in succession in cataloguing/additem.pl Test Plan: 1) Enable autobarcode = incremental 2) Catalog an item, not the barcode 3) Apply this patch 4) Catalog another item, the barcode should be the next in line as previously. No change should be noted. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10305] _increment_barcode is called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Summary|Duplicate code in Search.pm |_increment_barcode is ||called twice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
