[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-12-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
This patch has been pushed to 3.8.x, and will be in 3.08.20.

Thanks Janusz!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Janusz!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Could it be that the English frameworks are missing a plugin here? I would have
never guessed that :) Trying again a little later - thx Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 QA Contact|jonathan.dru...@biblibre.co |katrin.fisc...@bsz-bw.de
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Working on this again now - Bernardo, could you file a new bug for the error
messages?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #20676|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 20877
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20877action=edit
[PASSED QA] Bug 10331 - Little errors in unimarc_field_4XX.pl (punctuation)

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Comment: Work as described, no koha-qa errors

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Copying the test plan from the bug report:

A.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 700 $a, $b, $f filled up
3) go to cataloguing - field 4XX of your choice, use the plugin to
  fetch data from biblio rec. mentioned in 2)
4) see the punctuation in $a -- it will be wrong (no closing bracket)

B.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 700 $a, $b, $c, $f filled up
3) go to cataloguing - field 4XX of your choice, use the plugin to
   fetch data from biblio rec. mentioned in 2)
4) see the punctuation in $a -- it will be wrong (dash instead of
   semicolon between original $c and $f, no closing bracket)

C.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 702 $a, $b, $c filled up
3) go to cataloguing - field 4XX of your choice, use the plugin to
   fetch data from biblio rec. mentioned in 2)
4) see the punctuation in $a -- it will be wrong (unnecessary semicolon
   after original $c, n.b. lacking space).

D.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 712 $a, $b filled up
3) go to cataloguing - field 4XX of your choice, use the plugin to
   fetch data from biblio rec. mentioned in b)
4) see the punctuation in $a -- it will be wrong (unnecessary opening
   bracket at the end).

Test plan, all tests and QA script pass.
Thx Bernardo for his testing and explanations!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m,
   ||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I have worked on this by using the provided test plan. I am dding some UNIMARC
users in CC - Jonathan, Mathieu, please add your comment, if you think this
needs more testing. 
The punctuation looked nice and sane to me - but who knows :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

--- Comment #11 from mathieu saby mathieu.s...@univ-rennes2.fr ---
We don't really use cataloguing modyule in Rennes 2 (all records imported from
Academic libraries catalog), so I won't test. But I am sure your tests are
fine.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #12 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Janusz!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
A looks good, but it seems something is wrong with my UNIMARC installation, as
I am not able to add authorities there :(

No matter what I enter in 100$a I always get: Unsupported UNIMARC character
encoding [] for XML output for UNIMARCAUTH; 100$a - a at
/usr/share/perl5/MARC/File/XML.pm line 505.

Jonathan, maybe you could take a look at this? Adding you as QA contact.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

--- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
(In reply to Katrin Fischer from comment #5)
 A looks good, but it seems something is wrong with my UNIMARC installation,
 as I am not able to add authorities there :(
 
 No matter what I enter in 100$a I always get: Unsupported UNIMARC character
 encoding [] for XML output for UNIMARCAUTH; 100$a - a at
 /usr/share/perl5/MARC/File/XML.pm line 505.
 
Katrin,
I used 'MMDDaengy01030204ba0' for 100a, just copied from UNIMARC auth
manual, and worked

But I noticed something else unrelated with the bug. If I add a new authority
and press save without filling any tag, the error message points the missing
fields but the tab number information is missing, at last in my install. For
example fixed length control f in tab ...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-08-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #18481|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 20675
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20675action=edit
Bug 10331 - Little errors in unimarc_field_4XX.pl (punctuation)

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Comment: Work as described, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-08-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #20675|0   |1
is obsolete||

--- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 20676
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20676action=edit
[SIGNED-OFF] Bug 10331 - Little errors in unimarc_field_4XX.pl (punctuation)

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Comment: Work as described, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-08-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-05-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Janusz Kaczmarek janus...@gmail.com changed:

   What|Removed |Added

  Attachment #18381|0   |1
is obsolete||

--- Comment #2 from Janusz Kaczmarek janus...@gmail.com ---
Created attachment 18481
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18481action=edit
Proposed patch - improved

Yet another error:

D.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 712 $a, $b filled up
3) go to cataloguing - field 4XX of your choice, use the plugin to fetch data
from biblio rec. mentioned in b)
4) see the punctuation in $a -- it will be wrong (unnecessary opening bracket
at the end).

New version of the patch covers this case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Janusz Kaczmarek janus...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |janus...@gmail.com

--- Comment #1 from Janusz Kaczmarek janus...@gmail.com ---
Created attachment 18381
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18381action=edit
Proposed patch

The patch corrects the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/