[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-06-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #8 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.1.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-06-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #7 from Galen Charlton  ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-06-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #18735|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  ---
Comment on attachment 18735
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18735
[ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl

Wrong report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-06-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

--- Comment #5 from Jonathan Druart  ---
Created attachment 18735
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18735&action=edit
[ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-06-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #18593|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  ---
Created attachment 18732
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18732&action=edit
Bug 10354 - Don't show optgroup Libraries when no search groups are defined

In the OPAC, if there are no search groups defined, there's no reason to
embed library choices inside an .  should only be
used to differentiate the list of individual libraries from search
groups. This patch removes the  when no search groups are
enabled.

To test, apply the patch and:

- Enable OpacAddMastheadLibraryPulldown.
- Create a library search group in Administration ->
  Libraries and Groups and enable it by checking the "show in search
  pulldown" box.
- View the library pulldown in the OPAC search bar. Libraries and groups
  should be separated into s.
- Disable your library search group and refresh the OPAC page. The
  pulldown of libraries should now display libraries with no .

Signed-off-by: Srdjan 
Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-06-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m
   Patch complexity|--- |Trivial patch
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart  ---
QA comment:
Simple patch. Works as described.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-06-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||srd...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-06-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #18544|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-06-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

--- Comment #2 from Srdjan Jankovic  ---
Created attachment 18593
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18593&action=edit
[Signed-Off] Bug 10354 - Don't show optgroup Libraries when no search groups
are defined

In the OPAC, if there are no search groups defined, there's no reason to
embed library choices inside an .  should only be
used to differentiate the list of individual libraries from search
groups. This patch removes the  when no search groups are
enabled.

To test, apply the patch and:

- Enable OpacAddMastheadLibraryPulldown.
- Create a library search group in Administration ->
  Libraries and Groups and enable it by checking the "show in search
  pulldown" box.
- View the library pulldown in the OPAC search bar. Libraries and groups
  should be separated into s.
- Disable your library search group and refresh the OPAC page. The
  pulldown of libraries should now display libraries with no .

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

--- Comment #1 from Owen Leonard  ---
Created attachment 18544
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18544&action=edit
Bug 10354 - Don't show optgroup Libraries when no search groups are defined

In the OPAC, if there are no search groups defined, there's no reason to
embed library choices inside an .  should only be
used to differentiate the list of individual libraries from search
groups. This patch removes the  when no search groups are
enabled.

To test, apply the patch and:

- Enable OpacAddMastheadLibraryPulldown.
- Create a library search group in Administration ->
  Libraries and Groups and enable it by checking the "show in search
  pulldown" box.
- View the library pulldown in the OPAC search bar. Libraries and groups
  should be separated into s.
- Disable your library search group and refresh the OPAC page. The
  pulldown of libraries should now display libraries with no .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined

2013-05-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354

Katrin Fischer  changed:

   What|Removed |Added

Summary|Dont's show optgroup|Don't show optgroup
   |Libraries when no search|Libraries when no search
   |groups are defined  |groups are defined

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/