[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Chris Hall changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #9 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy changed: What|Removed |Added Blocks|10441 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Chris Cormack changed: What|Removed |Added Attachment #19178|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 19273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19273&action=edit Bug 10386: VirtualShelves.t needs some more adjustments Most important: Does no longer delete all shelves! Checks if there are ten borrowers for testing. But even works without them :) When creating or modifying lists, takes name clashes into consideration. Small change to _CheckShelfName in VirtualShelves module. Making it possible to check a name for a list whose owner has been set to NULL. Note that a test like field=? with undef for placeholder will not work in MySql. Test plan: How do you test a test? Well, you could run it on various databases.. But for real hacking, you could also add some debug lines. I tested this by forcing 10 undefs in @borrowernumbers. And by overwriting the return value of randomname with an existing name. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Kyle M Hall changed: What|Removed |Added Attachment #18821|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 19178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19178&action=edit Bug 10386: VirtualShelves.t needs some more adjustments Most important: Does no longer delete all shelves! Checks if there are ten borrowers for testing. But even works without them :) When creating or modifying lists, takes name clashes into consideration. Small change to _CheckShelfName in VirtualShelves module. Making it possible to check a name for a list whose owner has been set to NULL. Note that a test like field=? with undef for placeholder will not work in MySql. Test plan: How do you test a test? Well, you could run it on various databases.. But for real hacking, you could also add some debug lines. I tested this by forcing 10 undefs in @borrowernumbers. And by overwriting the return value of randomname with an existing name. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 --- Comment #3 from M. de Rooy --- (In reply to comment #0) > Will also add two small new tests for AddShare from bug 9032. This patch does not depend on bug 9032. The tests for AddShare are added on bug 10441. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy changed: What|Removed |Added Blocks||10441 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 --- Comment #2 from M. de Rooy --- Created attachment 18821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18821&action=edit Bug 10386: VirtualShelves.t needs some more adjustments Most important: Does no longer delete all shelves! Checks if there are ten borrowers for testing. But even works without them :) When creating or modifying lists, takes name clashes into consideration. Small change to _CheckShelfName in VirtualShelves module. Making it possible to check a name for a list whose owner has been set to NULL. Note that a test like field=? with undef for placeholder will not work in MySql. Test plan: How do you test a test? Well, you could run it on various databases.. But for real hacking, you could also add some debug lines. I tested this by forcing 10 undefs in @borrowernumbers. And by overwriting the return value of randomname with an existing name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #1 from Galen Charlton --- (In reply to comment #0) > IMO this unit test should not just delete all records at the start. (Why > ruin my test database for lazy programming :) ? Indeed. I think a worthwhile goal would be for each DB-dependent test (or perhaps the DB-dependent test suite as a whole) to leave the database in essentially the same state it started in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||10290 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10290 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/