[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Jonathan Druart changed: What|Removed |Added Blocks||12243 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #37 from Galen Charlton --- Pushed to master. Thanks, Kyle! Please note the follow-up. The original patch did not work correctly with QueryParser, and unfortunately, there's a deeper bug in QP that is getting in the way. Consequently, the follow-up ensures that AggressiveMatchOnISBN doesn't make any change in behavior when UseQueryParser is on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Galen Charlton changed: What|Removed |Added Keywords||rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #36 from Martin Renvoize --- I'm happy that the followup fixes the problem. We're still passing qa script tests and the code looks good to me. Re-passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Martin Renvoize changed: What|Removed |Added Attachment #27222|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 27389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27389&action=edit [PASSED QA] Bug 10500 [QA Followup] - Add checks for empty isbn Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Martin Renvoize changed: What|Removed |Added Attachment #27220|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 27387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27387&action=edit [PASSED QA] Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match Signed-off-by: Tom McMurdo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Martin Renvoize changed: What|Removed |Added Attachment #27221|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 27388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27388&action=edit [PASSED QA] Bug 10500: Followup for UNIMARC In UNIMARC, the isbn index is ISBN. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #32 from Kyle M Hall --- Created attachment 27222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27222&action=edit Bug 10500 [QA Followup] - Add checks for empty isbn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Attachment #22911|0 |1 is obsolete|| --- Comment #31 from Kyle M Hall --- Created attachment 27221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27221&action=edit Bug 10500: Followup for UNIMARC In UNIMARC, the isbn index is ISBN. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Attachment #22910|0 |1 is obsolete|| --- Comment #30 from Kyle M Hall --- Created attachment 27220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27220&action=edit Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match Signed-off-by: Tom McMurdo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Nicole C. Engard changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #29 from Nicole C. Engard --- Peggy found an error - well we found an error when Peggy reported a problem so I'm marking this as Failed QA until it's fixed. That patch for the ISBN normalizing was throwing the error if the record contained NULL for the isbn field. Kyle can explain/fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Blocks||11368 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #28 from Peggy Thrasher --- My apologies. When I use it correctly it works wonderfully. 23 matches. My catalogers can't wait!! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #27 from Peggy Thrasher --- Created attachment 22919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22919&action=edit 23 MARC records from OCLC I'm really looking forward to this fix! We order from B&T and import their brief MARC records. When the books arrive, we download complete records from OCLC and overlay the brief ones. I am supplying 2 files from today at my library, OriginalMARCRecords is 22 MARC records from B&T. NewMARCREcords is 23 matching MARC records from OCLC (there is an extra record in this file because one of the titles is in here twice). Of the 22 records, only 11 overlayed. This was my first time using a sandbox, so I'd repeat my test if I were you... Hopefully this will point out some scenarios that you didn't envision. Peggy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Peggy Thrasher changed: What|Removed |Added CC||p.thras...@dover.nh.gov --- Comment #26 from Peggy Thrasher --- Created attachment 22918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22918&action=edit 22 MARC records from B&T -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 mathieu saby changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #25 from mathieu saby --- >From the title of the bug, I thought it was about the ISBN13/ISBN10 matching, but it is not the case. Do you plan to do something too for that ? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Jonathan Druart changed: What|Removed |Added Patch complexity|--- |Medium patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #24 from Jonathan Druart --- I don't think it is blocker and I don't know if it should be required. I let the RM to decide. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #23 from Jonathan Druart --- Created attachment 22911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22911&action=edit Bug 10500: Followup for UNIMARC In UNIMARC, the isbn index is ISBN. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Jonathan Druart changed: What|Removed |Added Attachment #22840|0 |1 is obsolete|| Attachment #22841|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart --- Created attachment 22910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22910&action=edit Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match Signed-off-by: Tom McMurdo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #21 from Jonathan Druart --- (In reply to Kyle M Hall from comment #20) > Thanks for the additional data. I don't think this is really a problem with > this patch. When you add a match check, it's looking for exact values > between two marc fields. The code looks for exact values but does it what it should do? We can imagine a matching rule on the title and a match check on the isbn. The match check on the isbn could use the variations of isbn too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #20 from Kyle M Hall --- (In reply to Jonathan Druart from comment #16) > (In reply to Kyle M Hall from comment #15) > > Jonathan, I'm unable to reproduce your problem. > > Ok, I think I found the problem. I suspect you don't have a "Required match > checks" defined for your isbn matching rule. I have a check defined as the > matchpoint component (010$a, 0, 0) for source and target. > I don't know what is this match check and I don't know if your patch must > impact them. Thanks for the additional data. I don't think this is really a problem with this patch. When you add a match check, it's looking for exact values between two marc fields. I think it makes sense for the match to fail in this case, as you're causing the matching to be much for strict, while this patch is allowing for less strict matching. Does that make sense? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Attachment #21258|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall --- Created attachment 22841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22841&action=edit Bug 10500: Followup for UNIMARC In UNIMARC, the isbn index is ISBN. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Attachment #21257|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 22840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22840&action=edit Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match Signed-off-by: Tom McMurdo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #17 from Tom McMurdo --- Just following up: where are we in QA with this ISBN matching fix? I don't mean to seem impatient, but I know that our consortium is anxious to see this added. Let me know what comes next. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #16 from Jonathan Druart --- (In reply to Kyle M Hall from comment #15) > Jonathan, I'm unable to reproduce your problem. Ok, I think I found the problem. I suspect you don't have a "Required match checks" defined for your isbn matching rule. I have a check defined as the matchpoint component (010$a, 0, 0) for source and target. I don't know what is this match check and I don't know if your patch must impact them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #15 from Kyle M Hall --- Jonathan, I'm unable to reproduce your problem. The output you posted looks good and correct. Are you rebuilding your zebra index after step 1? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Attachment #21072|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 21258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21258&action=edit Bug 10500: Followup for UNIMARC In UNIMARC, the isbn index is ISBN. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Attachment #20744|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 21257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21257&action=edit Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match Signed-off-by: Tom McMurdo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500
--- Comment #12 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #11)
> > 1/ In UNIMARC the isbn index is "ISBN". I will provide a followup.
>
> Thanks!
>
> > 2/ Even with this patch, I got "0 records with at least one match in catalog
> > per matching rule "ISBN"".
>
> It that with the new syspref on, off, or both?
both.
> > Some debugging: If I add the line:
> > warn "$source_key $target_key" unless $source_key eq $target_key;
> > to C4/Matcher.pm:770 (in the foreach @{ $matchchecks } loop).
> > I got, in logs:
> > "0394502884 RANDOMHOUSE 0394502884 UNRANDOMHOUSE"
> >
> > And C4::Matcher::get_matches always returns an empty array.
> >
> > Marked as Failed QA (but maybe I am wrong somewhere...)
>
> You use use Data::Dumper on @source_keys on line 639? That will tell use if
> the isbn's are being transformed correctly.
Yes, I get: ['0-394-50288-4', '0-394-50288-4', '978-0-394-50288-5',
'0394502884', '9780394502885']
> Does the unit test pass for you?
Yes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500
--- Comment #11 from Kyle M Hall ---
> 1/ In UNIMARC the isbn index is "ISBN". I will provide a followup.
Thanks!
> 2/ Even with this patch, I got "0 records with at least one match in catalog
> per matching rule "ISBN"".
It that with the new syspref on, off, or both?
> Some debugging: If I add the line:
> warn "$source_key $target_key" unless $source_key eq $target_key;
> to C4/Matcher.pm:770 (in the foreach @{ $matchchecks } loop).
> I got, in logs:
> "0394502884 RANDOMHOUSE 0394502884 UNRANDOMHOUSE"
>
> And C4::Matcher::get_matches always returns an empty array.
>
> Marked as Failed QA (but maybe I am wrong somewhere...)
You use use Data::Dumper on @source_keys on line 639? That will tell use if the
isbn's are being transformed correctly. Does the unit test pass for you?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #10 from Jonathan Druart --- Created attachment 21072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21072&action=edit Bug 10500: Followup for UNIMARC In UNIMARC, the isbn index is ISBN. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||jonathan.dru...@biblibre.co
||m
--- Comment #9 from Jonathan Druart ---
It does not work for me.
1/ In UNIMARC the isbn index is "ISBN". I will provide a followup.
2/ Even with this patch, I got "0 records with at least one match in catalog
per matching rule "ISBN"".
Some debugging: If I add the line:
warn "$source_key $target_key" unless $source_key eq $target_key;
to C4/Matcher.pm:770 (in the foreach @{ $matchchecks } loop).
I got, in logs:
"0394502884 RANDOMHOUSE 0394502884 UNRANDOMHOUSE"
And C4::Matcher::get_matches always returns an empty array.
Marked as Failed QA (but maybe I am wrong somewhere...)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Melissa Lefebvre changed: What|Removed |Added Attachment #20732|0 |1 is obsolete|| --- Comment #8 from Melissa Lefebvre --- Created attachment 20744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20744&action=edit Bug 10500 - Improve isbn matching when importing records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Melissa Lefebvre changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||meli...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #7 from Kyle M Hall --- *** Bug 7382 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Tom McMurdo changed: What|Removed |Added CC||thomas.mcmu...@state.vt.us --- Comment #6 from Tom McMurdo --- This has been tested and appears to work. I sign off on it. Tom McMurdo Collections & Digital Initiatives Librarian Vermont Department of Libraries thomas.mcmu...@state.vt.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Attachment #19174|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 20732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20732&action=edit Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Kyle M Hall --- I'm afraid I was able to apply this patch cleanly to current master. I'm not sure why you are unable to apply it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Koha Team Lyon 3 changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||k...@univ-lyon3.fr --- Comment #3 from Koha Team Lyon 3 --- tested on a biblibre sandbox: pplying: Bug 10500 - Improve isbn matching when importing records Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Koha.pm Auto-merging C4/Matcher.pm CONFLICT (content): Merge conflict in C4/Matcher.pm Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging t/Koha.t CONFLICT (content): Merge conflict in t/Koha.t Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Attachment #19172|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 19174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19174&action=edit Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #1 from Kyle M Hall --- Created attachment 19172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19172&action=edit WIP - Improve ISBN Matching -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10500] Improve isbn matching when importing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
