[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #17 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #16 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #14 from M. de Rooy --- I have no errors while running koha-qa. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #12 from M. de Rooy --- Status back to Signed off ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Kyle M Hall --- Excellent! Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What|Removed |Added Attachment #19650|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #11 from M. de Rooy --- Kyle, I edited the lines with the commit id's in the commit message. Now this display problem is gone. But this seems to not to worry git itself, just bugzilla.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #10 from M. de Rooy --- Created attachment 19653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19653&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What|Removed |Added Attachment #19652|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What|Removed |Added Attachment #19650|1 |0 is obsolete|| CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What|Removed |Added Attachment #19650|0 |1 is obsolete|| --- Comment #9 from M. de Rooy --- Created attachment 19652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19652&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #8 from Kyle M Hall --- Confirmed, I have no idea how I got that error. However, the more important issue to me is the file_not_specified_in_diff you can see looking here: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19650&action=diff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What|Removed |Added Attachment #19537|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 19650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19650&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #6 from Jonathan Druart --- Kyle, I cannot reproduce: $ git reset --hard origin/master $ git bz apply 10504 Bug 10504 - C4::Acquisition::ModOrderItem is unused 19537 - [SIGNED-OFF] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10504: Remove the unused C4::Acq::ModOrderItem routine $ qa -c 1 -v 2 testing 1 commit(s) (applied to 275f405 'Bug 10514: improve visibility of Add ') OKC4/Acquisition.pm OK pod OK forbidden patterns OK valid OK critic OKcataloguing/moveitem.pl OK pod OK forbidden patterns OK valid OK critic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #5 from Kyle M Hall --- koha-qa.pl gives this failure FAIL C4/Acquisition.pm FAIL pod *** WARNING: No items in =over / =back list in file C4/Acquisition.pm *** ERROR: Spurious text after =cut in file C4/Acquisition.pm I don't believe this is a result of your patch though. However, looking at the diff for your patch, I see file_not_specified_in_diff, which doesn't look like something we want to have in there! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Srdjan Jankovic changed: What|Removed |Added Attachment #19305|0 |1 is obsolete|| --- Comment #4 from Srdjan Jankovic --- Created attachment 19537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19537&action=edit [SIGNED-OFF] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart changed: What|Removed |Added Attachment #19220|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 19305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19305&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Test plan: - git grep ModOrderItem should return no result. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #2 from Chris Cormack --- Comment on attachment 19220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19220 Bug 10504: Remove the unused C4::Acq::ModOrderItem routine Review of attachment 19220: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10504&attachment=19220) - C4/Acquistion.pm still is exporting ModOrderItem, so we need to clean that too. grep ModOrderItem -r * C4/Acquisition.pm:&NewOrderItem &ModOrderItem &ModItemOrder -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #1 from Jonathan Druart --- Created attachment 19220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19220&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Test plan: - git grep ModOrderItem should return no result. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
