[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14338 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11784 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Galen Charlton gmcha...@gmail.com --- I've pushed to this master, as it's a dependency for the successful inclusion of DBIx::Class. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20801|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 21923 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21923action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #21923|0 |1 is obsolete|| --- Comment #14 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 21931 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21931action=edit [SIGNED-OFF] Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 I'm just a bot git...@bugs.koha-community.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||git...@bugs.koha-community. ||org --- Comment #12 from I'm just a bot git...@bugs.koha-community.org --- Applying: Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Using index info to reconstruct a base tree... Minstaller/data/mysql/kohastructure.sql Minstaller/data/mysql/updatedatabase.pl Mmembers/printinvoice.pl Falling back to patching base and 3-way merge... Auto-merging members/printinvoice.pl CONFLICT (content): Merge conflict in members/printinvoice.pl Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Patch failed at 0001 Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run git am --continue. If you prefer to skip this patch, run git am --skip instead. To restore the original branch and stop patching, run git am --abort. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20765|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20801 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20801action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- That sounds good to me! If you are happy I'll proceed with sign-off, and we'll let QA team cast the final verdict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #9 from Srdjan Jankovic srd...@catalyst.net.nz --- 1. I had problems with either borrowers changing card numbers, or being removed (have no idea what is possible, but the situation is real, I'm using a clients prod dump). In order to establish new PK there must be no nulls, so patronimage should be purged first, something on the lines of DELETE FROM patronimage wHERE NOT EXISTS(borrower). 2. The patch adds UNIQUE and then PK. I understand why UNIQUE, but that is maybe an overkill. So it should either be removed (as in not included in the statement), or dropped afterwards. 3. There should be an FK statement to replace dropped FK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20724|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20765 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20765action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Thanks for the info! Does this new patch have a more sensible database update? Kyle (In reply to Srdjan Jankovic from comment #4) DDL statements ( ALTER TABLE ) cannot be rolled back, and should not be part of transaction. In that respect the update transaction makes no sense, and should be removed. If some kind of failure rollback needs to be implemented, it has to be done in some other way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #7 from Srdjan Jankovic srd...@catalyst.net.nz --- No, this is as good as it can be. The only thing that I'm not sure of is whether you should reinstate AutoCommit and RaiseError straight after eval. I hate to admit that whenever I had a db update it was always simple and I started with copying one before, so I'm not familiar with AutoCommit and RaiseError policy in updatedatabase.pl. In a way, because it is a single change within transaction, you can even get away with not changing AutoCommit at all (RaiseError is still in order). If you are happy I'll proceed with sign-off, and we'll let QA team cast the final verdict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #4 from Srdjan Jankovic srd...@catalyst.net.nz --- DDL statements ( ALTER TABLE ) cannot be rolled back, and should not be part of transaction. In that respect the update transaction makes no sense, and should be removed. If some kind of failure rollback needs to be implemented, it has to be done in some other way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20722 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20722action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20722|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20723 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20723action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20723|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20724 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20724action=edit Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable patronimages 4) Verify patron images are still displaying correctly 5) Test deleting a patron image 6) Test adding a patron image from moremember.pl 7) Test adding a patron image from tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Blocks||8798 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/