[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10498 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #17 from David Cook --- I totally missed Martin's comment on this one... I don't really have time to work on this at the moment, so happy for someone else to take it over. Martin, you could take it over, and I could test it perhaps? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #16 from Martin Renvoize --- We have a series of public libraries that are still keen on this.. so I think it's still valid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #15 from Marc Véron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #14 from Martin Renvoize --- Can we get this one moving again... I'm trying ot get some of the older 'In Discussion' bugs on the road again. David, do you think it's viable to add this granularity to the display of the alert? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #13 from David Cook --- (In reply to Jonathan Druart from comment #12) > (In reply to Katrin Fischer from comment #11) > > Hm, not sure I understand the question without testing. An alert makes > > sense, I think, if it's a hold on the record or an item-level hold on one of > > the on order items. If there are item-level holds on other items - the > > information might not be needed. > > Yes, that's it. > You order 3 items (X, Y, Z) for a biblio (in the same order) and a patron > places Y on hold (item-level hold). When you receive X or Z, the screen > displays "The biblio 'foo' has 3 item-level pending reserves" (not exactly > sure what was the exact message). > I was just wondering if it is relevant to get this message since it does not > concern the received item. Ahhh. I understand now. Hmm...that might be true. I can't recall at the moment exactly how receiving items works when items are created during the placing of an order. I suppose this probably needs to be investigated. I suppose you might order Volume 1, 2, 3 and biblio 'foo', and there might only be an item-level hold on Volume 2. If you're receiving Volume 1, it wouldn't be relevant to receive a hold notification. Hmm. I'll need to poke around at this one some more sometime. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #12 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > Hm, not sure I understand the question without testing. An alert makes > sense, I think, if it's a hold on the record or an item-level hold on one of > the on order items. If there are item-level holds on other items - the > information might not be needed. Yes, that's it. You order 3 items (X, Y, Z) for a biblio (in the same order) and a patron places Y on hold (item-level hold). When you receive X or Z, the screen displays "The biblio 'foo' has 3 item-level pending reserves" (not exactly sure what was the exact message). I was just wondering if it is relevant to get this message since it does not concern the received item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #11 from Katrin Fischer --- Hm, not sure I understand the question without testing. An alert makes sense, I think, if it's a hold on the record or an item-level hold on one of the on order items. If there are item-level holds on other items - the information might not be needed. I notice that the patch uses the term "reserves" - I think we try to use "holds" allover to be consistent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #10 from David Cook --- (In reply to Jonathan Druart from comment #9) > (In reply to David Cook from comment #7) > > If there are item-level holds for items not attached to that order and > > there are no bib-level holds, the message will just say that there are > > pending reserves for that bib record. > > Are you sure it is relevant? I would like to have others points of view on > this alert. Why the librarian would want to have this information? > > Maybe Nicole or Katrin could give us their opinion on this? I'm not sure that I understand your question. Are you asking why an alert is relevant at all? Overall, the alert is needed so that library staff can immediately know that there is a hold on the record at hand. This prompts them to process the physical items more quickly than others so that they can fill the hold. Item-level hold alerts are needed for when a hold has been placed on particular items (the scenario being that items were when "placing an order" or manually before placing the order). Bibliographic record hold alerts are needed for when there is a hold on the record but no items have been created yet (the scenario being that items are created when "receiving an order" or manually afterwards during cataloguing). I suppose there might be scenarios where there is a bibliographic record that has items and there are bib-level holds for that record...and there would be an alert that there are holds on the record when receiving the order even though there are already existing items which may or may not be available to fill that hold. However, just a reminder that the record for which they are receiving items seems relevant to me. In the libraries I've worked in, records with holds always received a higher priority for processing than records without holds. Without this alert, each record would need to be manually checked for holds and that would slow down the acquisitions process. I'm happy to hear what others have to say though :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Jonathan Druart changed: What|Removed |Added Status|Signed Off |In Discussion CC||jonathan.dru...@biblibre.co ||m, katrin.fisc...@bsz-bw.de --- Comment #9 from Jonathan Druart --- (In reply to David Cook from comment #7) > If there are item-level holds for items not attached to that order and > there are no bib-level holds, the message will just say that there are > pending reserves for that bib record. Are you sure it is relevant? I would like to have others points of view on this alert. Why the librarian would want to have this information? Maybe Nicole or Katrin could give us their opinion on this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Srdjan Jankovic changed: What|Removed |Added Attachment #19974|0 |1 is obsolete|| --- Comment #8 from Srdjan Jankovic --- Created attachment 19983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19983&action=edit [SIGNED-OFF] Bug 10638 - Show alert when receiving an order with holds/reserves This patch adds an alert message in Acquisitions when receiving new orders. If there are bib-level holds for the bib record attached to that order, it gives a count of the bib-level holds. If there are item-level holds for items attached to that order, it shows a count of the items as well as displaying the barcodes for the items that have holds/reserves on them. If there are item-level holds for items not attached to that order and there are no bib-level holds, the message will just say that there are pending reserves for that bib record. TEST PLAN 1) Set AcqCreateItem to "placing an order" 2) Place an order in Acquisitions 3) Create three or four items when placing that order 4) In the OPAC or staff client, place a hold on one item 5) Receive the order 6) Note that there is no alert message about the hold/reserve 7) Apply the patch 8) Receive another item for that order 9) Note that there should now be a yellow alert message at the top of the parcel.pl screen. 10) The message text will vary depending on the reserve/hold situation. If there are bib-level holds, it will display a count of bib-level holds. If there are item-level holds for items attached to that order, it will show a count of those holds and print out their barcodes. (N.B. if you are receiving part of an order, your order number will change, so it will only print information for the received items that are attached to this new order, rather than all items including the original order.) If there are item-level holds for items attached to a different order or no order at all, no specific information will be printed. It will just say that there are pending reserves for that record (or that there are bib-level holds, if there are bib-level holds). Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 David Cook changed: What|Removed |Added Attachment #19912|0 |1 is obsolete|| --- Comment #7 from David Cook --- Created attachment 19974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19974&action=edit Bug 10638 - Show alert when receiving an order with holds/reserves This patch adds an alert message in Acquisitions when receiving new orders. If there are bib-level holds for the bib record attached to that order, it gives a count of the bib-level holds. If there are item-level holds for items attached to that order, it shows a count of the items as well as displaying the barcodes for the items that have holds/reserves on them. If there are item-level holds for items not attached to that order and there are no bib-level holds, the message will just say that there are pending reserves for that bib record. TEST PLAN 1) Set AcqCreateItem to "placing an order" 2) Place an order in Acquisitions 3) Create three or four items when placing that order 4) In the OPAC or staff client, place a hold on one item 5) Receive the order 6) Note that there is no alert message about the hold/reserve 7) Apply the patch 8) Receive another item for that order 9) Note that there should now be a yellow alert message at the top of the parcel.pl screen. 10) The message text will vary depending on the reserve/hold situation. If there are bib-level holds, it will display a count of bib-level holds. If there are item-level holds for items attached to that order, it will show a count of those holds and print out their barcodes. (N.B. if you are receiving part of an order, your order number will change, so it will only print information for the received items that are attached to this new order, rather than all items including the original order.) If there are item-level holds for items attached to a different order or no order at all, no specific information will be printed. It will just say that there are pending reserves for that record (or that there are bib-level holds, if there are bib-level holds). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #6 from David Cook --- (In reply to Srdjan Jankovic from comment #5) > It's a hairy issue HTML an HTTP stepping on each other's toes, and browsers > trying to be "helpful" does not help at all. Re links, google for "html > escape ampersand" or similar. > However, in this case, I believe we are talking Redirect header, which is > not HTML, so no escaping applies. Ahhh, I understand now. Thanks for the clarification :). I'll send a new patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #5 from Srdjan Jankovic --- It's a hairy issue HTML an HTTP stepping on each other's toes, and browsers trying to be "helpful" does not help at all. Re links, google for "html escape ampersand" or similar. However, in this case, I believe we are talking Redirect header, which is not HTML, so no escaping applies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #4 from David Cook --- (In reply to Srdjan Jankovic from comment #3) > & is a reserved character in urls, and should not be replaced with & Do you have a source for that Srdjan? It's not that I doubt you, but it's a subject that I've pondered and tried researching many times. If you look elsewhere in Koha, you'll notice query strings that use the & entity instead of &. In terms of XHTML validation, I've seen/heard of issues with validation when there are links that use & instead of &. Browsers seem to handle & just fine instead of &. Examples of & over &: admin/z3950servers.tt opac-detail.tt opac-results.tt etc... Even if that is the case though, I'm sure that could be added in a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Srdjan Jankovic changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- & is a reserved character in urls, and should not be replaced with & -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 David Cook changed: What|Removed |Added Attachment #19911|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 19912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19912&action=edit Bug 10638 - Show alert when receiving an order with holds/reserves Bug 10638 - Show alert when receiving an order with holds/reserves This patch adds an alert message in Acquisitions when receiving new orders. If there are bib-level holds for the bib record attached to that order, it gives a count of the bib-level holds. If there are item-level holds for items attached to that order, it shows a count of the items as well as displaying the barcodes for the items that have holds/reserves on them. If there are item-level holds for items not attached to that order and there are no bib-level holds, the message will just say that there are pending reserves for that bib record. TEST PLAN 1) Set AcqCreateItem to "placing an order" 2) Place an order in Acquisitions 3) Create three or four items when placing that order 4) In the OPAC or staff client, place a hold on one item 5) Receive the order 6) Note that there is no alert message about the hold/reserve 7) Apply the patch 8) Receive another item for that order 9) Note that there should now be a yellow alert message at the top of the parcel.pl screen. 10) The message text will vary depending on the reserve/hold situation. If there are bib-level holds, it will display a count of bib-level holds. If there are item-level holds for items attached to that order, it will show a count of those holds and print out their barcodes. (N.B. if you are receiving part of an order, your order number will change, so it will only print information for the received items that are attached to this new order, rather than all items including the original order.) If there are item-level holds for items attached to a different order or no order at all, no specific information will be printed. It will just say that there are pending reserves for that record (or that there are bib-level holds, if there are bib-level holds). [dac2013: This patch obsoletes one that had the wrong commit title...] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff CC||dc...@prosentient.com.au Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #1 from David Cook --- Created attachment 19911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19911&action=edit Bug 10638 - Show alert when receiving an order with holds/reserves This patch adds an alert message in Acquisitions when receiving new orders. If there are bib-level holds for the bib record attached to that order, it gives a count of the bib-level holds. If there are item-level holds for items attached to that order, it shows a count of the items as well as displaying the barcodes for the items that have holds/reserves on them. If there are item-level holds for items not attached to that order and there are no bib-level holds, the message will just say that there are pending reserves for that bib record. TEST PLAN 1) Set AcqCreateItem to "placing an order" 2) Place an order in Acquisitions 3) Create three or four items when placing that order 4) In the OPAC or staff client, place a hold on one item 5) Receive the order 6) Note that there is no alert message about the hold/reserve 7) Apply the patch 8) Receive another item for that order 9) Note that there should now be a yellow alert message at the top of the parcel.pl screen. 10) The message text will vary depending on the reserve/hold situation. If there are bib-level holds, it will display a count of bib-level holds. If there are item-level holds for items attached to that order, it will show a count of those holds and print out their barcodes. (N.B. if you are receiving part of an order, your order number will change, so it will only print information for the received items that are attached to this new order, rather than all items including the original order.) If there are item-level holds for items attached to a different order or no order at all, no specific information will be printed. It will just say that there are pending reserves for that record (or that there are bib-level holds, if there are bib-level holds). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
