[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #32 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #31 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #30 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Martin Renvoize changed: What|Removed |Added Attachment #83670|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 85122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85122&action=edit Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page Signed-off-by: Pierre-Marc Thibault Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #29 from Martin Renvoize --- Well done for getting to the bottom of this challenging one Katrin. All works for me, no regressions found and the QA scripts all pass.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Martin Renvoize changed: What|Removed |Added Attachment #83671|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 85123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85123&action=edit Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #26 from Pierre-Marc Thibault --- Your test plan works and it doesn't seem there's a problem with the extended steps either. Sorry, for the mistakes I made while editing the page, I will try to be more focus next time. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #25 from Pierre-Marc Thibault --- (In reply to Pierre-Marc Thibault from comment #22) > Created attachment 83669 [details] [review] > Bug 10676: Add unit tests - GetItemsInfo > > To test: > prove t/db_dependent/Items.t > > Signed-off-by: Pierre-Marc Thibault > > https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83668|0 |1 is obsolete|| --- Comment #23 from Pierre-Marc Thibault --- Created attachment 83670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83670&action=edit Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83669|0 |1 is obsolete|| --- Comment #24 from Pierre-Marc Thibault --- Created attachment 83671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83671&action=edit Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83631|0 |1 is obsolete|| --- Comment #22 from Pierre-Marc Thibault --- Created attachment 83669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83669&action=edit Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83630|0 |1 is obsolete|| --- Comment #21 from Pierre-Marc Thibault --- Created attachment 83668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83668&action=edit Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page Signed-off-by: Pierre-Marc Thibault https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer changed: What|Removed |Added Summary|OpacHiddenItems not working |OpacHiddenItems not working |for restricted |for restricted on OPAC ||detail --- Comment #20 from Katrin Fischer --- If I understood correctly, you can still sign off. This deals with the case, that not all items on a record are hidden and the OPAC detail pages. You could extend the test plan a bit: - Verify that if the restricted item is the only item, the record cannot be found in the OPAC - Verfy you can't access the record directly by URL - Verify the item information in the results is correct >From what Joy said those already work, but should not be broken by the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/