[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords||rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #20615|0 |1 is obsolete|| --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 20647 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20647action=edit Bug 10685: Inappropriate uses of finish in C4::Accounts.pm This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Similar to other patches from the same author. Run prove t/db_dependent/Accounts.t without errors No koha-qa errors Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #20110|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20615 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20615action=edit Bug 10685: Inappropriate uses of finish in C4::Accounts.pm This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Similar to other patches from the same author. Run prove t/db_dependent/Accounts.t without errors No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 --- Comment #1 from kenza kenza.z...@biblibre.com --- Created attachment 20110 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20110action=edit Bug 10685: Inappropriate uses of finish in C4::Accounts.pm This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/