[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38008
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38008action=edit
Bug 10706: Add test

I found this test this morning in my working directory, could be useful here :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #37988|0   |1
is obsolete||
  Attachment #38008|0   |1
is obsolete||
  Attachment #38046|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38048
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38048action=edit
[PASSED QA] Bug 10706: Search reports by id

This patch adds the ability to search reports by their id.

Test plan:
1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved)
2/ Search for a report id (refer to the ID column in the table)
3/ The result should be consistent

That the filters are not kept, already existed.

Signed-off-by: Nick Clemens n...@quecheelibrary.org
Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38049
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38049action=edit
[PASSED QA] Bug 10706: Add test

Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38051
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38051action=edit
[PASSED QA] Bug 10706: Delete saved_reports to be sure no reports existed

We need to be sure no report existed before launching the tests.

Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I apologize to the test. It's innocent.

But: somehow I manage to make all my reports disappear. Can someone try and
confirm?

1) Search for an existing keyword or number = results are ok
2) Search for a non-existing keyword or number = 'no results found' - ok
3) Now click 'used saved' - no reports are showing up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #5)
 I apologize to the test. It's innocent.
 
 But: somehow I manage to make all my reports disappear. Can someone try and
 confirm?
 
 1) Search for an existing keyword or number = results are ok
 2) Search for a non-existing keyword or number = 'no results found' - ok
 3) Now click 'used saved' - no reports are showing up

Confirmed, but not related to this patch (come from 
commit 8360343fbc1fb4d8806db951aea8b04ad99d00c1
Date:   Wed Apr 6 14:56:45 2011 +1200
Bug 6033 : wr77488 : report selection filter

Please open a new bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38046
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38046action=edit
Bug 10706: Delete saved_reports to be sure no reports existed

We need to be sure no report existed before launching the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I filed a new bug report bug 14008

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||14008

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|normal  |enhancement
 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jonathan,

unfunnily... this test seems to delete any existing reports in your database
(which is why it failed for me the first time and passed the second time I ran
it... ) Could you please fix that even if it's a bit scope creeping?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37969
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37969action=edit
Bug 10706: Search reports by id

This patch adds the ability to search reports by their id.

Test plan:
1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved)
2/ Search for a report id (refer to the ID column in the table)
3/ The result should be consistent

That the filters are not kept, already existed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

  Attachment #37969|0   |1
is obsolete||

--- Comment #2 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 37988
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37988action=edit
Bug 10706: Search reports by id

This patch adds the ability to search reports by their id.

Test plan:
1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved)
2/ Search for a report id (refer to the ID column in the table)
3/ The result should be consistent

That the filters are not kept, already existed.

Signed-off-by: Nick Clemens n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/