[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Kenza! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Katrin Fischer changed: What|Removed |Added Attachment #20349|0 |1 is obsolete|| Attachment #20350|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 20598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20598&action=edit [PASSED QA] Bug 10710: add unit tests for OfflineOperation's routines in C4/Circulation.pm This patch test AddOfflineOperation,GetOfflineOperation and DeleteOfflineOperation in C4/Circulation.pm. The tests are wrapped in a transaction. Note: Currently, GetOfflineOperations is not tested because we cannot mock C4::Context->userenv in unit tests To test: prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.01 usr 0.01 sys + 0.33 cusr 0.02 csys = 0.37 CPU Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 --- Comment #5 from Katrin Fischer --- Created attachment 20599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20599&action=edit [PASSED QA] Bug 10710: (follow-up) perltidy new code Also, I prefer the use of parentheses for function calls, even when no arguments are being passed. One missed comma turns is(GetOfflineOperation, ...) into is(GetOfflineOperation ...) Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 --- Comment #3 from Galen Charlton --- Created attachment 20350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20350&action=edit Bug 10710: (follow-up) perltidy new code Also, I prefer the use of parentheses for function calls, even when no arguments are being passed. One missed comma turns is(GetOfflineOperation, ...) into is(GetOfflineOperation ...) Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Galen Charlton changed: What|Removed |Added Attachment #20267|0 |1 is obsolete|| --- Comment #2 from Galen Charlton --- Created attachment 20349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20349&action=edit Bug 10710: add unit tests for OfflineOperation's routines in C4/Circulation.pm This patch test AddOfflineOperation,GetOfflineOperation and DeleteOfflineOperation in C4/Circulation.pm. The tests are wrapped in a transaction. Note: Currently, GetOfflineOperations is not tested because we cannot mock C4::Context->userenv in unit tests To test: prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.01 usr 0.01 sys + 0.33 cusr 0.02 csys = 0.37 CPU Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Galen Charlton changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza changed: What|Removed |Added Blocks||10711 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 --- Comment #1 from kenza --- Created attachment 20267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20267&action=edit Bug 10710 : OfflineOperation's routines in C4/Circulation.pm need unit tests. This patch test AddOfflineOperation,GetOfflineOperation and DeleteOfflineOperation in C4/Circulation.pm. The tests are wrap in a transaction. Note: Currently, GetOfflineOperations is not tested because we cannot mock C4::Context->userenv in unit tests To test: prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.01 usr 0.01 sys + 0.33 cusr 0.02 csys = 0.37 CPU -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza changed: What|Removed |Added Summary|OfflineOperation's routines |UT : OfflineOperation's |in C4/Circulation.t need|routines in |unit tests. |C4/Circulation.t need unit ||tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/