[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Owen Leonard changed: What|Removed |Added Attachment #21518|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 21519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21519&action=edit [SIGNED-OFF] Bug 10836: (follow-up) improve display toggles on the OPAC hold request form This patch improves the the toggles for displaying and hiding the hold options div and the toggles for displaying the table of specific copies to request. It also moves the copy table into the hold options div. To test: [1] Select a single title in the OPAC and click on the place hold button. [2] Click 'Show more options', and select a specific copy to request. [3] Click 'Hide options'. Verify that the hold options, including the copy table, are hidden. [4] Click 'Show more options'. Verify that the specific copy radio button is still selected and that the copy selected in step to is selected. [5] Enable DisplayMultiPlaceHold and select several titles to request. [6] Do steps 2, 3, and 4 on various titles on the request form. Verify that toggling the options link for one title on the form affects the visibility only for that title. Signed-off-by: Galen Charlton Signed-off-by: Owen Leonard While signing off I removed one tag and corrected a float in the CSS. This helps keep the border between individual hold listings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #12 from Galen Charlton --- I've attached a follow-up that addresses my concerns with the display toggling. I want another pair of eyes on the follow-up; either a QA person or Owen can do it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #11 from Galen Charlton --- Created attachment 21518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21518&action=edit Bug 10836: (follow-up) improve display toggles on the OPAC hold request form This patch improves the the toggles for displaying and hiding the hold options div and the toggles for displaying the table of specific copies to request. It also moves the copy table into the hold options div. To test: [1] Select a single title in the OPAC and click on the place hold button. [2] Click 'Show more options', and select a specific copy to request. [3] Click 'Hide options'. Verify that the hold options, including the copy table, are hidden. [4] Click 'Show more options'. Verify that the specific copy radio button is still selected and that the copy selected in step to is selected. [5] Enable DisplayMultiPlaceHold and select several titles to request. [6] Do steps 2, 3, and 4 on various titles on the request form. Verify that toggling the options link for one title on the form affects the visibility only for that title. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What|Removed |Added Attachment #21416|0 |1 is obsolete|| --- Comment #10 from Galen Charlton --- Created attachment 21517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21517&action=edit Bug 10836 - New layout for placing holds in the OPAC This patch changes the layout of the OPAC's place hold screen, eliminating the table in favor of a more flexible, open display. To test, place single and multiple holds under various conditions: - Items which are not available to be place on hold - With OpacHoldNotes on and off - With OPACItemHolds on and off - With OPACAllowHoldDateInFuture on and off - With IndependentBranches on and off - With JavaScript disabled Test setting hold notes, holding specific copies, and setting hold start dates. When setting a hold start date and hold expiration date, the two datepickers should work together to prevent invalid date combinations (dates after today, expiration dates which precede the start date). Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #9 from Galen Charlton --- (In reply to Galen Charlton from comment #8) > I'm not sure about this -- if you expand options, choose to select a > specific copy, then hide the options (say, because you're placing several > holds at once and want to reclaim screen real estate), the request type gets > silently changed to a title hold. Is there a reason to do that? Looks like moving the copy table into the hold options div eliminates the need for special code to hide the copy table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836
--- Comment #8 from Galen Charlton ---
Comment on attachment 21416
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21416
Bug 10836 - New layout for placing holds in the OPAC
Review of attachment 21416:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10836&attachment=21416)
-
::: koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
@@ +184,5 @@
> +var optionsID = this.id.replace("toggle-hold-options-","");
> +var copiesRow = $("#copiesrow_"+optionsID)
> +$("#hold-options-"+optionsID).toggle(0, function() {
> +if( copiesRow.is(':visible') ){
> +$("#reqany_"+optionsID).prop("checked",true);
I'm not sure about this -- if you expand options, choose to select a specific
copy, then hide the options (say, because you're placing several holds at once
and want to reclaim screen real estate), the request type gets silently changed
to a title hold. Is there a reason to do that?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #7 from Galen Charlton --- (In reply to Galen Charlton from comment #6) > One observation during testing: > > - From search results, select multiple records and click the place hold > button > - Select the "a specific copy" option for one of the titles. > - Select the "a specific copy" option for another one -- instead of it > displaying the copies for that title, it instead display an alert whose text > is "Expecting a specific copy selection". > > I wouldn't expect that alert to occur prior to attempting to place the holds. Further testing shows, however, that this was occurring before the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton --- One observation during testing: - From search results, select multiple records and click the place hold button - Select the "a specific copy" option for one of the titles. - Select the "a specific copy" option for another one -- instead of it displaying the copies for that title, it instead display an alert whose text is "Expecting a specific copy selection". I wouldn't expect that alert to occur prior to attempting to place the holds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Jonathan Druart changed: What|Removed |Added Attachment #21412|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 21416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21416&action=edit Bug 10836 - New layout for placing holds in the OPAC This patch changes the layout of the OPAC's place hold screen, eliminating the table in favor of a more flexible, open display. To test, place single and multiple holds under various conditions: - Items which are not available to be place on hold - With OpacHoldNotes on and off - With OPACItemHolds on and off - With OPACAllowHoldDateInFuture on and off - With IndependentBranches on and off - With JavaScript disabled Test setting hold notes, holding specific copies, and setting hold start dates. When setting a hold start date and hold expiration date, the two datepickers should work together to prevent invalid date combinations (dates after today, expiration dates which precede the start date). Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m --- Comment #4 from Jonathan Druart --- Congratulations Owen for your patience! Indeed, this code is really dirty and hard to change. There are some inconsistencies, but not introduced by this patch. It improves the ergonomics of the page and I didn't find any regression. Since the patch does not affect core routines, there is no chance to find a big issue later. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||julian.maur...@biblibre.com --- Comment #3 from Julian Maurice --- All good! :-) Tested with different sysprefs configurations (not tested with IndependentBranches on) Datepickers work as they should. The only little thing I have to say, is when Javascript is disabled, you can pick option "A specific copy" without choosing a copy in the list of items, and then submit. No errors appear and the hold is placed on the next available copy. But I think this should not prevent patch to be pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Julian Maurice changed: What|Removed |Added Attachment #20920|0 |1 is obsolete|| --- Comment #2 from Julian Maurice --- Created attachment 21412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21412&action=edit [SIGNED-OFF] Bug 10836 - New layout for placing holds in the OPAC This patch changes the layout of the OPAC's place hold screen, eliminating the table in favor of a more flexible, open display. To test, place single and multiple holds under various conditions: - Items which are not available to be place on hold - With OpacHoldNotes on and off - With OPACItemHolds on and off - With OPACAllowHoldDateInFuture on and off - With IndependentBranches on and off - With JavaScript disabled Test setting hold notes, holding specific copies, and setting hold start dates. When setting a hold start date and hold expiration date, the two datepickers should work together to prevent invalid date combinations (dates after today, expiration dates which precede the start date). Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10836] New layout for placing holds in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10836 --- Comment #1 from Owen Leonard --- Created attachment 20920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20920&action=edit Bug 10836 - New layout for placing holds in the OPAC This patch changes the layout of the OPAC's place hold screen, eliminating the table in favor of a more flexible, open display. To test, place single and multiple holds under various conditions: - Items which are not available to be place on hold - With OpacHoldNotes on and off - With OPACItemHolds on and off - With OPACAllowHoldDateInFuture on and off - With IndependentBranches on and off - With JavaScript disabled Test setting hold notes, holding specific copies, and setting hold start dates. When setting a hold start date and hold expiration date, the two datepickers should work together to prevent invalid date combinations (dates after today, expiration dates which precede the start date). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
