[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14325 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Pushed by Module Maintainer |Pushed to Master --- Comment #51 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #49 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Rebased after auth.pm tidy in bug 13499 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|Passed QA |Pushed by Module Maintainer --- Comment #50 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Pushed to Module Maintainers Branch - https://github.com/mrenvoize/Koha/tree/authentication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #34357|0 |1 is obsolete|| --- Comment #48 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 35544 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35544action=edit Bug 10900: 2 occurrences more Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #34355|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 35542 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35542action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep ::set_userenv `find .` grep \-set_userenv `find .` The first grep demonstrated that the smaller change is from :: to - as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use -) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Rebase required because of shibboleth change in C4/Context.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #34356|0 |1 is obsolete|| --- Comment #47 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 35543 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35543action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN - 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #31719|0 |1 is obsolete|| --- Comment #42 from M. Tompsett mtomp...@hotmail.com --- Created attachment 34355 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34355action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep ::set_userenv `find .` grep \-set_userenv `find .` The first grep demonstrated that the smaller change is from :: to - as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use -) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Rebase required because of shibboleth change in C4/Context.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #31721|0 |1 is obsolete|| --- Comment #44 from M. Tompsett mtomp...@hotmail.com --- Created attachment 34357 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34357action=edit Bug 10900: 2 occurrences more Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #31720|0 |1 is obsolete|| --- Comment #43 from M. Tompsett mtomp...@hotmail.com --- Created attachment 34356 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34356action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN - 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #45 from M. Tompsett mtomp...@hotmail.com --- Because of the new shibboleth parameter to set_userenv in C4::Context, a rebase was required. There should be no other visible changes between the last two versions of Bug 10900 - Incorrect calling conventions accessing C4::Context. Leaving as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31720 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31720action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN - 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com --- I will try to add a rule in the qa tools when pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31721 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31721action=edit Bug 10900: 2 occurrences more Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #36 from Jonathan Druart jonathan.dru...@biblibre.com --- On QAing the 3 bug reports: The Circulation UT file is broken: prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 2/51 Undefined subroutine C4::Circulation::GetItem called at C4/Circulation.pm line 1204. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #37 from M. Tompsett mtomp...@hotmail.com --- (In reply to Jonathan Druart from comment #36) On QAing the 3 bug reports: The Circulation UT file is broken: prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 2/51 Undefined subroutine C4::Circulation::GetItem called at C4/Circulation.pm line 1204. Hmmm... this is not because of this bug report, which can be QA'd by itself. comment #10 comment #32 prove -v t/db_dependent/Members.t I will try to figure out the mess on the other two bugs. Setting this to Signed Off, since this bug can be QA'd seperately. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #35 from M. Tompsett mtomp...@hotmail.com --- See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589#c34 for how this all relates piecewise to the other bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks|10895 |10589 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks|10589 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||10589 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||10895 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31298 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31298action=edit Bug 10900: 2 occurrences more Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #30244|0 |1 is obsolete|| --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31297 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31297action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN - 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact|jonathan.dru...@biblibre.co | |m | --- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com --- Sorry, I forgot this one. Need QA! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #28183|0 |1 is obsolete|| --- Comment #31 from M. Tompsett mtomp...@hotmail.com --- Created attachment 30244 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30244action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN - 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. REBASED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #27729|0 |1 is obsolete|| --- Comment #30 from M. Tompsett mtomp...@hotmail.com --- Created attachment 30243 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30243action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep ::set_userenv `find .` grep \-set_userenv `find .` The first grep demonstrated that the smaller change is from :: to - as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use -) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. REBASED Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #29 from M. Tompsett mtomp...@hotmail.com --- Even if 10589 and 10895 don't make it into Koha, I think this refactor/clean up is still useful to do. There are some works by mistake changes in here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #27 from M. Tompsett mtomp...@hotmail.com --- Actually, it is tied to bug 10589 only in that it is required for it to work. This actually changes no functionality whatsoever. It tidies calls to functions in C4::Context, making them called the same way. That is, use - instead of :: in C4::Context function calls, particularly this piece which corrects set_userenv. It also corrects a few bugs which are working by accident, because the parameter list is wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #28 from M. Tompsett mtomp...@hotmail.com --- Created attachment 28183 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28183action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN - 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords|rel_3_16_candidate | Status|Passed QA |In Discussion CC||gmcha...@gmail.com --- Comment #26 from Galen Charlton gmcha...@gmail.com --- Punting to next release as it's tied to bug 10589. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords||rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22937|0 |1 is obsolete|| --- Comment #25 from M. Tompsett mtomp...@hotmail.com --- Created attachment 27729 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27729action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep ::set_userenv `find .` grep \-set_userenv `find .` The first grep demonstrated that the smaller change is from :: to - as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use -) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com NOTE: Rebased because of Bug 11077. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: All looks good, no regression found (I did not launch all UT). The persona login works. As Srdjan already said, I am not sure the set_userenv routine should be used as a method. But no importance when looking at the C4::Context module... I would have been nice to make the most of the opportunity to replace the parameter list with a hashref. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22585|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 22937 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22937action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep ::set_userenv `find .` grep \-set_userenv `find .` The first grep demonstrated that the smaller change is from :: to - as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use -) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #24 from M. Tompsett mtomp...@hotmail.com --- (In reply to Jonathan Druart from comment #22) I would have been nice to make the most of the opportunity to replace the parameter list with a hashref. I think the fixing the parameters to hashrefs would be better done in bug 7176. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #22038|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 22585 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22585action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep ::set_userenv `find .` grep \-set_userenv `find .` The first grep demonstrated that the smaller change is from :: to - as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use -) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #18 from M. Tompsett mtomp...@hotmail.com --- The test plan is in comment #10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||k...@bywatersolutions.com --- Comment #19 from Kyle M Hall k...@bywatersolutions.com --- Looks like this patch is causing Circulation_barcodedecode.t to fails some tests. All the unit tests pass on master. perl t/Circulation_barcodedecode.t 1..26 ok 1 - use C4::Circulation; ok 2 -EAN13: '892685001928' = '0892685001928' ok 3 -EAN13: '695152' = '000695152' ok 4 - T-prefix: 'T0031472' = 'T0031472' ok 5 - T-prefix:'T32' = 'T002' ok 6 - cuecat: '26002315' = '26002315' ok 7 - cuecat: '.C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7.' = '046675000808' ok 8 - cuecat: '.C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7. # ' = '046675000808' ok 9 - cuecat: 'q.C3nZC3nZC3nWDNzYDxf2CNnY.fHmc.C3DWC3nZCNjXD3nW.' = '043000112403' ok 10 - cuecat: '.C3nZC3nZC3nWCxjWE3D1C3nX.cGf2.ENr7C3v7D3T3ENj3C3zYDNnZ.' = '978068484914051500' not ok 11 -libsuite8:'b000126' = 'IMS-b-126' # Failed test ' libsuite8:'b000126' = 'IMS-b-126'' # at t/Circulation_barcodedecode.t line 38. # Bad output: 'kale-b-126' not ok 12 -libsuite8:'b12' = 'IMS-b-12' # Failed test ' libsuite8:'b12' = 'IMS-b-12'' # at t/Circulation_barcodedecode.t line 38. # Bad output: 'kale-b-12' not ok 13 -libsuite8: 'B0126' = 'IMS-B-126' # Failed test ' libsuite8: 'B0126' = 'IMS-B-126'' # at t/Circulation_barcodedecode.t line 38. # Bad output: 'kale-B-126' not ok 14 -libsuite8: 'IMS-B-126' = 'IMS-B-126' # Failed test ' libsuite8: 'IMS-B-126' = 'IMS-B-126'' # at t/Circulation_barcodedecode.t line 38. # Bad output: 'kale-IMS-B--126' not ok 15 -libsuite8: 'ims-b-126' = 'ims-b-126' # Failed test ' libsuite8: 'ims-b-126' = 'ims-b-126'' # at t/Circulation_barcodedecode.t line 38. # Bad output: 'kale-ims-b--126' not ok 16 -libsuite8: 'CD024' = 'IMS-CD-24' # Failed test ' libsuite8: 'CD024' = 'IMS-CD-24'' # at t/Circulation_barcodedecode.t line 38. # Bad output: 'kale-CD-24' not ok 17 -libsuite8: '00123' = 'IMS-b-123' # Failed test ' libsuite8: '00123' = 'IMS-b-123'' # at t/Circulation_barcodedecode.t line 38. # Bad output: 'kale-b-123' not ok 18 -libsuite8: '11998' = 'IMS-b-11998' # Failed test ' libsuite8: '11998' = 'IMS-b-11998'' # at t/Circulation_barcodedecode.t line 38. # Bad output: 'kale-b-11998' ok 19 -other: '26002315' = '26002315' ok 20 -other: 'T0031472' = 'T0031472' ok 21 -other:'T32' = 'T32' ok 22 -other:'Alphanum123' = 'Alphanum123' ok 23 -other: 'Alpha Num 345' = 'Alpha Num 345' ok 24 - whitespace: ' 26002315' = '26002315' ok 25 - whitespace: '26002315 ' = '26002315' ok 26 - whitespace:' # 26002315 # ' = '26002315' # Looks like you failed 8 tests of 26. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #20 from M. Tompsett mtomp...@hotmail.com ---
After reading your post, Kyle, I did a fresh git install on a fresh OS clone. I
could not replicate your failure.
mtompset@ubuntu:~/kohaclone$ git checkout -b bug_10900 origin/master
Branch bug_10900 set up to track remote branch master from origin.
Switched to a new branch 'bug_10900'
mtompset@ubuntu:~/kohaclone$ git diff origin/master
mtompset@ubuntu:~/kohaclone$ git bz apply 10900
Bug 10900 - Incorrect calling conventions accessing C4::Context
Bug 10900 - Incorrect calling conventions accessing C4::Context
Apply? [yn] y
Applying: Bug 10900 - Incorrect calling conventions accessing C4::Context
mtompset@ubuntu:~/kohaclone$ prove -v t/Circulation_barcodedecode.t
t/Circulation_barcodedecode.t ..
1..26
ok 1 - use C4::Circulation;
ok 2 -EAN13: '892685001928' = '0892685001928'
ok 3 -EAN13: '695152' = '000695152'
ok 4 - T-prefix: 'T0031472' = 'T0031472'
ok 5 - T-prefix:'T32' = 'T002'
ok 6 - cuecat: '26002315' = '26002315'
ok 7 - cuecat: '.C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7.' =
'046675000808'
ok 8 - cuecat: '.C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7.
# ' = '046675000808'
ok 9 - cuecat: 'q.C3nZC3nZC3nWDNzYDxf2CNnY.fHmc.C3DWC3nZCNjXD3nW.' =
'043000112403'
ok 10 - cuecat:
'.C3nZC3nZC3nWCxjWE3D1C3nX.cGf2.ENr7C3v7D3T3ENj3C3zYDNnZ.' =
'978068484914051500'
ok 11 -libsuite8:'b000126' = 'IMS-b-126'
ok 12 -libsuite8:'b12' = 'IMS-b-12'
ok 13 -libsuite8: 'B0126' = 'IMS-B-126'
ok 14 -libsuite8: 'IMS-B-126' = 'IMS-B-126'
ok 15 -libsuite8: 'ims-b-126' = 'ims-b-126'
ok 16 -libsuite8: 'CD024' = 'IMS-CD-24'
ok 17 -libsuite8: '00123' = 'IMS-b-123'
ok 18 -libsuite8: '11998' = 'IMS-b-11998'
ok 19 -other: '26002315' = '26002315'
ok 20 -other: 'T0031472' = 'T0031472'
ok 21 -other:'T32' = 'T32'
ok 22 -other:'Alphanum123' = 'Alphanum123'
ok 23 -other: 'Alpha Num 345' = 'Alpha Num 345'
ok 24 - whitespace: ' 26002315' = '26002315'
ok 25 - whitespace: '26002315 ' = '26002315'
ok 26 - whitespace:'
# 26002315
# ' = '26002315'
ok
All tests successful.
Files=1, Tests=26, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.30 cusr 0.02
csys = 0.34 CPU)
Result: PASS
So, I looked at your bad output line:
# Bad output: 'kale-b-126'
'kale' is the last name in the set_userenv call.
The line that changed in the test file is:
C4::Context-set_userenv(1,'kmkale' , 1, 'km', 'kale' , 'IMS', 'IMS Branch
DEscription', 0, 'kmk...@anantcorp.com');
This would be affected if the set_userenv function in C4::Context is missing
shift @_; or the call is :: in the test file.
From C4::Context:
shift @_;
my ($usernum, $userid, $usercnum, $userfirstname, $usersurname,
$userbranch, $branchname, $userflags, $emailaddress, $branchprinter, $persona)=
@_;
The - passes an object, which is shifted off, and
$usernum=1,$userid='kmkale',$usercnum=1,$userfirstname='km',$usersurname='kale',$userbranch='IMS'
The barcodedecode function uses the userbranch. So, if there is a missing shift
@_ and the Circulationbarcode.t file has -set_userenv(...) as above, then that
$userbranch would be 'kale', which matches your failed output. The 'kale-'
portion is based on the branchcode.
From C4/Circulation.pm
sub barcodedecode {
my ($barcode, $filter) = @_;
my $branch = C4::Branch::mybranch();
...
} elsif ($filter eq 'libsuite8') {
unless($barcode =~ m/^($branch)-/i){#if barcode starts with
branch code its in Koha style. Skip it.
if($barcode =~ m/^(\d)/i){ #Some barcodes even
start with 0's numbers and are assumed to have b as the item type in the
libsuite8 software
$barcode =~ s/^[0]*(\d+)$/$branch-b-$1/i;
}else{
$barcode =~ s/^(\D+)[0]*(\d+)$/$branch-$1-$2/i;
}
}
From C4/Branch.pm
# always returns a string for OK comparison via eq or ne
sub mybranch {
C4::Context-userenv or return '';
return C4::Context-userenv-{branch} || '';
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #15 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22037 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22037action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep ::set_userenv `find .` grep \-set_userenv `find .` The first grep demonstrated that the smaller change is from :: to - as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use -) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the sent_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #21290|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #21291|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #21292|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #16 from M. Tompsett mtomp...@hotmail.com --- Had to rebase due to the changed hashing algorithm of the passwords patch which has made it into master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22037|0 |1 is obsolete|| --- Comment #17 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22038 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22038action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep ::set_userenv `find .` grep \-set_userenv `find .` The first grep demonstrated that the smaller change is from :: to - as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use -) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #12 from Srdjan Jankovic srd...@catalyst.net.nz --- I'm not sure this is correct. C4::Context is not an object, hence has no methods. I believe :: is more appropriate under the circumstances. Although we may agree to call C4::Context subs using -, but that would be just a waste of the first argument. Context *should* be an object, I agree, but unfortunately it is not. Is this being addressed in Koha:: namespace? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #13 from M. Tompsett mtomp...@hotmail.com --- I don't know if it is being addressed in the Koha:: namespace. However, if someone is working on splitting C4::Context, this means that one piece of the split up is closer to being the object it should be. See bug 7176. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #14 from Srdjan Jankovic srd...@catalyst.net.nz --- Ok, then I'll rephrase: If Context is moving to Koha, then this is not necessary. If it is not, well then I can see the point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 I'm just a bot git...@bugs.koha-community.org changed: What|Removed |Added CC||git...@bugs.koha-community. ||org When did the bot||2013-09-24 last check this|| --- Comment #11 from I'm just a bot git...@bugs.koha-community.org --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment #10 from M. Tompsett mtomp...@hotmail.com ---
Okay, I believe there are 19 change points in these three patches. To trigger
these change points (ie. Here is a test plan):
koha staff client - login userid - 2,6,7,8,14
koha staff client - logout - 1
koha staff client - login cardnumber - 9,10,11
prove -v t/Circulation_barcodedecode.t - 18
prove -v t/db_dependent/Circulation.t - 19
http://{staff client
url}/cgi-bin/koha/svc/bib/{biblionumber}?userid={userid}password={password}
- 4
koha staff client - login userid AND then
http://{staff client url}/cgi-bin/koha/svc/bib/{biblionumber}
- 3
tools - tags - type something in the Check lists text box and click 'test'.
- 5
koha staff client - login system user - 12
perldoc C4::Context
/set_userenv - 13
koha staff client - upgrade database - 16,17,15
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #5 from M. Tompsett mtomp...@hotmail.com --- A little more to come... Another set of side related problems. *sigh* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #21152|0 |1 is obsolete|| Attachment #21263|0 |1 is obsolete|| --- Comment #6 from M. Tompsett mtomp...@hotmail.com --- Created attachment 21290 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21290action=edit Correct calling convention for set_userenv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #7 from M. Tompsett mtomp...@hotmail.com --- Created attachment 21291 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21291action=edit Fix t/Circulation_barcodedecode.t set_userenv calls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #8 from M. Tompsett mtomp...@hotmail.com --- Created attachment 21292 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21292action=edit Fix other set_userenv calls with bad parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900
--- Comment #9 from M. Tompsett mtomp...@hotmail.com ---
How to trigger all the set_userenv's in C4/Auth.pm:
log in using userid (triggers 1, 2, 6)
log in using cardnumber (triggers 7 and others)
library-intra.mydnsname.org/cgi-bin/koha/svc/bib/{bibnumber}?userid={userid}password={password}
(first time triggers 4)
library-intra.mydnsname.org/cgi-bin/koha/svc/bib/{bibnumber} (once logged in
triggering 4, this triggers 3)
tools - tags - type something in the Check lists text box and click 'test'.
(triggers 5)
To trigger the set_userenv's in installer/InstallAuth.pm, just run an upgrade
of a database from a previous version to the current master, and redirect to
the log in screen.
prove -v t/Circulation_barcodedecode.t
I have yet to determine how to trigger the patched areas in the third patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #21152|0 |1 is obsolete|| --- Comment #4 from M. Tompsett mtomp...@hotmail.com --- Created attachment 21263 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21263action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context As the results of trying to roll a distribution, t/Circulation_bardcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize that was outdated as well. It has been revised to match the current version of the function. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #21152|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #1 from M. Tompsett mtomp...@hotmail.com --- Created attachment 21152 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21152action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep C4::Context::set_userenv `find .` grep C4::Context-set_userenv `find .` It was recommended that it should be -, and so a shift was added to the routine to properly ignore the object that is passed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- The validity of the change was checked with: $ prove -v t/db_dependent/Circulation.t If it works for that case, it should work for all cases. I was able to log in, and seeing as that set_userenv is in Auth, I figured it got triggered there too. I had a DB that was two versions behind, and I triggered an upgrade on the staff client successfully too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||10895 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900
--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
How to trigger all the set_userenv's in C4/Auth.pm:
log in using userid (triggers 1, 2, 6)
log in using cardnumber (triggers 7 and others)
library-intra.mydnsname.org/cgi-bin/koha/svc/bib/{bibnumber}?userid={userid}password={password}
(first time triggers 4)
library-intra.mydnsname.org/cgi-bin/koha/svc/bib/{bibnumber} (once logged in
triggering 4, this triggers 3)
tools - tags - type something in the Check lists text box and click 'test'.
(triggers 5)
To trigger the set_userenv's in installer/InstallAuth.pm, just run an upgrade
of a database from a previous version to the current master, and redirect to
the log in screen.
And having figured all this out... It worked.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
