[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Katrin Fischer changed: What|Removed |Added Attachment #21456|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 21827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21827&action=edit [PASSED QA] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority A librarian cannot modify a hold's pickup location unless he or she has the permission modify_holds_priority. This appears to be a bug and not by design. The reason the update fails is due to the priority not being passed to ModReserve. The priority is not displayed when a librarian does not have the modify_holds_priority permission. Test Plan: 1) Remove the modify_holds_priority from your logged in user * User cannot be a superlibrarian 2) Attempt to change the pickup location for a hold 3) Note the change fails 4) Apply this patch 5) Repeat step 2 6) Note the change succeeds Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Template change only. Passes all tests and QA script. Tested: - Confirmed that changing the pickup location is not possible in master without the modify_holds_priority permission - Confirmed that the patch fixes the problem - pickup location can now be changed with and without the permission - Pickup location can still not be changed, when IndependentBranches is activated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Owen Leonard changed: What|Removed |Added Attachment #21255|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 21456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21456&action=edit [SIGNED-OFF] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority A librarian cannot modify a hold's pickup location unless he or she has the permission modify_holds_priority. This appears to be a bug and not by design. The reason the update fails is due to the priority not being passed to ModReserve. The priority is not displayed when a librarian does not have the modify_holds_priority permission. Test Plan: 1) Remove the modify_holds_priority from your logged in user * User cannot be a superlibrarian 2) Attempt to change the pickup location for a hold 3) Note the change fails 4) Apply this patch 5) Repeat step 2 6) Note the change succeeds Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 I'm just a bot changed: What|Removed |Added CC||git...@bugs.koha-community. ||org When did the bot||2013-09-24 last check this|| --- Comment #3 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #2 from Christopher Brannon --- I've tested this patch on our server, and it works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Kyle M Hall changed: What|Removed |Added Summary|Librarian cannot update |Librarian cannot update |hold pickup location with |hold pickup location |modify_holds_priority |without ||modify_holds_priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 --- Comment #1 from Kyle M Hall --- Created attachment 21255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21255&action=edit Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority A librarian cannot modify a hold's pickup location unless he or she has the permission modify_holds_priority. This appears to be a bug and not by design. The reason the update fails is due to the priority not being passed to ModReserve. The priority is not displayed when a librarian does not have the modify_holds_priority permission. Test Plan: 1) Remove the modify_holds_priority from your logged in user * User cannot be a superlibrarian 2) Attempt to change the pickup location for a hold 3) Note the change fails 4) Apply this patch 5) Repeat step 2 6) Note the change succeeds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10917] Librarian cannot update hold pickup location without modify_holds_priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
