[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 39186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39186&action=edit Bug 11006: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Jonathan! tatus: Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Kyle M Hall changed: What|Removed |Added Attachment #38393|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 38402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38402&action=edit [PASSED QA] Bug 11006: Drop column aqorders.totalamount This column was not used in the Koha codebase, it can be removed. Test plan: Execute the updatedatabase.pl script and confirm that the column has been dropped. QA step: 1/ git grep totalamount 2/ prove t/db_dependent/Acquisition.t Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #4 from Marc Véron --- Created attachment 38393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38393&action=edit [Signed-off] Bug 11006: Drop column aqorders.totalamount This column was not used in the Koha codebase, it can be removed. Test plan: Execute the updatedatabase.pl script and confirm that the column has been dropped. QA step: 1/ git grep totalamount 2/ prove t/db_dependent/Acquisition.t Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Marc Véron changed: What|Removed |Added Attachment #38320|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #3 from Jonathan Druart --- (In reply to Marc Véron from comment #2) > # git grep totalamount > Koha/Schema/Result/Aqorder.pm:=head2 totalamount > Koha/Schema/Result/Aqorder.pm: "totalamount", > > Should that still appear? Yes, I don't update the schema when not needed to test. The RM uploads it when needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #2 from Marc Véron --- # git grep totalamount Koha/Schema/Result/Aqorder.pm:=head2 totalamount Koha/Schema/Result/Aqorder.pm: "totalamount", Should that still appear? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #1 from Jonathan Druart --- Created attachment 38320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38320&action=edit Bug 11006: Drop column aqorders.totalamount This column was not used in the Koha codebase, it can be removed. Test plan: Execute the updatedatabase.pl script and confirm that the column has been dropped. QA step: 1/ git grep totalamount 2/ prove t/db_dependent/Acquisition.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
