[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22087|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 22313 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22313action=edit Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verify that relevant authority records are linked to from the bib. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton gmcha...@gmail.com --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 --- Comment #6 from Galen Charlton gmcha...@gmail.com --- Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 --- Comment #2 from Galen Charlton gmcha...@gmail.com --- Created attachment 22086 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22086action=edit Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verfiy that relevant authority records are linked to. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #21944|0 |1 is obsolete|| Attachment #22086|0 |1 is obsolete|| --- Comment #3 from Galen Charlton gmcha...@gmail.com --- Created attachment 22087 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22087action=edit Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verify that relevant authority records are linked to from the bib. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 21944 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21944action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
