[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Kyle M Hall changed: What|Removed |Added Attachment #24521|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 24526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24526&action=edit Bug 11056 : Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no more assigned to $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : Check basketgroup are shown as before the patch, and can be closed and reopen. Check you can add or remove a basket from a basketgroup, and change informations about it (like delivery place) Check you can create a basketgroup when you close a basket. Signed-off-by: Jonathan Druart The following commands return nothing: - grep validate acqui/basketgroup.tt - grep -R basketgroup.pl -C 2 | grep validate - git grep parseinputbaskets - git grep parseinputbasketgroups - git grep basketgroup.pl | grep validate Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 --- Comment #6 from mathieu saby --- Oh, I did not even know "git grep" command! Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Jonathan Druart changed: What|Removed |Added Attachment #23741|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 24521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24521&action=edit Bug 11056 : Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no more assigned to $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : Check basketgroup are shown as before the patch, and can be closed and reopen. Check you can add or remove a basket from a basketgroup, and change informations about it (like delivery place) Check you can create a basketgroup when you close a basket. Signed-off-by: Jonathan Druart The following commands return nothing: - grep validate acqui/basketgroup.tt - grep -R basketgroup.pl -C 2 | grep validate - git grep parseinputbaskets - git grep parseinputbasketgroups - git grep basketgroup.pl | grep validate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 mathieu saby changed: What|Removed |Added Attachment #23642|0 |1 is obsolete|| --- Comment #4 from mathieu saby --- Created attachment 23741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23741&action=edit [PATCH] Bug 11056 : Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no more assigned to $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : Check basketgroup are shown as before the patch, and can be closed and reopen. Check you can add or remove a basket from a basketgroup, and change informations about it (like delivery place) Check you can create a basketgroup when you close a basket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 --- Comment #3 from mathieu saby --- Functions parseinputbaskets and parseinputbasketgroups are only called by this dead code. So they could be removed too. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 mathieu saby changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 --- Comment #1 from mathieu saby --- Created attachment 23642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23642&action=edit [PATCH] Bug 11056 : Delete dead code in basketgroup.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 --- Comment #2 from mathieu saby --- In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no more assigned to $op variable since 2009. This patch suppressed dead code. No functional changes expected Regression test : check basketgroup are shown as before the patch, and can be closed and reopen. Check you can create a basketgroup when you close a basket. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 mathieu saby changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 mathieu saby changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 mathieu saby changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 mathieu saby changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/