[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Katrin Fischer changed: What|Removed |Added Summary|publisher code and |Fix display of publication |publication year not|year/copyrightdate and |fetched in acq orders |publishercode on various ||pages in acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #31 from Katrin Fischer --- Created attachment 62935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62935&action=edit [SIGNED OFF] Bug 11122 - publisher code and publication year not fetched in acq orders In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt. Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails. The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear. In uncertainprice.pl those datas are fetch using GetBiblioData. It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume. This patch also unifies the way biblio datas are displayed : [title] by [author] – [isbn] Publisher: [publishercode], [publicationyear] Test plan : - Choose a biblio record containing a data in : biblio.title, biblio.author, biblioitems.isbn, biblioitems.publishercode, biblioitems.publicationyear, biblio.seriestitle, biblioitems.volume. - Create an order using this biblio. - Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl => You see publisher code and publication year - Look at this order in page : invoice.pl => You see publisher code, publication year, series title and volume Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #32 from Katrin Fischer --- Created attachment 62936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62936&action=edit [SIGNED OFF] Bug 11122: Address MARC21 vs. UNIMARC issue In comment #6 and comment #17, Katrin pointed out the discrepancy between UNIMARC (using publisheryear) vs. Other MARC installations (using copyrightdate). This was dealt with in invoice.tt already. This patch does similar logic for the other 3 template files. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #33 from Katrin Fischer --- Created attachment 62937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62937&action=edit Bug 11122: Follow up - Fix some display issues and typos This patch fixes the display of copyrightdate for MARC21 installations. As MARC21 already requires you to add punctuation in cataloguing, there is usually no need for punctutation in the templates. Also fixes a template variable name typo and the basket summary page. To test (all 3 patches): - Add several order lines to an order, one should be uncertain - Verify that the publisher and publication year are displayed - Check the uncertain price page - Verify that the publisher code and publication year are displayed - Fix uncertain price and close your order - Basket summary: Verify... (you know what) - Cancel one of your orders - Verify... for cancelled orders - Receive shipment - Verify... for unreceived orders - Receive order - Verify ... for received orders - Finish receiving - Verify ... on the invoice summary page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Katrin Fischer changed: What|Removed |Added Attachment #44710|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Katrin Fischer changed: What|Removed |Added Attachment #44711|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #34 from Katrin Fischer --- Leaving this as 'needs signoff' because of my follow-up patch. I've written up a test plan on the last patch. I am unclear about the code for transferring orders. I have tested from the basket summary and from the order receive pages, but there is never any order information displayed. Eyeballing the code it looks ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #37 from Josef Moravec --- Created attachment 63407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63407&action=edit [SIGNED-OFF] Bug 11122: Follow up - Fix some display issues and typos This patch fixes the display of copyrightdate for MARC21 installations. As MARC21 already requires you to add punctuation in cataloguing, there is usually no need for punctutation in the templates. Also fixes a template variable name typo and the basket summary page. To test (all 3 patches): - Add several order lines to an order, one should be uncertain - Verify that the publisher and publication year are displayed - Check the uncertain price page - Verify that the publisher code and publication year are displayed - Fix uncertain price and close your order - Basket summary: Verify... (you know what) - Cancel one of your orders - Verify... for cancelled orders - Receive shipment - Verify... for unreceived orders - Receive order - Verify ... for received orders - Finish receiving - Verify ... on the invoice summary page Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Josef Moravec changed: What|Removed |Added Attachment #62935|0 |1 is obsolete|| Attachment #62936|0 |1 is obsolete|| Attachment #62937|0 |1 is obsolete|| --- Comment #35 from Josef Moravec --- Created attachment 63405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63405&action=edit [SIGNED-OFF] Bug 11122 - publisher code and publication year not fetched in acq orders In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt. Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails. The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear. In uncertainprice.pl those datas are fetch using GetBiblioData. It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume. This patch also unifies the way biblio datas are displayed : [title] by [author] – [isbn] Publisher: [publishercode], [publicationyear] Test plan : - Choose a biblio record containing a data in : biblio.title, biblio.author, biblioitems.isbn, biblioitems.publishercode, biblioitems.publicationyear, biblio.seriestitle, biblioitems.volume. - Create an order using this biblio. - Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl => You see publisher code and publication year - Look at this order in page : invoice.pl => You see publisher code, publication year, series title and volume Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #36 from Josef Moravec --- Created attachment 63406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63406&action=edit [SIGNED-OFF] Bug 11122: Address MARC21 vs. UNIMARC issue In comment #6 and comment #17, Katrin pointed out the discrepancy between UNIMARC (using publisheryear) vs. Other MARC installations (using copyrightdate). This was dealt with in invoice.tt already. This patch does similar logic for the other 3 template files. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Jonathan Druart changed: What|Removed |Added Attachment #63405|0 |1 is obsolete|| Attachment #63406|0 |1 is obsolete|| Attachment #63407|0 |1 is obsolete|| --- Comment #38 from Jonathan Druart --- Created attachment 63538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63538&action=edit Bug 11122 - publisher code and publication year not fetched in acq orders In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt. Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails. The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear. In uncertainprice.pl those datas are fetch using GetBiblioData. It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume. This patch also unifies the way biblio datas are displayed : [title] by [author] – [isbn] Publisher: [publishercode], [publicationyear] Test plan : - Choose a biblio record containing a data in : biblio.title, biblio.author, biblioitems.isbn, biblioitems.publishercode, biblioitems.publicationyear, biblio.seriestitle, biblioitems.volume. - Create an order using this biblio. - Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl => You see publisher code and publication year - Look at this order in page : invoice.pl => You see publisher code, publication year, series title and volume Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #39 from Jonathan Druart --- Created attachment 63539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63539&action=edit Bug 11122: Address MARC21 vs. UNIMARC issue In comment #6 and comment #17, Katrin pointed out the discrepancy between UNIMARC (using publisheryear) vs. Other MARC installations (using copyrightdate). This was dealt with in invoice.tt already. This patch does similar logic for the other 3 template files. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #40 from Jonathan Druart --- Created attachment 63540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63540&action=edit Bug 11122: Follow up - Fix some display issues and typos This patch fixes the display of copyrightdate for MARC21 installations. As MARC21 already requires you to add punctuation in cataloguing, there is usually no need for punctutation in the templates. Also fixes a template variable name typo and the basket summary page. To test (all 3 patches): - Add several order lines to an order, one should be uncertain - Verify that the publisher and publication year are displayed - Check the uncertain price page - Verify that the publisher code and publication year are displayed - Fix uncertain price and close your order - Basket summary: Verify... (you know what) - Cancel one of your orders - Verify... for cancelled orders - Receive shipment - Verify... for unreceived orders - Receive order - Verify ... for received orders - Finish receiving - Verify ... on the invoice summary page Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #41 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #42 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #43 from Katrin Fischer --- Glad to finally have this! These patches have been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
