[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Fridolin SOMERS changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m Depends on||11224 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 --- Comment #8 from Jonathan Druart --- (In reply to Galen Charlton from comment #6) > Failing on account of the lack of documentation and unit test coverage for > the new parameter to SearchOrders(). POD and UT added. > The logic here is unnecessarily convoluted. Yes, true! Fixed. Switch back to needs SO if you think it is needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 --- Comment #7 from Jonathan Druart --- Created attachment 26049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26049&action=edit Bug 11170: Fix an unnecessarily convoluted logic This patch also adds POD and UT. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Galen Charlton changed: What|Removed |Added Status|Passed QA |Failed QA CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170
--- Comment #6 from Galen Charlton ---
Comment on attachment 23728
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23728
Bug 11170: The pending order list should only display orders to receive
Review of attachment 23728:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11170&attachment=23728)
-
Failing on account of the lack of documentation and unit test coverage for the
new parameter to SearchOrders().
::: C4/Acquisition.pm
@@ +1665,4 @@
> my $basketgroupname = $params->{basketgroupname};
> my $owner = $params->{owner};
> my $pending = $params->{pending};
> +my $ordered = $params->{ordered};
There is neither POD nor unit test coverage of this new option.
@@ +1695,5 @@
> +$query .= q{ AND (quantity > quantityreceived OR quantityreceived is
> NULL)};
> +}
> +if ( $ordered ) {
> +$query .= q{ AND (quantity > quantityreceived OR quantityreceived is
> NULL)}
> +unless $pending;
The logic here is unnecessarily convoluted. Please restructure so that only
one Boolean test controls whether the "AND (quantity > quantityreceived OR
quantityreceived is NULL)" clause gets added.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Kyle M Hall changed: What|Removed |Added Attachment #23572|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 23729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23729&action=edit Bug 11170: Follow-up for typo occured in parcels.tt Found this typo while testing bug 11170. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Kyle M Hall changed: What|Removed |Added Attachment #23571|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 23728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23728&action=edit Bug 11170: The pending order list should only display orders to receive The order status ordered is set when the basket is closed. The parcel page should only display status "ordered" and "partial". Test plan: - create a basket. - create an order. - verify the order is not listed on the parcel page (i.e. you cannot receive it). - close the basket. - verify the order is listed on the parcel page. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11398 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 M. de Rooy changed: What|Removed |Added Attachment #22597|0 |1 is obsolete|| --- Comment #2 from M. de Rooy --- Created attachment 23571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23571&action=edit Bug 11170: The pending order list should only display orders to receive The order status ordered is set when the basket is closed. The parcel page should only display status "ordered" and "partial". Test plan: - create a basket. - create an order. - verify the order is not listed on the parcel page (i.e. you cannot receive it). - close the basket. - verify the order is listed on the parcel page. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 --- Comment #3 from M. de Rooy --- Created attachment 23572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23572&action=edit Bug 11170: Follow-up for typo occured in parcels.tt Found this typo while testing bug 11170. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Jonathan Druart changed: What|Removed |Added Depends on||5336 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 --- Comment #1 from Jonathan Druart --- Created attachment 22597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22597&action=edit Bug 11170: The pending order list should only display orders to receive The order status ordered is set when the basket is closed. The parcel page should only display status "ordered" and "partial". Test plan: - create a basket. - create an order. - verify the order is not listed on the parcel page (i.e. you cannot receive it). - close the basket. - verify the order is listed on the parcel page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
