[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Caroline Cyr La Rose changed: What|Removed |Added Blocks||31608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31608 [Bug 31608] ShowComponentRecords doesn't display components if UseControlNumber is turned on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Caroline Cyr La Rose changed: What|Removed |Added Blocks||31543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543 [Bug 31543] MaxComponentRecords link is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Katrin Fischer changed: What|Removed |Added Blocks||30327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327 [Bug 30327] Sort component parts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #524 from David Cook --- (In reply to David Cook from comment #522) > > Regarding Zebra, we actually have the tools to easily catch this in our unit > tests: > Except of course we're feeding the output of "get_components_query" into $searcher->simple_search_compat or into search.pl/opac-search.pl "q" parameter which both transform the query differently (both for Zebra and for Elasticsearch so we get at least 4x more things to check). Well... if it were easy it would already be done 藍. Someday... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 David Cook changed: What|Removed |Added Blocks||30865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865 [Bug 30865] Koha::Biblio->get_components_query should double quote Host-item search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29418 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #523 from David Cook --- (In reply to David Cook from comment #522) > (In reply to Martin Renvoize from comment #520) > > Nice one.. faith in community restored.. sorry for being grumpy > > Now I'm feeling grumpy reading through these patches again . > Actually now that I think about it... I feel like I've already grumped about this code recently... Ah yes: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418#c16 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
--- Comment #522 from David Cook ---
(In reply to Martin Renvoize from comment #520)
> Nice one.. faith in community restored.. sorry for being grumpy
Now I'm feeling grumpy reading through these patches again .
(In reply to Marcel de Rooy from comment #499)
> Created attachment 126883 [details] [review]
> Bug 11175: (QA follow-up) Move get_component_part_query
This patch removed the double-quotes from the search terms which causes this to
break when using Zebra if you're using a title like "MyTitle: MySubtitle" since
the following query is a syntax error:
Host-item=(MyTitle= MySubtitle)
It should be:
Host-item=("MyTitle= MySubtitle")
According to
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#query-string-syntax,
it looks like Elasticsearch works the same way.
Single words don't need to be quoted but terms consisting of more than one word
do.
Regarding Zebra, we actually have the tools to easily catch this in our unit
tests:
#!/usr/bin/perl
use strict;
use warnings;
use C4::Context;
use ZOOM;
my $Zconn = C4::Context->Zconn;
eval {
my $bad = ZOOM::Query::CCL2RPN->new("Host-item=(MyTitle=
MySubtitle)",$Zconn);
};
warn $@ if $@;
my $good = ZOOM::Query::CCL2RPN->new('Host-item=("MyTitle=
MySubtitle")',$Zconn);
That code will output the following error:
ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown qualifier") from
diag-set 'ZOOM' at test.pl line 10.
It looks like
https://metacpan.org/pod/Search::Elasticsearch::Compat::QueryParser#check()
could provide similar error checking for Elasticsearch.
If we just syntax checked our query strings, we'd run into far fewer
problems...
Anyway, I'll open a new bug report for this one. I just figured it would be
good for folk to hear about it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What|Removed |Added Blocks||29970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29970 [Bug 29970] 500 Error when a record cannot be displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #78023|application/mrc |application/xml mime type|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #78023|application/xml |application/mrc mime type|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29560 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Katrin Fischer changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivilahti@hypern ||ova.fi --- Comment #521 from Olli-Antti Kivilahti --- Bug 11175, we have gone such a long way together. I am so proud of you, our bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29441 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29288 [Bug 29288] Add current_checkouts and old_checkouts methods to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #520 from Martin Renvoize --- Nice one.. faith in community restored.. sorry for being grumpy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #519 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #518 from Jonathan Druart --- Created attachment 126913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126913=edit Bug 11175: Add tests Add coverage for the message set by get_marc_components when the search fails. Also cleans a bit the weird return comparisons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126911|0 |1 is obsolete|| --- Comment #517 from Marcel de Rooy --- Created attachment 126912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126912=edit Bug 11175: (QA follow-up) Test message contents for analytics error Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #516 from Marcel de Rooy --- Created attachment 126911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126911=edit Bug 11175: (QA follow-up) Test message contents for analytics error Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126898|0 |1 is obsolete|| --- Comment #515 from Marcel de Rooy --- Created attachment 126904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126904=edit Bug 11175: (QA follow-up) Restore bug 29284 This patch restores the functional fixes introduced in bug 29284 and also prevents the 'Show analytics' link from displaying when no component parts are found and inline display is enabled. Signed-off-by: Marcel de Rooy Amended: Fixed error with $err vs $error(s) :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #126897|0 |1 is obsolete|| --- Comment #514 from Martin Renvoize --- Created attachment 126898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126898=edit Bug 11175: (QA follow-up) Restore bug 29284 This patch restores the functional fixes introduced in bug 29284 and also prevents the 'Show analytics' link from displaying when no component parts are found and inline display is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #513 from Martin Renvoize --- Created attachment 126897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126897=edit Bug 11175: (QA follow-up) Restore bug 29284 This patch restores the functional fixes introduced in bug 29284 and also prevents the 'Show analytics' link from displaying when no component parts are found and inline display is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |martin.renvoize@ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #512 from Martin Renvoize --- Latest rebase effectively reverts bug 29284, failing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126817|0 |1 is obsolete|| --- Comment #511 from Marcel de Rooy --- Created attachment 126895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126895=edit Bug 11175: (QA follow-up) Do not fetch twice We were fetching components in the first call of XSLTParse4Display (opac-detail around L220). And again (opac-detail around L660). Same for catalogue/detail.pl. Moving the XSLT block in both scripts and removing the code from XSLT.pm which again makes the tests obsolete. Not hiding the link when there are components. Might be helpful too. Also fixing biblionumber in the XSLTParse4Display call for parts. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126816|0 |1 is obsolete|| --- Comment #510 from Marcel de Rooy --- Created attachment 126894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126894=edit Bug 11175: (QA follow-up) Remove caching _components Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126741|0 |1 is obsolete|| --- Comment #509 from Marcel de Rooy --- Created attachment 126893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126893=edit Bug 11175: Uniformize ComponentParts in template More robust as it takes empty array into account Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126740|0 |1 is obsolete|| --- Comment #508 from Marcel de Rooy --- Created attachment 126892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126892=edit Bug 11175: Add syspref MaxComponentRecords to remove hardcoded limit Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126739|0 |1 is obsolete|| --- Comment #507 from Marcel de Rooy --- Created attachment 126891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126891=edit Bug 11175: (QA follow-up) Restore link to more results This patch restores the link to 'more results' should you exceed the hard coded limit of 300 component parts. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126738|0 |1 is obsolete|| --- Comment #506 from Marcel de Rooy --- Created attachment 126890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126890=edit Bug 11175: (QA follow-up) Be more specific with title fields We were using the MARC::Record title accessor, but that just stringifies all the subfields of field 245. The indexer, and the XSLT, specifically use 245a so we need to do the same. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126737|0 |1 is obsolete|| --- Comment #505 from Marcel de Rooy --- Created attachment 126889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126889=edit Bug 11175: (QA follow-up) Display components tab if no holdings This patch updates the default details tab selection to components for the case when there are no holdings attached to the record and there is no HTML5 content to display in preference. Bug 11175: (QA follow-up) OPAC - Display components tab if no holdings As for the staff client, this selects the default tab to be 'Components' for the case where no holdings are found. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126736|0 |1 is obsolete|| --- Comment #504 from Marcel de Rooy --- Created attachment 126888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126888=edit Bug 11175: (QA follow-up) Account for difference in simple_search return Thanks to a comment from Andrew, I discovered that the return from simple_search_compat actually differs depending on if you are using ElasticSearch or Zebra. The 'results' arrayref contains MARC::Record objects for ES and raw marc strings if you are using Zebra. This is actually already dealt with in the misnamed new_record_from_zebra function inside C4::Search.. so this patch simply replaces our MARC::Record instantiation code with a call to that function. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126735|0 |1 is obsolete|| --- Comment #503 from Marcel de Rooy --- Created attachment 126887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126887=edit Bug 11175: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126734|0 |1 is obsolete|| --- Comment #502 from Marcel de Rooy --- Created attachment 126886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126886=edit Bug 11175: Display components in own tab This patch updates the display so that rather than displaying the components using the main XSLT and then using CSS to move them into a box on the right side for display, which causes issues with RTL records; We instead add them in a new tab beneath the rest of the record details alongside holdings and other details. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Bug 11175: (QA follow-up) Fixes for bug 12561 Bug 12561 changed the prototype for XSLTParse4Display so this patcha accounts for the additional calls to that method introduced in this patchset. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126733|0 |1 is obsolete|| --- Comment #501 from Marcel de Rooy --- Created attachment 126885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126885=edit Bug 11175: (QA follow-up) Fix queries Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126732|0 |1 is obsolete|| --- Comment #500 from Marcel de Rooy --- Created attachment 126884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126884=edit Bug 11175: (QA follow-up) Only get biblio once Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126731|0 |1 is obsolete|| --- Comment #499 from Marcel de Rooy --- Created attachment 126883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126883=edit Bug 11175: (QA follow-up) Move get_component_part_query This patch removes Koha::Util::Search in preference to embedding the search query builder in Koha::Biblio as get_analytics_query. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Bug 11175: (QA follow-up) Rename back to get_marc_components Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126730|0 |1 is obsolete|| --- Comment #498 from Marcel de Rooy --- Created attachment 126882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126882=edit Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126729|0 |1 is obsolete|| --- Comment #497 from Marcel de Rooy --- Created attachment 126881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126881=edit Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126728|0 |1 is obsolete|| --- Comment #496 from Marcel de Rooy --- Created attachment 126880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126880=edit Bug 11175: (follow-up) Rename routine get_marc_components For consistency with other marc data accessor methods rename the new 'components' method to 'get_marc_components'. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126727|0 |1 is obsolete|| --- Comment #495 from Marcel de Rooy --- Created attachment 126879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126879=edit Bug 11175: (follow-up) make atomic update idempotent Atomic update tries to insert line into system preferences even if it's already there. This patch fixes that by adding 'IGNORE' to the query, making it idempotent. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126726|0 |1 is obsolete|| --- Comment #494 from Marcel de Rooy --- Created attachment 126878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126878=edit Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126725|0 |1 is obsolete|| --- Comment #493 from Marcel de Rooy --- Created attachment 126877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126877=edit Bug 11175: Remove outdated info about Elasticsearch not being suppported Support for Elasticsearch was added in commit "Bug 11175: Add Elasticsearch support". Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126724|0 |1 is obsolete|| --- Comment #492 from Marcel de Rooy --- Created attachment 126876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126876=edit Bug 11175: Search using double quotes to support Elasticsearch With Elasticsearch if you would use the search string here without the change to double quotes, i.e. (rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234' then the search would somehow manage to return a record with 001 = 1234 and 003 = FI-XXX. Using double quotes prevents that. Also using parenthesis around the latter part of the OR seems to work: (rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234') Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126723|0 |1 is obsolete|| --- Comment #491 from Marcel de Rooy --- Created attachment 126875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126875=edit Bug 11175: Limit the amount of component parts returned There was already before this a limit of 100 results when using Elasticsearch but then the list of component parts was truncated silently. This change now limits the amount to hard coded limit of 300 which is still fast to render. Also when the 300 component part record limit is reached there is a link in the list now to list all the records via the cataloging search. To test: 1) Create 300+ component part records and see if the link to list all the component part records shows up 2) Make sure prove t/Koha/Util/Search.t passes Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc This fixes the QA tool failure. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126722|0 |1 is obsolete|| --- Comment #490 from Marcel de Rooy --- Created attachment 126874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126874=edit Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126721|0 |1 is obsolete|| --- Comment #489 from Marcel de Rooy --- Created attachment 126873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126873=edit Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126720|0 |1 is obsolete|| --- Comment #488 from Marcel de Rooy --- Created attachment 126872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126872=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126719|0 |1 is obsolete|| --- Comment #487 from Marcel de Rooy --- Created attachment 126871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126871=edit Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126718|0 |1 is obsolete|| --- Comment #486 from Marcel de Rooy --- Created attachment 126870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126870=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
Marcel de Rooy changed:
What|Removed |Added
Attachment #126717|0 |1
is obsolete||
--- Comment #485 from Marcel de Rooy ---
Created attachment 126869
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126869=edit
Bug 11175: Show record component parts in the detail view
Shows the component records of a host, on the hosts detail view in
staff client or OPAC, with clickable links to the component records.
The host does not require linking entries to the components, but
components do require a link to the host record via 773$w.
Adds a new search index, Control-number-identifier (aka cni), which
indexes the 003 controlfield.
Adds 'Yet Another System Preference', ShowComponentRecords, which can
be used to turn this feature on or off in staff client and/or OPAC,
and defaults to off.
When looking up the component part records, the code searches for
records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001'
or, if the 003 is not defined in the Host, 773$w=Host001.
Does not use easyanalytics or useControlNumber.
Only for MARC21 biblios - UNIMARC has not been updated.
staff-global.css and opac.css have not been recreated, so you need
to use sass to recreate those from staff-global.scss and opac.scss
Test plan:
0) Apply patch
1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML
(This file is an attachment on the bug)
2) rebuild the zebra biblio index
3) Search for "easy piano" in staff client, and go to
the biblio detail page. You should not see anything different
in the record detail page.
4) Do the same on OPAC.
5) Change the ShowComponentRecords syspref appropriately and check
the record detail page in staff client and OPAC.
You should see a list of component part records.
Rebased-by: Joonas Kylmälä
Signed-off-by: Nick Clemens
Signed-off-by: Pasi Kallinen
Signed-off-by: Martin Renvoize
Signed-off-by: Andrew Nugged
JD amended path
-if ($xslsyspref =~ m/Details/) {
+if ( $xslsyspref eq "OPACXSLTDetailsDisplay" || $xslsyspref eq
"XSLTDetailsDisplay" ) {
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #484 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #482) > Needs rebasing for bug 29284 conflicts.. this will probably be easier with a > significant squash and loss of history. I'll do it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #483 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #480) > Fair enough, if you feel we should move the check back to the two > controllers I'm OK with that.. I've DRY'd the code in other regards now so > that bit of refactoring can get undone. You're incorrect in saying that the > search query would have ever been executed twice though.. we do not use the > 'Details' templates for the display of the component parts when inlined, so > the block with the query within it would not have been executed. Never say never: [2021/10/26 07:31:06] [WARN] components: C4::XSLT at /usr/share/koha/Koha/Biblio.pm line 503. [2021/10/26 07:31:06] [WARN] components: CGI::Compile::ROOT::usr_share_koha_opac_opac_2ddetail_2epl at /usr/share/koha/Koha/Biblio.pm line 503. Without the last follow-up. One view of opac-detail. First warn comes from XSLT as expected. Second call from opac-detail line 664 (really, as expected too). Just read the code. Ha, who really DRYed here? :) > Regarding having the 'Show analytics' link regardless of the preference.. > that's fine too; Though personally, I feel it perhaps confuses the end-user > with two links to display the same information.. one without a re-fetch and > one with. No time left for a debate here ;) If this would really be so confusing, we can remove it later or just css it away. Dont think so. > I feel this bug has gone on long enough and any further refinements should > be in their own bugs.. it worries me that so much is still going on at the > end of the development cycle of the bug personally. > > Don't you also need to remove some XSLT tests if you're moving the code back > out into the Controllers? Was already done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #482 from Martin Renvoize --- Needs rebasing for bug 29284 conflicts.. this will probably be easier with a significant squash and loss of history. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #481 from Martin Renvoize --- Now things have changed again I'm not confident in rebasing the set again.. no longer applies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #480 from Martin Renvoize --- Fair enough, if you feel we should move the check back to the two controllers I'm OK with that.. I've DRY'd the code in other regards now so that bit of refactoring can get undone. You're incorrect in saying that the search query would have ever been executed twice though.. we do not use the 'Details' templates for the display of the component parts when inlined, so the block with the query within it would not have been executed. Regarding having the 'Show analytics' link regardless of the preference.. that's fine too; Though personally, I feel it perhaps confuses the end-user with two links to display the same information.. one without a re-fetch and one with. I feel this bug has gone on long enough and any further refinements should be in their own bugs.. it worries me that so much is still going on at the end of the development cycle of the bug personally. Don't you also need to remove some XSLT tests if you're moving the code back out into the Controllers? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #479 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #478) > I believe there are some major differences between the features - so fully > agree. > > What we are looking for here is linking between bibliographic records. We > link a record to another record, using either $w or a combination of title > and author from 773 for search. So this is about hierarchies on the > bibliographic record level. > > EasyAnalytics as I understand it, is linking an item to multiple records > using non-standard MARC subfields of 773. It's a useful feature, but a > different use case. For example it could probably be used very well for > "bound-togethers", where different works where combined into one bound unit > (often found in historical holdings). > > We could probably make both work together by checking for the prefs and > maybe existence of certain subfields in 773, but as UseControlnumber and > Easyanalytics are already mutually exclusive right now, I think it's outside > of scope here. Thx for replying. We are on the same track. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #478 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #473) > I wrote two follow-ups now. WIll attach them tomorrow. > > But did look a bit closer to analytical records in Koha and they are quite > different from what is done here. They use 773 but thats about it. So there > seems to be no reason to braid(?) them together here. Making the analytics > disappear when there are components. > > Note: the components here work with 773 and record control numbers looked up > in biblio records. Analytics works different, storing item numbers(!) in > 773$9. This seems to be something that we add on top of MARC21, if I > understand correctly (so no default MARC21). > > Conclusion: We should keep them really separate from each other. Will have > to add that to my follow-up still. Which should be very trivial. > > Katrin: Could you confirm? I believe there are some major differences between the features - so fully agree. What we are looking for here is linking between bibliographic records. We link a record to another record, using either $w or a combination of title and author from 773 for search. So this is about hierarchies on the bibliographic record level. EasyAnalytics as I understand it, is linking an item to multiple records using non-standard MARC subfields of 773. It's a useful feature, but a different use case. For example it could probably be used very well for "bound-togethers", where different works where combined into one bound unit (often found in historical holdings). We could probably make both work together by checking for the prefs and maybe existence of certain subfields in 773, but as UseControlnumber and Easyanalytics are already mutually exclusive right now, I think it's outside of scope here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Blocks||29314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29314 [Bug 29314] Move some OpenURL code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
--- Comment #477 from Marcel de Rooy ---
+[% IF ComponentParts.size ==
Koha.Preference('MaxComponentRecords')%]
Might be better btw to check with >.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Text to go in the|This enhancement adds the |This enhancement adds the release notes|'ShowComponentParts' system |'ShowComponentParts' system |preference. |preference. | | |Upon enabling |When enabled, |this preference, where a|a record with analytical |record has analytic records |records has a new tab below |attached we will replace|the record detail |the 'Show analytics' link |containing links to the |with a new tab below the|component parts records. |record detail containing| |links to all the component |The feature requires |parts records. |`MaxComponentRecords` is | |set to limit the maximum |The feature |number of attached records |requires|to display; if more records |`MaxComponentRecords` is|are found then a link to |set to limit the maximum|the 'Show analytics' search |number of attached records |will appear at the bottom |to display; if more records |of the listed analytics. |are found then a link to| |the 'Show analytics' search | |will appear at the bottom | |of the listed analytics.| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #476 from Marcel de Rooy --- Tested this and feeling more comfortable now. The value of the MaxComponents syspref is 300 now. Which feels a bit high. But no problem. The EasyAnalytics stuff in Koha made this development a bit harder to understand. That area needs probably a bit more attention. Switching back to SO. If Martin agrees, we can move it back to PQA imho. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #475 from Marcel de Rooy --- Created attachment 126817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126817=edit Bug 11175: (QA follow-up) Do not fetch twice We were fetching components in the first call of XSLTParse4Display (opac-detail around L220). And again (opac-detail around L660). Same for catalogue/detail.pl. Moving the XSLT block in both scripts and removing the code from XSLT.pm which again makes the tests obsolete. Not hiding the link when there are components. Might be helpful too. Also fixing biblionumber in the XSLTParse4Display call for parts. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #474 from Marcel de Rooy --- Created attachment 126816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126816=edit Bug 11175: (QA follow-up) Remove caching _components Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126743|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126745|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #473 from Marcel de Rooy --- I wrote two follow-ups now. WIll attach them tomorrow. But did look a bit closer to analytical records in Koha and they are quite different from what is done here. They use 773 but thats about it. So there seems to be no reason to braid(?) them together here. Making the analytics disappear when there are components. Note: the components here work with 773 and record control numbers looked up in biblio records. Analytics works different, storing item numbers(!) in 773$9. This seems to be something that we add on top of MARC21, if I understand correctly (so no default MARC21). Conclusion: We should keep them really separate from each other. Will have to add that to my follow-up still. Which should be very trivial. Katrin: Could you confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #472 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #471) > Why pass the same biblionumber here when running through all component > records? Beginning to understand some of what happened here ;) Finally :) We still need a bit of fixing things that may have been broken during the process. Changing status. Will be submitting a follow-up. Dont touch please (today or tomorrow). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
--- Comment #471 from Marcel de Rooy ---
Still thinking about this a bit, and looking here:
for my $part ( @{$components} ) {
$part = C4::Search::new_record_from_zebra( 'biblioserver', $part );
push @{$parts},
XSLTParse4Display(
{
biblionumber => $biblionumber,
Why pass the same biblionumber here when running through all component records?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #470 from Marcel de Rooy --- Note that I am referring to XSLTParse4Display and not a detail script. I can understand this better going on in detail but not over a page of search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #469 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #464) > I think you're misunderstanding.. regardless of the preference the search > will take place.. and has been taking place since bug 15851... I just make > sure we don't execute it twice. I am not sure if this is correct btw. Where does that happen? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #468 from Marcel de Rooy --- Well, just asking. Dont worry. Not saying that we should revert things, people. But the fact that something has been pushed does certainly not always mean that it cannot be done better, different, etc. Step back and look again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #467 from Katrin Fischer --- (In reply to Martin Renvoize from comment #466) > The performance you DO save by disabling this one is an XSLT parse of each > of the resultant linked records. Thx for clarifying! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #466 from Martin Renvoize --- The performance you DO save by disabling this one is an XSLT parse of each of the resultant linked records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #465 from Martin Renvoize --- Note: Bug 26314 will do the same for volumes.. the only way we can selectively show/now show the 'Show volumes' link is to pre-execute the search to see if it will get results ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #464 from Martin Renvoize --- (In reply to Katrin Fischer from comment #463) > This has an on/off switch now, so I think if you are worried about > performance, you can not use the feature for now and still implement > something later on if needed. I think you're misunderstanding.. regardless of the preference the search will take place.. and has been taking place since bug 15851... I just make sure we don't execute it twice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #463 from Katrin Fischer --- (In reply to Martin Renvoize from comment #462) > (In reply to Marcel de Rooy from comment #460) > > And what about showing a link without fetching all components? In terms of > > performance? > > You mean undoing bug 15851 effectively reverting it and dropping the > requested bugfix/feature.? This has an on/off switch now, so I think if you are worried about performance, you can not use the feature for now and still implement something later on if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #462 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #460) > And what about showing a link without fetching all components? In terms of > performance? You mean undoing bug 15851 effectively reverting it and dropping the requested bugfix/feature.? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #461 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #459) > (In reply to Jonathan Druart from comment #458) > > Created attachment 126745 [details] [review] [review] > > Bug 11175: Add tests and correct show_analytics logic > > Somehow it still feels a bit strange to do this in the XSLT module. It was moved to the XSLT module for two reasons.. 1. DRY the code out.. it was sat in the controllers before and was slightly different in each.. so had bugs. 2. We were already passing a variable through to XSLT so we could use it in the stylesheets to work out whether to show the link or not.. thus it made sense to deal with it in the XSLT parser rather than passing it around at multiple levels. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #460 from Marcel de Rooy --- And what about showing a link without fetching all components? In terms of performance? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #459 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #458) > Created attachment 126745 [details] [review] > Bug 11175: Add tests and correct show_analytics logic Somehow it still feels a bit strange to do this in the XSLT module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Jonathan Druart changed: What|Removed |Added Attachment #126744|0 |1 is obsolete|| --- Comment #458 from Jonathan Druart --- Created attachment 126745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126745=edit Bug 11175: Add tests and correct show_analytics logic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #457 from Jonathan Druart --- Created attachment 126744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126744=edit Bug 11175: Add tests and correct show_analytics logic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Jonathan Druart changed: What|Removed |Added Attachment #126742|0 |1 is obsolete|| --- Comment #456 from Jonathan Druart --- Comment on attachment 126742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126742 Bug 11175: (QA follow-up) Simplify block in XSLT Tests are not passing with this patch, keeping my version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #455 from Marcel de Rooy --- Created attachment 126743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126743=edit Bug 11175: (QA follow-up) Remove caching _components Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #454 from Marcel de Rooy --- Created attachment 126742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126742=edit Bug 11175: (QA follow-up) Simplify block in XSLT Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126716|0 |1 is obsolete|| --- Comment #453 from Marcel de Rooy --- Created attachment 126741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126741=edit Bug 11175: Uniformize ComponentParts in template More robust as it takes empty array into account Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126715|0 |1 is obsolete|| --- Comment #452 from Marcel de Rooy --- Created attachment 126740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126740=edit Bug 11175: Add syspref MaxComponentRecords to remove hardcoded limit Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126714|0 |1 is obsolete|| --- Comment #451 from Marcel de Rooy --- Created attachment 126739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126739=edit Bug 11175: (QA follow-up) Restore link to more results This patch restores the link to 'more results' should you exceed the hard coded limit of 300 component parts. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126713|0 |1 is obsolete|| --- Comment #450 from Marcel de Rooy --- Created attachment 126738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126738=edit Bug 11175: (QA follow-up) Be more specific with title fields We were using the MARC::Record title accessor, but that just stringifies all the subfields of field 245. The indexer, and the XSLT, specifically use 245a so we need to do the same. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126712|0 |1 is obsolete|| --- Comment #449 from Marcel de Rooy --- Created attachment 126737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126737=edit Bug 11175: (QA follow-up) Display components tab if no holdings This patch updates the default details tab selection to components for the case when there are no holdings attached to the record and there is no HTML5 content to display in preference. Bug 11175: (QA follow-up) OPAC - Display components tab if no holdings As for the staff client, this selects the default tab to be 'Components' for the case where no holdings are found. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy changed: What|Removed |Added Attachment #126711|0 |1 is obsolete|| --- Comment #448 from Marcel de Rooy --- Created attachment 126736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126736=edit Bug 11175: (QA follow-up) Account for difference in simple_search return Thanks to a comment from Andrew, I discovered that the return from simple_search_compat actually differs depending on if you are using ElasticSearch or Zebra. The 'results' arrayref contains MARC::Record objects for ES and raw marc strings if you are using Zebra. This is actually already dealt with in the misnamed new_record_from_zebra function inside C4::Search.. so this patch simply replaces our MARC::Record instantiation code with a call to that function. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
