[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What|Removed |Added Attachment #112838|0 |1 is obsolete|| --- Comment #83 from Nick Clemens --- Created attachment 112852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112852=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #82 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #77) > Created attachment 112846 [details] [review] > Bug 11175: (follow-up) Use uppercase AND and OR words in search query > > Elasticsearch only understands uppercase query operators. Hi Joonas, I obsoleted yours and added a new patch to fully add ES support here, let me know if that works for you -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What|Removed |Added Attachment #112846|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #81 from Nick Clemens --- Created attachment 112851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112851=edit Bug 11175: Add Elasticsearch support -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #80 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #70) > Hi Joonas, > > finally found some time to take a closer look: > > 1) System preference > - I think staff interface is not a good tab choise, I'd put it under > "Cataloguing" or "Search". I went with Cataloguing. > - As this currently doesn't work for UNIMARC or Elasticsearch, we should add > a hint about this in the pref so people know what to expect. Added this info to description. > - And maybe "does not require UseControlNumber".? I don't understand what you mean here. > - Change staff client to staff interface (see terminology list) Done. > 3) I am still slightly worried about what will happen when there are several > hundred of analytical records found. This would be very commonly the case > for our law and special libraries that do extensive analytical cataloguing > for serials. And all the analyticals are linked to the serials (there are no > volume or issue records as per the rules of our union catalog) so it gets > quite a lot. Could you think of a strategy for those? > > Maybe we could define a number for a "cutoff" and display a link for "Show > more". Ideal would be to show the newest x linked records. I added 325 component part records and it loaded as far as I could tell the same speed as without any component part records, so there is no noticeable slow down here, the algorithm for this looks linear. The current approach seems OK to me, no need for paging because the HTML links generated here are very light weight. I'm thinking this is again ready for sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #79 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #71) > Hm, sorry, found a bigger issue last minute: In the OPAC the display is not > nice, probably due to the bootstrap patch being pushed in between. All the > components show above the title of the record now. To have it show correctly one needs to rebuild the CSS files: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface#Compiling_Sass_files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #77 from Joonas Kylmälä --- Created attachment 112846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112846=edit Bug 11175: (follow-up) Use uppercase AND and OR words in search query Elasticsearch only understands uppercase query operators. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #78 from Joonas Kylmälä --- Created attachment 112847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112847=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #74 from Joonas Kylmälä --- Created attachment 112840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112840=edit Bug 11175: (follow-up) Return empty array if no components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #75 from Joonas Kylmälä --- Created attachment 112841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112841=edit Bug 11175: (follow-up) Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #73 from Joonas Kylmälä --- Created attachment 112839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112839=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #76 from Joonas Kylmälä --- Rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Attachment #105631|0 |1 is obsolete|| Attachment #105641|0 |1 is obsolete|| Attachment #105706|0 |1 is obsolete|| Attachment #106692|0 |1 is obsolete|| --- Comment #72 from Joonas Kylmälä --- Created attachment 112838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112838=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@outlook.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #71 from Katrin Fischer --- Hm, sorry, found a bigger issue last minute: In the OPAC the display is not nice, probably due to the bootstrap patch being pushed in between. All the components show above the title of the record now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #70 from Katrin Fischer --- Hi Joonas, finally found some time to take a closer look: 1) System preference - I think staff interface is not a good tab choise, I'd put it under "Cataloguing" or "Search". - As this currently doesn't work for UNIMARC or Elasticsearch, we should add a hint about this in the pref so people know what to expect. - And maybe "does not require UseControlNumber".? - Change staff client to staff interface (see terminology list) 2) Use of 003 Looking at the patch and the test plan I am quite happy with the proposed search strategy. This should work really well for our libraries! 3) I am still slightly worried about what will happen when there are several hundred of analytical records found. This would be very commonly the case for our law and special libraries that do extensive analytical cataloguing for serials. And all the analyticals are linked to the serials (there are no volume or issue records as per the rules of our union catalog) so it gets quite a lot. Could you think of a strategy for those? Maybe we could define a number for a "cutoff" and display a link for "Show more". Ideal would be to show the newest x linked records. I am going to sign-off as this is an optional feature that works well as is. I hope we can figure out something for 1) (maybe we will add Elasticsearch support after consulting Nick?) and possibly 3) in the QA step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #69 from Martin Renvoize --- I've poked Nick C to ask how easy it might be to add a followup for ES support here. Otherwise, I'm generally happy with the code as it stands.. yes, it might be nice to eventually make it asynchronous, and perhaps we could make it clearer in the various sysprefs how EasyAnalytics and UseControlNumber are not involved in this one. But generally I think the approach is sound and doesn't add too much additional maintenance burden at this time. Awaiting Nicks reply before a final SO/QA run. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added CC||and...@bywatersolutions.com ||, n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #68 from David Cook --- I have concerns about these patches. Firstly, they're only targeting Zebra and not Elasticsearch. While I'm not sure if there is any formal rules about that yet, I think we want to be including Elasticsearch for all search related changes. Secondly, I don't really like the idea of stuffing more XML into the search result XSLT. I think that's already one of the slowest parts of Koha, and this is likely to just slow it down further. It would be nicer to load related data asynchronously using AJAX. But the more I read and re-read the code... maybe it's not a big drama. I feel like this is adding to technical debt, but I'm not going to block it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #67 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #65) > I will do some more testing with the unit test issue to make sure its not a > bug in the test code, so changing the status to "In discussion" until that > is resolved. The issue was with the test's handling of C4::AddBiblio() results: it was missing parentheses around $host_bibnum so it was treated as an array. I have fixed this now. The patches are ready for someone to sign-off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Attachment #105707|0 |1 is obsolete|| --- Comment #66 from Joonas Kylmälä --- Created attachment 106692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106692=edit Bug 11175: (follow-up) Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Serhij Dubyk changed: What|Removed |Added CC||du...@ukr.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #65 from Joonas Kylmälä --- I will do some more testing with the unit test issue to make sure its not a bug in the test code, so changing the status to "In discussion" until that is resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #64 from Joonas Kylmälä --- I added the missing tests and addressed the undef problem. In my kohadevbox setup however the test works only on the first run after running "reset_all". For some reason the Koha::Biblio->find accessor stops working, it could be something related to my setup, or there might be a bug in the test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #63 from Joonas Kylmälä --- Created attachment 105707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105707=edit Bug 11175: (follow-up) Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #62 from Joonas Kylmälä --- Created attachment 105706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105706=edit Bug 11175: (follow-up) Return empty array if no components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Attachment #105703|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #61 from Joonas Kylmälä --- Created attachment 105703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105703=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #60 from Joonas Kylmälä --- Created attachment 105641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105641=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |ASSIGNED Assignee|pasi.kalli...@koha-suomi.fi |joonas.kylm...@helsinki.fi --- Comment #59 from Joonas Kylmälä --- I rebased the earlier patch and will now start working on follow-ups for the two problems raised by Josef in comment #38: 1. Please, provide tests for this method 2. Do not return explicit undef I think it's is not bad idea to finish this implementation, the refactoring to DB table based implementation can be done later, this already adds a nice UI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Attachment #79810|0 |1 is obsolete|| --- Comment #58 from Joonas Kylmälä --- Created attachment 105631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105631=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #57 from Johanna Räisä --- Maybe we should open new ticket for it. The linking table could be generic and used more versatile for different types of links. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #56 from Olli-Antti Kivilahti --- BTW. First Finnish academic library HAMK went live last tuesday. Using ES in production. What we are trying to decide is, should these links be only in the ES index, only in the DB as a link-table with different link types separated, or should we implement both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #55 from Olli-Antti Kivilahti --- BTW Zebra doesn't always return the correct search results. For ex we have a REST API endpoint which returns all component parts for a biblio. It is awkward that we know some biblios have component parts, and still the Zebra searches don't return those results. That makes for rather bad API service. Using a DB link-table adds reliability. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #54 from Olli-Antti Kivilahti --- We can always open a new bug ticket :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #53 from Katrin Fischer --- So you are going to let this die here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #52 from Olli-Antti Kivilahti --- We are currently discussing how we solve this problem properly for both the Finnish academic and public library sectors. This includes more than 773 linking. I have 0% interest to keep fiddling with this miniscule minimum product which no longer satisfies our extended requirements. I understand the need for small steps, but thanks to the small steps, we still have to restart the SIP2-server due to memcached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
--- Comment #51 from Katrin Fischer ---
So I think the only thing left fixing are these 2 points right now, correct?
BTW I am not sure about a linking table for links between records, but I would
love to see a linking table for the EasyAnalytics feature that happens on item
level and 'spills over' into the record with non-standard 77x entries.
In reply to Josef Moravec from comment #38)
> Comment on attachment 79810 [details] [review]
> Bug 11175: Show record component parts in the detail view
>
> Review of attachment 79810 [details] [review]:
> -
>
> ::: Koha/Biblio.pm
> @@ +388,4 @@
> > return $self->{_biblioitem};
> > }
> >
> > +=head3 components
>
> Please, provide tests for this method
>
> @@ +399,5 @@
> > +
> > +sub components {
> > +my ($self) = @_;
> > +
> > +return undef if (C4::Context->preference('marcflavour') ne 'MARC21');
>
> Do not return explicit undef
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #50 from Martin Renvoize --- Add DB link tables moves this bug into entirely different territory in my opinion... lets get the basics working well with zebra first as we're very nearly there here already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #49 from Olli-Antti Kivilahti --- DB link table is a good idea. Zebra searches for the link relations were blazingly fast tho. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Johanna Räisä changed: What|Removed |Added CC||johanna.ra...@mikkeli.fi --- Comment #48 from Johanna Räisä --- As we have used this in Finland for some years now, my opinion is that using the index for linking the records is not very efficient. You are always depended on it and if you want to make REST endpoint for the host and its component parts the callback probably isn't always solid. Also we have had issues with removing records. If you remove the host record the children are not going to be removed at the same time. And finding which children can be removed afterwards is difficult. On the other hand cleaning the database is getting very annoying and slow. My proposal is to move this linking to database level. Having a linking table which has host's biblionumber and child's biblionumber would make it solid and easier to handle. This could be a solution that we don't have to implement always to new search index platform. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Josef Moravec changed: What|Removed |Added Blocks||21484 --- Comment #47 from Josef Moravec --- (In reply to Katrin Fischer from comment #44) > (In reply to Josef Moravec from comment #39) > > And please add support for elasticsearch. > > I don't think we should make this a requirement at the moment until > Elasticsearch has left experimental status and this has been added to the > coding guidelines as a requirement. For now, I think, not breaking > Elasticsearch functionality with new code would be enough. Other things can > be dealt with later. Ok, I could live without elastic for now, but I have filled a follow-up bug report - bug 21484 to address this. > > This is something we have been asked about for an awful long time, it would > be sad to see the first steps abandoned. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21484 [Bug 21484] Show the parent record's component parts in the detailed views - Elasticsearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #46 from Katrin Fischer --- I think making it work with other 7xx could be a next step on a separate bug report. Also for the other 7xx there is more information in the record already about the linked items. From a set you often don't see much if anything about the children, so this appears to be the most urgent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #45 from Olli-Antti Kivilahti --- I think this feature should be generalized to work with all the 77X linking fields as instructed by the MARC21 manual. That might not be such a big step up. Adding pagination is more complicated and requires this feature to be ported to the REST API, which would be superb anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #44 from Katrin Fischer --- (In reply to Josef Moravec from comment #39) > And please add support for elasticsearch. I don't think we should make this a requirement at the moment until Elasticsearch has left experimental status and this has been added to the coding guidelines as a requirement. For now, I think, not breaking Elasticsearch functionality with new code would be enough. Other things can be dealt with later. This is something we have been asked about for an awful long time, it would be sad to see the first steps abandoned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #43 from Josef Moravec --- (In reply to Olli-Antti Kivilahti from comment #41) Are you going to adopt this? It would be great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #42 from Josef Moravec --- (In reply to Olli-Antti Kivilahti from comment #41) > (In reply to Josef Moravec from comment #38) > > Do not return explicit undef > > Could you elaborate a bit why returning undef is bad? It could lead to unexpected results, see: https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::ProhibitExplicitReturnUndef https://perlmaven.com/how-to-return-undef-from-a-function We even have it in our guidelines (this policy is part of perlcritic severity 5): https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL4:_Perlcritic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivilahti@helsin ||ki.fi --- Comment #41 from Olli-Antti Kivilahti --- (In reply to Josef Moravec from comment #38) > Do not return explicit undef Could you elaborate a bit why returning undef is bad? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #40 from paxed --- Someone else can take this bug now, I have no time to work on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | Status|Signed Off |Failed QA CC||josef.mora...@gmail.com --- Comment #39 from Josef Moravec --- And please add support for elasticsearch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
--- Comment #38 from Josef Moravec ---
Comment on attachment 79810
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79810
Bug 11175: Show record component parts in the detail view
Review of attachment 79810:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11175=79810)
-
::: Koha/Biblio.pm
@@ +388,4 @@
> return $self->{_biblioitem};
> }
>
> +=head3 components
Please, provide tests for this method
@@ +399,5 @@
> +
> +sub components {
> +my ($self) = @_;
> +
> +return undef if (C4::Context->preference('marcflavour') ne 'MARC21');
Do not return explicit undef
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21469 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #37 from Martin Renvoize --- Works as expected for me and it looks like all QA comments to date have been resolved. Adding my SO as a second signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Attachment #79809|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 79810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79810=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Signed-off-by: Pasi Kallinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Attachment #79803|0 |1 is obsolete|| --- Comment #35 from paxed --- Created attachment 79809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79809=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the host detail view in staff client or OPAC, with clickable links to the component records. Host has no linking entries to the components, but the components link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds a Yet Another System Preference, ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001'. Does not use easyanalytics. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Keywords||Manual CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What|Removed |Added Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Attachment #79687|0 |1 is obsolete|| --- Comment #34 from paxed --- Created attachment 79803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79803=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the host detail view in staff client or OPAC, with clickable links to the component records. Host has no linking entries to the components, but the components link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds a Yet Another System Preference, ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001'. Except if UseControlNumber syspref is on, then it looks only for the Host field 001. Does not use easyanalytics. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #33 from paxed --- After talking with Cait, I'll make the feature depend on a syspref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Katrin Fischer changed: What|Removed |Added Summary|Show the parent record's|Show the parent record's |component parts in the |component parts in the |detailed views. |detailed views -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Attachment #78022|0 |1 is obsolete|| --- Comment #32 from paxed --- Created attachment 79687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79687=edit Bug 11175: Show record component parts in the detail view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #31 from Katrin Fischer --- Worse. The serial is the host, the children are the articles. The issue level is missing. This is because of the structure in our union catalog, but also fits Koha's subscription management. So this feature would have to be at least optional, nicer if we could use it of course. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #30 from paxed --- (In reply to Katrin Fischer from comment #29) > I really like the idea of this, but it won't work for some of our libraries > with hundreds of analytics on serial records. Could we truncate the list at > some (configurable) point with a 'see more' link at the end? Your serial parts are component records? So there's a serial "host record", of which each published magazine (or whatever) is a child record? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #29 from Katrin Fischer --- I really like the idea of this, but it won't work for some of our libraries with hundreds of analytics on serial records. Could we truncate the list at some (configurable) point with a 'see more' link at the end? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||joonas.kylm...@helsinki.fi --- Comment #28 from Joonas Kylmälä --- I cannot test this: Using index info to reconstruct a base tree... M C4/Search.pm M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Auto-merging C4/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 11175: Show record component parts in the detail view The copy of the patch that failed is found in: .git/rebase-apply/patch Also would it be better to make adding Control-number-identifier to it's own patch and how is this handled with Elasticsearch now that it is also supported by koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20310 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #27 from paxed --- Created attachment 78024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78024=edit Screenshot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #26 from paxed --- Created attachment 78023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023=edit Example marc data with host record and component parts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Attachment #26402|0 |1 is obsolete|| Attachment #26403|0 |1 is obsolete|| Attachment #26405|0 |1 is obsolete|| Attachment #26766|0 |1 is obsolete|| Attachment #26767|0 |1 is obsolete|| --- Comment #25 from paxed --- Created attachment 78022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78022=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host on the host intranet detail view, with clickable links to the component records. Host has no linking entries to the components, but the components link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001'. Does not use easyanalytics. Only for MARC21 biblios - MARC21 holdings and UNIMARC indexdefs haven't been updated. Only for the intranet detail page. Staff-client.css has not been recreated, so you need to sass that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What|Removed |Added Assignee|olli-antti.kivila...@jns.fi |pasi.kalli...@joensuu.fi CC||pasi.kalli...@joensuu.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I'd be interested in this as well :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #23 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Nice feature to test, could you rebase it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||12625 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #21 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26766 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26766action=edit Bug 11175 - Rebased to parse XML result from SimpleSearch instead of the ISO2709-version which it used to be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #26404|0 |1 is obsolete|| --- Comment #22 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26767 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26767action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Presentation for bootstrap-theme. This displays the injected component part records in the bootstrap theme. -- TEST PLAN -- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -opacthemes system preference needs to be 'bootstrap'. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality + New - New Child Record to catalog child records. TEST CASE1 - OPAC -Reindex Zebra -Search for the record you just made childs for and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #19 from David Cook dc...@prosentient.com.au --- I'm quite interested in linking records, so I might have to take a look at this one. I haven't reviewed the code or applied the patch yet, but how might this fare with a high number of child records? In the case of a journal with article component parts, you might have dozens, hundreds, or more child records for each parent. I wonder if this would be handled better by an AJAX call and using the relational database instead of XML records. In any case, I'll take a look later, but just a thought... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #20 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Thank you for your comment! AJAX might be a better option. You are free to submit any changes. The complexity of such goes way over what we can develop given our timeframe. For us this feature works relatively well since we only have a couple of hundred records in our database with over 100 component parts. I can totally see the caching issues, but returning only a subset of a search query from Zebra is beyond my competence. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #24791|0 |1 is obsolete|| --- Comment #17 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26404 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26404action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Presentation for bootstrap-theme. This displays the injected component part records in the bootstrap theme. -- TEST PLAN -- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -opacthemes system preference needs to be 'bootstrap'. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality + New - New Child Record to catalog child records. TEST CASE1 - OPAC -Reindex Zebra -Search for the record you just made childs for and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #24789|0 |1 is obsolete|| --- Comment #16 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26403 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26403action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Presentation for prog-theme. This displays the injected component part records in the prog theme. -- TEST PLAN -- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -opacthemes system preference needs to be 'prog'. -template system preference needs to be 'prog'. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality + New - New Child Record to catalog child records. TEST CASE1 - Staff client -Reindex Zebra -Search for the record you just made childs for and display it in the normal detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. TEST CASE2 - OPAC -Reindex Zebra -Search for the record you just made childs for and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #24788|0 |1 is obsolete|| --- Comment #15 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26402 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26402action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Business layer. TERMINOLOGY: Component part: A Bibliographic record connected to it's host record via $773w - 001 or via other Record-control-number-index relation. Host record: A bibliographic record which contains child records. Host record doesn't need to have a link to the child record. USEFUL: For music cataloguers whose jobs depend on these. For browsing the contents of a musical record. Provides the basis for a high quality music library service. Because Koha has the building blocks to create these component part records out of box, it is odd that they can't be displayed out of box. This patch adds a system preference AddComponentPartRecordsToDetailedViews. This controls if component part records data is appended after the bibliographic data for XSLT parsing. Also makes sure that component part records are not pulled needlessly for non-detailed views as this would cripple performance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #18 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 26405 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26405action=edit Bug 11175 - Fixing component part injection for non-default XSL-templates Changed the Detailed-view detection to include also custom XSLTs'. Removed unnecessary checks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #14 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Would you kindly help me help you get this feature to master? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #9 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 24788 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24788action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Business layer. TERMINOLOGY: Component part: A Bibliographic record connected to it's host record via $773w - 001 or via other Record-control-number-index relation. Host record: A bibliographic record which contains child records. Host record doesn't need to have a link to the child record. USEFUL: For music cataloguers whose jobs depend on these. For browsing the contents of a musical record. Provides the basis for a high quality music library service. Because Koha has the building blocks to create these component part records out of box, it is odd that they can't be displayed out of box. This patch adds a system preference AddComponentPartRecordsToDetailedViews. This controls if component part records data is appended after the bibliographic data for XSLT parsing. Also makes sure that component part records are not pulled needlessly for non-detailed views as this would cripple performance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #10 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 24789 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24789action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Presentation for prog-theme. This displays the injected component part records in the prog theme. -- TEST PLAN -- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -opacthemes system preference needs to be 'prog'. -template system preference needs to be 'prog'. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality + New - New Child Record to catalog child records. TEST CASE1 - Staff client -Reindex Zebra -Search for the record you just made childs for and display it in the normal detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. TEST CASE2 - OPAC -Reindex Zebra -Search for the record you just made childs for and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #11 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 24790 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24790action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Presentation for bootstrap-theme. This displays the injected component part records in the bootstrap theme. -- TEST PLAN -- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -opacthemes system preference needs to be 'bootstrap'. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality + New - New Child Record to catalog child records. TEST CASE1 - OPAC -Reindex Zebra -Search for the record you just made childs for and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #12 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- (In reply to Katrin Fischer from comment #7) Hi, starting with a code review: Thank you for the effort Katrin! It is much appreciated! - Small thing: Please break your commit messages into shorter lines so they are easier to read in a terminal window. I hope it's better. I also hope with shorter lines you don't mean the dreaded 80 character maximum. - Please provide a follow-up for the Bootstrap theme. As prog and CCSR are going to be deprecated this is mandatory now. Follow up provided! - Database update adding the new system preference is missing. Provided! - The way this is coded it's a MARC21 specific feature. The rcn index and 001 $w linking are not MARC agnostic. Please check for the marcflavor in your code and include a note about the limitation to MARC21 in the syspref description. Added a note to the system preference. Didn't add any syspref checks to the business layer. Uncertain if rcn is unused in UNIMARC. If rcn-index is unpopulated, then should cause zero extra overhead. If rcn is populated in UNIMARC, then this feature should work? - Some of the comments look like TODOs - maybe something you want to take another look at? Apologies for that. I think it was a classical mistake. - Creating our 'own' XML in a MARCXML record doesn't look right to me. I would much prefer if that could be expressed in normal MARC21 fields and subfields. I guess I could differentiate from the searched component part records the marc field they use to make the linking. All the data is available since the found records are converted into MARC::Record objects. Then this data could be injected to appropriate MARC::Fields to construct a proper marc record. If this behaviour is wanted maybe it is better to create them when these component part relations are defined? Thus these links would be preserved during MARC-export function. The effort however doesn't justify the perceived benefits in my opinion. If you can demonstrate the benefits (like displaying different kinds of component relations under different heading) a follow-up can be prepared and designed. Also a own XML in MARCXML is already there inside the sysprefs-tag. - With the heading Child records you assume that it will be always a component part, but that's not true. 001 $w linkings are used to express a lot of different relationships between records. I think putting a bit more thought into the various relationships could be good here. You are very correct. I went to the MARC21 manual and looked into the various aspects of linkings. I changed the terminology to child - component part. Also the QA script points out some issues: FAIL C4/XSLT.pm FAIL pod *** ERROR: Unknown command 'head' in file C4/XSLT.pm *** ERROR: Spurious text after =cut in file C4/XSLT.pm I don't know from where these are coming from? OK forbidden patterns OK valid FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). Fixed this issue. perlcritic++ Happy to deliver! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #24790|0 |1 is obsolete|| --- Comment #13 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 24791 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24791action=edit Bug 11175 - Show the parent record's component parts in the detailed views. Presentation for bootstrap-theme. This displays the injected component part records in the bootstrap theme. -- TEST PLAN -- PREREQUISITES: -AddChildRecordsToDetailedViews system preference needs to be activated. -opacthemes system preference needs to be 'bootstrap'. -Catalog a bunch of child records for a host record. --Search a record and go to detailed view. --Use the existing functionality + New - New Child Record to catalog child records. TEST CASE1 - OPAC -Reindex Zebra -Search for the record you just made childs for and display it in the opac-detail.pl -view. -Verify that a list of child records are displayed on the right side of the browser window. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #23049|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Summary|Show the parent records |Show the parent record's |child records (aka. |component parts in the |component parts) in the |detailed views. |detailed views. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
