[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #26 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Srdjan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #25 from Fridolin SOMERS fridolyn.som...@biblibre.com --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Blocks||8817 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #24 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Srdjan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #22 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 23097 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23097action=edit Bug 11183 - Warnings in opac - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #22856|0 |1 is obsolete|| Attachment #22862|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 23095 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23095action=edit bug_11183: get rid of some warnings To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Have an item with Collection Code. Check that the Collection Code shows. * Collection Code is set by editing an item in the staff client (952$8) Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #21 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 23096 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23096action=edit Bug 11183 - Warnings in opac This may affect staff as well. During testing of Srdjan Jankovic's patch, the following error message was triggered: opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314. This was traced to a bad call on subfields in C4::Search. By adding an if check around the call, this warning is no longer triggered. Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #23097|0 |1 is obsolete|| CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11269 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #23 from Tomás Cohen Arazi tomasco...@gmail.com --- The second patch (Warnings in opac) is similar to the one from Bug 11269 which has been pushed already. This patch is prior to mine, its my fault because I did a wrong search and concluded it hadn't been addresed. Sorry for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #23096|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11242 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #22866|0 |1 is obsolete|| --- Comment #17 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22867 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22867action=edit bug_11183: Supress undef warning in opac-MARCdetail.pl To test: * Go to /cgi-bin/koha/opac-MARCdetail.pl?biblionumber=your fav biblionumber and confirm that pre and post patch page looks the same. An apology: I tried to find a syspref combination that displays opac-MARCdetail.pl links in OPAC search results, and failed. If anyone knows, the secret combination, please disclose. I resorted to entering the url by hand. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #18 from M. Tompsett mtomp...@hotmail.com --- The opac-MARCdetail.pl link is not in the search, but you can get to it by: 1) Search for something in OPAC 2) Click link, which will take you to the Normal View page (opac-detail.pl). 3) Click the MARC detail view link (opac-MARCdetail.pl). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #22867|0 |1 is obsolete|| --- Comment #19 from Srdjan Jankovic srd...@catalyst.net.nz --- Comment on attachment 22867 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22867 bug_11183: Supress undef warning in opac-MARCdetail.pl Issue dealt with in another bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #22857|0 |1 is obsolete|| --- Comment #15 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22862 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22862action=edit [SIGNED-OFF] Bug 11183 - Warnings in opac This may affect staff as well. During testing of Srdjan Jankovic's patch, the following error message was triggered: opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314. This was traced to a bad call on subfields in C4::Search. By adding an if check around the call, this warning is no longer triggered. Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #16 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22866 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22866action=edit bug_11183: Supress undef warning in opac-MARCdetail.pl To test: * Go to /cgi-bin/koha/opac-MARCdetail.pl?biblionumber=your fav biblionumber and confirm that pre and post patch page looks the same. An apology: I tried to find a syspref combination that displays opac-MARCdetail.pl links in OPAC search results, and failed. If anyone knows, the secret combination, please disclose. I resorted to entering the url by hand. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #22810|0 |1 is obsolete|| --- Comment #7 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22853 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22853action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #22853|0 |1 is obsolete|| --- Comment #8 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22855 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22855action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #9 from M. Tompsett mtomp...@hotmail.com --- This is how I tested it: mtompset@ubuntu:~/kohaclone$ git reset --hard origin/master HEAD is now at 0d5f73d Merge branch 'new/bug11205' mtompset@ubuntu:~/kohaclone$ echo ~/koha-dev/var/log/koha-opac-error_log I then did a simple search 'unhappy' and then clicked an entry know to not have the collection code set. mtompset@ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u opac-detail.pl: Use of uninitialized value $ccode in exists at /home/mtompset/kohaclone/opac/opac-detail.pl line 576., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-search.pl?idx=q=unhappybranch_group_limit= opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=14206query_desc=kw%2Cwrdl%3A%20happy%20life opac-search.pl: Use of uninitialized value $limit_desc in concatenation (.) or string at /home/mtompset/kohaclone/opac/opac-search.pl line 626., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=14206query_desc=kw%2Cwrdl%3A%20happy%20life mtompset@ubuntu:~/kohaclone$ git bz apply 11183 Bug 11183 - Warnings in opac 22855 - bug_11183: get rid of some warninngs Apply? [(y)es, (n)o, (i)nteractive] y Applying: bug_11183: get rid of some warninngs mtompset@ubuntu:~/kohaclone$ echo ~/koha-dev/var/log/koha-opac-error_log I then did a simple search 'unhappy' and then clicked an entry know to not have the collection code set. mtompset@ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=13896query_desc=kw%2Cwrdl%3A%20unhappy mtompset@ubuntu:~/kohaclone$ Sorry, gmcharlt. I found a bug in MARC::Field. ;) But not this. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22855|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #10 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22856 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22856action=edit [SIGNED OFF] bug_11183: get rid of some warnings To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Have an item with Collection Code. Check that the Collection Code shows. * Collection Code is set by editing an item in the staff client (952$8) Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22839|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #11 from M. Tompsett mtomp...@hotmail.com --- Okay, the 314 warning bugged me enough, and I hunted it down to line 1838 of the master's C4/Search.pm, which I will add a second patch to this, as the test case triggered the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #13 from Srdjan Jankovic srd...@catalyst.net.nz --- I did something with Search.pm too on a different bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #12 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22857 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22857action=edit Bug 11183 - Warnings in opac This may affect staff as well. During testing of Srdjan Jankovic's patch, the following error message was triggered: opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314. This was traced to a bad call on subfields in C4::Search. By adding an if check around the call, this warning is no longer triggered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #14 from M. Tompsett mtomp...@hotmail.com --- The test plan is as given on the original patch: To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Have an item with Collection Code. Check that the Collection Code shows. * Collection Code is set by editing an item in the staff client (952$8) I happen to have two items with unhappy in the title, and so I gave one a collection code, while the other did not have one. 1) Search for unhappy in OPAC 2) Click link 1 3) Browser back 4) Click line 2 These steps are between the clearing of the error log and the viewing unique errors in the error log. The results of my testing: mtompset@ubuntu:~/kohaclone$ git reset --hard origin/master HEAD is now at 0d5f73d Merge branch 'new/bug11205' mtompset@ubuntu:~/kohaclone$ echo ~/koha-dev/var/log/koha-opac-error_log mtompset@ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u opac-detail.pl: Use of uninitialized value $ccode in exists at /home/mtompset/kohaclone/opac/opac-detail.pl line 576., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-search.pl?idx=q=unhappybranch_group_limit= opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314., referer: http://demo.library.kohasystem.ca/ opac-search.pl: Use of uninitialized value $limit_desc in concatenation (.) or string at /home/mtompset/kohaclone/opac/opac-search.pl line 626., referer: http://demo.library.kohasystem.ca/ mtompset@ubuntu:~/kohaclone$ git bz apply 11183 Bug 11183 - Warnings in opac 22856 - [SIGNED OFF] bug_11183: get rid of some warnings 22857 - Bug 11183 - Warnings in opac Apply? [(y)es, (n)o, (i)nteractive] y Applying: bug_11183: get rid of some warnings Applying: Bug 11183 - Warnings in opac mtompset@ubuntu:~/kohaclone$ echo ~/koha-dev/var/log/koha-opac-error_log mtompset@ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u mtompset@ubuntu:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Assignee|oleon...@myacpl.org |srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #22801|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 22810 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22810action=edit bug_11183: get rid of some warnings To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Collection Code is set by editing an item in the staff client (952$8) Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #5 from Galen Charlton gmcha...@gmail.com --- Comment on attachment 22810 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22810 bug_11183: get rid of some warnings Review of attachment 22810: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11183attachment=22810) - ::: opac/opac-detail.pl @@ +573,4 @@ # get collection code description, too my $ccode = $itm-{'ccode'}; +$itm-{'ccode'} = $collections-{$ccode} if $ccode $collections $collections-{$ccode}; I believe what was called for was just adding a check on whether $ccode was defined. Getting rid of the defined($collections) and exists( $collections-{$ccode} breaks things if the library happened to define 0 as a collection code. Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Failed QA CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #6 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22839 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22839action=edit Sample code demonstrating problem Galen found. It also includes a revision which should work. I know a code of '' isn't really possible, but that also fails. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #22663|0 |1 is obsolete|| --- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22794 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22794action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22801 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22801action=edit [SIGNED OFF] bug_11183: get rid of some warnings To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Collection Code is set by editing an item in the staff client (952$8) Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22794|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #1 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22663 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22663action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/