[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2015-12-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Sophie MEYNIEUX  changed:

   What|Removed |Added

 Blocks||15417


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15417
[Bug 15417] Status for duplicate SMS messages should not be 'failed'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Galen Charlton  ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

M. de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #23 from M. de Rooy  ---
Created attachment 27938
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27938&action=edit
Bug 11209: Check if a notice has been already sent today

The previous patch checks if a notice has already been sent when the
current notices has been sent in queue. Which is wrong!
We have to check if a similar notice has been sent today.

This patch has been created after an observation on a production server:
If a user place on holds several items, he will receive 1 SMS per hold.
Here we only want 1 SMS for all holds.

Signed-off-by: Chris Cormack 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #24 from M. de Rooy  ---
Created attachment 27939
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27939&action=edit
Bug 11209: A message is duplicate if its content has been already sent

If the template contains dynamic parts, the message won't be
considerated as duplicated.

Signed-off-by: Marcel de Rooy 
Duplicate messages will be queued, but when sending the queued messages
duplicates are found and are marked as failed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

M. de Rooy  changed:

   What|Removed |Added

  Attachment #27827|0   |1
is obsolete||
  Attachment #27828|0   |1
is obsolete||
  Attachment #27919|0   |1
is obsolete||

--- Comment #22 from M. de Rooy  ---
Created attachment 27937
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27937&action=edit
Bug 11209: Don't sent the same message for the same user the same day

For PREDUE messages, one message is sent to the message_queue table for
each items in advanced.
So the patron will receive the same message.

The sms part for DUE and PREDUE should not contain dynamic parts, only a
standard message.

Signed-off-by: Chris Cormack 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #21 from Jonathan Druart  ---
Created attachment 27919
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27919&action=edit
Bug 11209: A message is duplicate if its content has been already sent

If the template contains dynamic parts, the message won't be
considerated as duplicated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #20 from Jonathan Druart  ---
(In reply to M. de Rooy from comment #16)
> If I have enabled email and sms for a patron, but I have no email address
> and the SMS driver should fail, I have two messages in the queue that fall
> back to PREDUE print. In this case you will have print duplicates. (Two runs
> now create four PREDUE prints.)

This has already been raised by Olli, he opened a report, bug 11561.

(In reply to M. de Rooy from comment #17)
> Similarly, if I clear the SMS number, sms messages will be sent to the queue
> each time in status pending. They will fail only if process cronjob has been
> run.

Yes, a test could be added somewhere. But it should not append (yes you can via
the UI, but it is a configuration issue).

(In reply to M. de Rooy from comment #19)
> I have some doubts on this patch:
> It could block lots of sms messages. You write: The sms part for DUE and
> PREDUE should not contain dynamic parts, only a
> standard message. But how do you prevent that (maybe apart from truncating
> the message to 160 chars)?
> If a message for a hold or a due does not contain a reference to the title,
> is it still useful for a patron at all? I could imagine that you send one
> message for dues at cronjob time, but what about Hold filled? Wouldn't that
> be a candidate for sending more messages if applicable?

Maybe could I add a condition in the sql query like " AND content =
$message->{content}".
Like that, if the template contains dynamic parts, that won't match.
What do you think about that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #19 from M. de Rooy  ---
I have some doubts on this patch:
It could block lots of sms messages. You write: The sms part for DUE and PREDUE
should not contain dynamic parts, only a
standard message. But how do you prevent that (maybe apart from truncating the
message to 160 chars)?
If a message for a hold or a due does not contain a reference to the title, is
it still useful for a patron at all? I could imagine that you send one message
for dues at cronjob time, but what about Hold filled? Wouldn't that be a
candidate for sending more messages if applicable?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #18 from Katrin Fischer  ---
It sounds to me like it would make sense not to try and create the message if
the sms number is not sent or make sure to only have one printed mail for a
fallback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #17 from M. de Rooy  ---
Similarly, if I clear the SMS number, sms messages will be sent to the queue
each time in status pending. They will fail only if process cronjob has been
run.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #16 from M. de Rooy  ---
Just an observation (no big deal):
If I have enabled email and sms for a patron, but I have no email address and
the SMS driver should fail, I have two messages in the queue that fall back to
PREDUE print. In this case you will have print duplicates. (Two runs now create
four PREDUE prints.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #15 from M. de Rooy  ---
QA: Looking at this one now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-04-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Chris Cormack  changed:

   What|Removed |Added

  Attachment #23255|0   |1
is obsolete||

--- Comment #14 from Chris Cormack  ---
Created attachment 27828
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27828&action=edit
Bug 11209: Check if a notice has been already sent today

The previous patch checks if a notice has already been sent when the
current notices has been sent in queue. Which is wrong!
We have to check if a similar notice has been sent today.

This patch has been created after an observation on a production server:
If a user place on holds several items, he will receive 1 SMS per hold.
Here we only want 1 SMS for all holds.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-04-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Chris Cormack  changed:

   What|Removed |Added

  Attachment #22762|0   |1
is obsolete||

--- Comment #13 from Chris Cormack  ---
Created attachment 27827
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27827&action=edit
Bug 11209: Don't sent the same message for the same user the same day

For PREDUE messages, one message is sent to the message_queue table for
each items in advanced.
So the patron will receive the same message.

The sms part for DUE and PREDUE should not contain dynamic parts, only a
standard message.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-04-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-04-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #12 from Chris Cormack  ---
(In reply to M. Tompsett from comment #10)
> I'm curious about the time queued date vs. now(). What if there is a cross
> midnight situation? Can such a situation happen? I figure if some branches
> are 12 timezones away from other branchs, it may.

The timezone that matters is the timezone the database server is in, that is
the one doing the NOW()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-04-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Galen Charlton  changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-04-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
Can we get a sign off on this please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-03-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #10 from M. Tompsett  ---
I'm curious about the time queued date vs. now(). What if there is a cross
midnight situation? Can such a situation happen? I figure if some branches are
12 timezones away from other branchs, it may.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-02-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||11603

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #9 from Jonathan Druart  ---
In fact, it is not a code dependency, more a functionality dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #8 from Jonathan Druart  ---
yes, it is just a followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #7 from mathieu saby  ---
And it still depends on 11208?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #6 from Jonathan Druart  ---
Created attachment 23255
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23255&action=edit
Bug 11209: Check if a notice has been already sent today

The previous patch checks if a notice has already been sent when the
current notices has been sent in queue. Which is wrong!
We have to check if a similar notice has been sent today.

This patch has been created after an observation on a production server:
If a user place on holds several items, he will receive 1 SMS per hold.
Here we only want 1 SMS for all holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-12-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #5 from mathieu saby  ---
(In reply to Jonathan Druart from comment #4)
> Did you check the dependency?

Oh no, I did not see it!
Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-12-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #4 from Jonathan Druart  ---
Did you check the dependency?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-11-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

mathieu saby  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from mathieu saby  ---
Before applying the patch:

I set 2 items due on the 3rd December for the same patron.
I ran $perl misc/cronjobs/advance_notices.pl -c
I checked the message_queue table : there are 2 messages, one for each item.

So, bug confirmed.

But the patch does not apply.
I got this message
Applying: Bug 11209: Don't sent the same message for the same user the same day
fatal: sha1 information is lacking or useless (C4/Letters.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.


Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-11-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

mathieu saby  changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-11-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #22752|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  ---
Created attachment 22762
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22762&action=edit
Bug 11209: Don't sent the same message for the same user the same day

For PREDUE messages, one message is sent to the message_queue table for
each items in advanced.
So the patron will receive the same message.

The sms part for DUE and PREDUE should not contain dynamic parts, only a
standard message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||11208
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #1 from Jonathan Druart  ---
Created attachment 22752
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22752&action=edit
Bug 11209: Don't sent the same message for the same user the same day

For PREDUE messages, one message is sent to the message_queue table for
each items in advanced.
So the patron will receive the same message.

The sms part for DUE and PREDUE should not contain dynamic parts, only a
standard message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/