[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #16 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 27531 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27531action=edit Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #27531|0 |1 is obsolete|| CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m --- Comment #14 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Will be needed in 3.12, 3.10 and 3.8. Thanks ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #15 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Koha Team AMU koha.aixmarsei...@gmail.com changed: What|Removed |Added CC||koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Koha Team AMU koha.aixmarsei...@gmail.com changed: What|Removed |Added CC|koha.aixmarsei...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #22802|0 |1 is obsolete|| Attachment #22803|0 |1 is obsolete|| Attachment #22804|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 22823 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22823action=edit Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. Signed-off-by: Liz Rea l...@catalyst.net.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 22825 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22825action=edit Bug 11218: QA follow-up - Fixing some whitespace and a variable declaration Fixing some things the QA script pointed out this morning: - whitespace - variable declaration Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- Passes koha-qa.pl, t and xt. Great unit tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 22824 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22824action=edit Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch Signed-off-by: Liz Rea l...@catalyst.net.nz Passes functional tests and automated tests. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #13 from Galen Charlton gmcha...@gmail.com --- Pushed to master and 3.14.x. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9362 --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- As it worked before I tried tracking the problem down with git bisect - it came up with the changes from bug 9362 which looks plausible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 22795 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22795action=edit Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 22796 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22796action=edit Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- In my tests this seems to work now with the patches applied, please test thorougly and feedback welcome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #22795|0 |1 is obsolete|| Attachment #22796|0 |1 is obsolete|| --- Comment #5 from Liz Rea l...@catalyst.net.nz --- Created attachment 22799 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22799action=edit Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch Signed-off-by: Liz Rea l...@catalyst.net.nz Passes functional and automated testing. Due notice functionality restored. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #22799|0 |1 is obsolete|| CC||l...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #22796|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #22795|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #7 from Liz Rea l...@catalyst.net.nz --- Created attachment 22803 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22803action=edit Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch Signed-off-by: Liz Rea l...@catalyst.net.nz Passes functional tests and automated tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #22796|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11218] Due notices broken / not generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 22804 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22804action=edit Bug 11218: QA follow-up - Fixing some whitespace and a variable declaration Fixing some things the QA script pointed out this morning: - whitespace - variable declaration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
