subject:"\[Koha\-bugs\] \[Bug 11297\] Add support for custom PQF attributes for Z39.50 server searches"

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Joy Nelson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||j...@bywatersolutions.com
 Status|Pushed to master|RESOLVED

--- Comment #124 from Joy Nelson  ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||24708


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708
[Bug 24708] Update Z39.50 server attribute in fr-CA installation file
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #123 from David Cook  ---
Reminds me how I really should work on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202 one of these
days 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||20.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #122 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #121 from Katrin Fischer  ---
Still missing tests... :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #120 from Katrin Fischer  ---
Created attachment 99231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99231=edit
Bug 11297: (QA follow-up) Make table headings match other pages - use Actions
instead of Options

The patch set adds a table hading for the Actions column on the
summary page. If you compare with other pages, this should
be labelled 'Actions' instead of 'Options'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98601|0   |1
is obsolete||

--- Comment #119 from Katrin Fischer  ---
Created attachment 99230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99230=edit
Bug 11297: (follow-up) Add html filter to new input field

Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98600|0   |1
is obsolete||

--- Comment #118 from Katrin Fischer  ---
Created attachment 99229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99229=edit
Bug 11297: Modify Z3950server schema file

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98599|0   |1
is obsolete||

--- Comment #117 from Katrin Fischer  ---
Created attachment 99228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99228=edit
Bug 11297: Add atomicupdate patch and modify kohastructure.sql

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98598|0   |1
is obsolete||

--- Comment #116 from Katrin Fischer  ---
Created attachment 99227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99227=edit
Bug 11297: Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|m.de.r...@rijksmuseum.nl|katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

David Nind  changed:

   What|Removed |Added

  Attachment #92722|0   |1
is obsolete||

--- Comment #115 from David Nind  ---
Created attachment 98601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98601=edit
Bug 11297: (follow-up) Add html filter to new input field

Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

David Nind  changed:

   What|Removed |Added

  Attachment #92721|0   |1
is obsolete||

--- Comment #114 from David Nind  ---
Created attachment 98600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98600=edit
Bug 11297: Modify Z3950server schema file

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

David Nind  changed:

   What|Removed |Added

  Attachment #92720|0   |1
is obsolete||

--- Comment #113 from David Nind  ---
Created attachment 98599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98599=edit
Bug 11297: Add atomicupdate patch and modify kohastructure.sql

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2020-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

David Nind  changed:

   What|Removed |Added

  Attachment #92719|0   |1
is obsolete||

--- Comment #112 from David Nind  ---
Created attachment 98598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98598=edit
Bug 11297: Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Server name: BAnQ
Hostname   : catalogue.banq.qc.ca
Port   : 210
Database   : IRIS
Syntax : MARC21/USMARC

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2019-11-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Arthur Bousquet  changed:

   What|Removed |Added

 Blocks|11361   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361
[Bug 11361] Add a Z39.50 search page in the OPAC to let members search for
records on remote Koha instances
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2019-09-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Bin Wen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||bin@inlibro.com

--- Comment #111 from Bin Wen  ---
Rebase for new progress

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2019-09-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Bin Wen  changed:

   What|Removed |Added

  Attachment #81345|0   |1
is obsolete||

--- Comment #109 from Bin Wen  ---
Created attachment 92721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92721=edit
Bug 11297: Modify Z3950server schema file

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2019-09-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Bin Wen  changed:

   What|Removed |Added

  Attachment #81346|0   |1
is obsolete||

--- Comment #110 from Bin Wen  ---
Created attachment 92722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92722=edit
Bug 11297: (follow-up) Add html filter to new input field

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2019-09-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Bin Wen  changed:

   What|Removed |Added

  Attachment #81344|0   |1
is obsolete||

--- Comment #108 from Bin Wen  ---
Created attachment 92720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92720=edit
Bug 11297: Add atomicupdate patch and modify kohastructure.sql

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2019-09-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Bin Wen  changed:

   What|Removed |Added

  Attachment #81343|0   |1
is obsolete||

--- Comment #107 from Bin Wen  ---
Created attachment 92719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92719=edit
Bug 11297: Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2019-03-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

José-Mario Monteiro-Santos  changed:

   What|Removed |Added

 CC||jose-mario.monteiro-santos@
   ||inlibro.com

--- Comment #106 from José-Mario Monteiro-Santos 
 ---
(In reply to Martin Renvoize from comment #105)
> I'll try and take a look at tests tomorrow, sorry guys.

Any specific plan in mind ? It's a pretty daunting task to correctly test the
entirety of the Z3950Search sub. I can take a stab at it, but I'd love some
pointers to help me get started.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-11-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #105 from Martin Renvoize  ---
I'll try and take a look at tests tomorrow, sorry guys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-11-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #104 from Katrin Fischer  ---
Hm, didn't realize Martin's comments were from today, not sure if someone else
would be able to help out here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-11-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #103 from Katrin Fischer  ---
I'm sorry, we've already passed feature slush :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-11-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #102 from Blou  ---
We're in mud, we've no way to prioritize this in the next few weeks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-11-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #101 from Martin Renvoize  ---
We're in Slush.. so a quick followup could still just make it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-11-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #100 from Martin Renvoize  ---
I jumped the gun here.. C4::Breeding needs updated tests to cover the new
functionality.

Sorry guys.. it had been a long week when I qa'd this first time around.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #99 from Martin Renvoize  ---
I took the liberty of squashing the QA Followup patch into the original
atomicupdate patch (to silence the 'git manipulation warning' from the qa
scripts).

Back to passed qa, I'm sure this will make 18.11 ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #80499|0   |1
is obsolete||

--- Comment #98 from Martin Renvoize  ---
Created attachment 81346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81346=edit
Bug 11297: (follow-up) Add html filter to new input field

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #80498|0   |1
is obsolete||

--- Comment #97 from Martin Renvoize  ---
Created attachment 81345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81345=edit
Bug 11297: Modify Z3950server schema file

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81342|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #80496|0   |1
is obsolete||

--- Comment #95 from Martin Renvoize  ---
Created attachment 81343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81343=edit
Bug 11297: Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #80497|0   |1
is obsolete||

--- Comment #96 from Martin Renvoize  ---
Created attachment 81344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81344=edit
Bug 11297: Add atomicupdate patch and modify kohastructure.sql

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81328|0   |1
is obsolete||

--- Comment #94 from Martin Renvoize  ---
Created attachment 81342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81342=edit
Bug 11297: (QA follow-up) Make the database update script idempotent

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #93 from Charles Farmer  ---
Removed the SQL script and based the new perl atomic update on skeleton.perl
instead.

Hope this came fast enough for 18.11 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #92 from Charles Farmer  ---
Created attachment 81328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81328=edit
Bug 11297: (QA follow-up) Make the database update script idempotent

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Failed QA

--- Comment #91 from Nick Clemens  ---
Please make the database update idempotent and use skeleton.perl as a base so
you can check if the column exists first - example:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80478=diff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Passed QA

--- Comment #90 from Martin Renvoize  ---
I must admit, this isn't an area of the codebase I have deep dived into for a
long time.. but, the code does look sound, doesn't appear to cause any
regressions I could see and passes the qa scripts.

Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #80372|0   |1
is obsolete||

--- Comment #89 from Martin Renvoize  ---
Created attachment 80499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80499=edit
Bug 11297: (follow-up) Add html filter to new input field

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #78295|0   |1
is obsolete||

--- Comment #87 from Martin Renvoize  ---
Created attachment 80497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80497=edit
Bug 11297: Add atomicupdate patch and modify kohastructure.sql

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #78296|0   |1
is obsolete||

--- Comment #88 from Martin Renvoize  ---
Created attachment 80498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80498=edit
Bug 11297: Modify Z3950server schema file

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #78294|0   |1
is obsolete||

--- Comment #86 from Martin Renvoize  ---
Created attachment 80496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80496=edit
Bug 11297: Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #85 from Katrin Fischer  ---
i had missed one missing filter in my follow-up. As I signed off... can someone
else QA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78297|0   |1
is obsolete||

--- Comment #84 from Katrin Fischer  ---
Created attachment 80372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80372=edit
Bug 11297: (follow-up) Add html filter to new input field

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-09-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77723|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-09-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77721|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-09-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #77722|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #83 from Katrin Fischer  ---
[Koha] Course reserves widget

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #82 from Katrin Fischer  ---
Created attachment 78297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78297=edit
Bug 11297: (follow-up) Add html filter to new input field

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #79 from Katrin Fischer  ---
Created attachment 78294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78294=edit
Bug 11297: Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #81 from Katrin Fischer  ---
Created attachment 78296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78296=edit
Bug 11297: Modify Z3950server schema file

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #80 from Katrin Fischer  ---
Created attachment 78295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78295=edit
Bug 11297: Add atomicupdate patch and modify kohastructure.sql

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #77720|0   |1
is obsolete||

--- Comment #78 from Charles Farmer  ---
Created attachment 77723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77723=edit
Bug 11297 - Modify Z3950server schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #77718|0   |1
is obsolete||

--- Comment #76 from Charles Farmer  ---
Created attachment 77721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77721=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #77719|0   |1
is obsolete||

--- Comment #77 from Charles Farmer  ---
Created attachment 77722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77722=edit
Bug 11297 - Add atomicupdate patch and modify kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #75 from Charles Farmer  ---
All we changed inside the JS was a datatable sort, but the whole JS got
accidentally bundled inside one the previous patches when the JS code was moved
at the bottom of the page.

I went ahead and reread every last patches we submitted to make sure to carry
only what was necessary. Back to "Needs Signoff"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #72063|0   |1
is obsolete||

--- Comment #74 from Charles Farmer  ---
Created attachment 77720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77720=edit
Bug 11297 - Modify Z3950server schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #72062|0   |1
is obsolete||

--- Comment #73 from Charles Farmer  ---
Created attachment 77719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77719=edit
Bug 11297 - Add atomicupdate patch and modify kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #72061|0   |1
is obsolete||

--- Comment #72 from Charles Farmer  ---
Created attachment 77718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77718=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #71 from Charles Farmer  ---
I'll fail it for now, just to explicitly show that this shouldn't be tested
as-is.

The patch already had to be rebased anyway because of bug 19436. The
modification you're pointing at shouldn't take too long.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #70 from Katrin Fischer  ---
Comment on attachment 72061
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72061
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Review of attachment 72061:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11297=72061)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt
@@ +28,5 @@
> +$("#syntax").val('[% server.syntax %]');
> +$("#encoding").val('[% server.encoding %]');
> +$("#recordtype").val('[% server.recordtype %]');
> +[% END %]
> +// Disable recordtype (and default to bib) for non-Z3950 servers 
> until auth is supported

Noticed this comment here earlier: bug 19436 has now been pushed, so it might
need to be adapted now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-08-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

   Assignee|bouzid.ferg...@inlibro.com  |charles.far...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-04-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #69 from David Cook  ---
I was just thinking about
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18202 and how it
really relates to this...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-04-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18202

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19608

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #68 from Marcel de Rooy  ---
(In reply to Brendan Gallagher from comment #67)
> Tried it out - whenever I click on the Modify Button - the pop_up window is
> complete blank.  I don't see any error messages so I can't be more helpful.

Caused by 19608 and fixed by last followup on 19436

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #67 from Brendan Gallagher  ---
Tried it out - whenever I click on the Modify Button - the pop_up window is
complete blank.  I don't see any error messages so I can't be more helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-03-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Maksim Sen  changed:

   What|Removed |Added

 Blocks||11361


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361
[Bug 11361] Add a Z39.50 search page in the OPAC to let members search for
records on remote Koha instances.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #66 from Charles Farmer  ---
Split in three patches for easier maintainability.

Since this patch is an amalgam of code and QA fixes that not everybody tested,
I went ahead and removed the signoffs from the original patch.

Back to 'Needs signoff'. Should apply cleanly on master, and pass qa -c 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #71994|0   |1
is obsolete||

--- Comment #65 from Charles Farmer  ---
Created attachment 72063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72063=edit
Bug 11297 - Modify Z3950server schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #71993|0   |1
is obsolete||

--- Comment #64 from Charles Farmer  ---
Created attachment 72062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72062=edit
Bug 11297 - Add atomicupdate patch and modify kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #71992|0   |1
is obsolete||

--- Comment #63 from Charles Farmer  ---
Created attachment 72061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72061=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #62 from Jonathan Druart  
---
Splitting  correctly into different patches is more helpful for the author than
testers :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #61 from Charles Farmer  ---
If it'll make everyone's life easier, I'll split this development appropriately
in the coming days.

Marking 'failed QA', so nobody touches it in the meantime.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #60 from Jonathan Druart  
---
(In reply to Charles Farmer from comment #59)
> Freshly rebased.
> 
> To facilitate future git apply, Z3950Server.pm was regenerated. Field
> `attributes` now sits under `sru_fields` and `add_xslt` with longtext,
> instead of the previous mediumtext that conflicted with the master's version
> of the Schema.

That is why it is suggested to add 1 patch for atomic update/kohastructure and
1 patch for the DBIC schema changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #59 from Charles Farmer  ---
Freshly rebased.

To facilitate future git apply, Z3950Server.pm was regenerated. Field
`attributes` now sits under `sru_fields` and `add_xslt` with longtext, instead
of the previous mediumtext that conflicted with the master's version of the
Schema.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70195|0   |1
is obsolete||

--- Comment #57 from Charles Farmer  ---
Created attachment 71993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71993=edit
Bug 11297: QA follow-up - Some fixes

- Makes Attributes only show up when adding a new Z39.50 server,
  not for SRU
- Fixes typo in db documentation
- Fixes sorting of table columns

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70196|0   |1
is obsolete||

--- Comment #58 from Charles Farmer  ---
Created attachment 71994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71994=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2018-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70194|0   |1
is obsolete||

--- Comment #56 from Charles Farmer  ---
Created attachment 71992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71992=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

modified:   C4/Breeding.pm
modified:   Koha/Schema/Result/Z3950server.pm
modified:   admin/z3950servers.pl
new file:  
installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql
modified:   installer/data/mysql/kohastructure.sql
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

New sign-off, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #55 from Charles Farmer  ---
Some rebasing on the new master was necessary.

Submitted a third patch to follow-up on Marcel's observation.

Had to obsolete the [SIGNED-OFF] patches, but didn't have the stomach to remove
the sign off from the commit messages themselves. Patch back at needs sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70193|0   |1
is obsolete||

--- Comment #54 from Charles Farmer  ---
Created attachment 70196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70196=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70192|0   |1
is obsolete||

--- Comment #53 from Charles Farmer  ---
Created attachment 70195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70195=edit
Bug 11297: QA follow-up - Some fixes

- Makes Attributes only show up when adding a new Z39.50 server,
  not for SRU
- Fixes typo in db documentation
- Fixes sorting of table columns

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #62938|0   |1
is obsolete||
  Attachment #62939|0   |1
is obsolete||
  Attachment #70191|0   |1
is obsolete||

--- Comment #52 from Charles Farmer  ---
Created attachment 70194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70194=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

modified:   C4/Breeding.pm
modified:   Koha/Schema/Result/Z3950server.pm
modified:   admin/z3950servers.pl
new file:  
installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql
modified:   installer/data/mysql/kohastructure.sql
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

New sign-off, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

  Attachment #70190|0   |1
is obsolete||

--- Comment #51 from Charles Farmer  ---
Created attachment 70193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70193=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #50 from Charles Farmer  ---
Created attachment 70192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70192=edit
Bug 11297: QA follow-up - Some fixes

- Makes Attributes only show up when adding a new Z39.50 server,
  not for SRU
- Fixes typo in db documentation
- Fixes sorting of table columns

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #49 from Charles Farmer  ---
Created attachment 70191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70191=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
@attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

modified:   C4/Breeding.pm
modified:   Koha/Schema/Result/Z3950server.pm
modified:   admin/z3950servers.pl
new file:  
installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql
modified:   installer/data/mysql/kohastructure.sql
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

New sign-off, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #48 from Charles Farmer  ---
Created attachment 70190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70190=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-09-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-08-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #47 from Marcel de Rooy  ---
Please look at the changed code: 

 my ( $zquery, $squery ) = _build_query( $pars );
 [...]
 foreach my $server ( @servers ) {
if(my $attributes = $server->{attributes}){
$zquery = "$attributes $zquery";
}
$oConnection[$s] = _create_connection( $server );
$oResult[$s] =
$server->{servertype} eq 'zed'?
$oConnection[$s]->search_pqf( $zquery ):
$oConnection[$s]->search(new ZOOM::Query::CQL(
_translate_query( $server, $squery )));
$s++;
}

After we build zquery, you start prefixing it each time with more server
attributes. So the last server will get them all. Wrong !
Probably this was tested with one server at a time. But it might fail for a
search on multiple servers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-08-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #46 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

2017-05-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #45 from Katrin Fischer  ---
Leaving final decisions about unit tests to QA team.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 157 matches

Mail list logo