[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #11 from Fridolin SOMERS --- There was no pb backporting this bug. I've just waited a bit because of previous string freeze. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolyn.som...@biblibre.co ||m --- Comment #10 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #9 from Katrin Fischer --- Hi Dan, as this is marked as bug (vs. enhancement or new feature) it is likely to be backported to earlier versions, but it's up to the RMaint to make the decision. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #8 from Dan Scott --- As this bug addresses regressions from the prior default theme to the new default theme in 3.14, will the patch also be backported to 3.14? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Jonathan Druart changed: What|Removed |Added Attachment #25314|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 25376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25376&action=edit Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart diff -w bootstrap/en/xslt/XXX prog/en/xslt/XXX returns no difference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Katrin Fischer changed: What|Removed |Added CC||d...@coffeecode.net --- Comment #5 from Katrin Fischer --- *** Bug 11758 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Chris Cormack changed: What|Removed |Added Attachment #23972|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 25314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25314&action=edit Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- (In reply to Galen Charlton from comment #2) > I think it would be reasonable to consider making the OPAC XSLT stylesheets > not be specific to a particular theme, but instead be shared by all of them. > Even if that's the final decision, I think it would be a good idea for this > patch to be reviewed and pushed, as having the XSLT be identical in the two > major themes prior to moving it will make it easier to validate the > consolidation. +1 Personally, I don't see a need to duplicate XSLTs across the different themes. I think it just adds more chance of error. In theory, someone might want to tie an XSLT to a theme, so that different themes show different data, but I don't see the purpose of that, since we can already specify different XSLTs in the system preferences. Reduce the boilerplate, me thinks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #2 from Galen Charlton --- I think it would be reasonable to consider making the OPAC XSLT stylesheets not be specific to a particular theme, but instead be shared by all of them. Even if that's the final decision, I think it would be a good idea for this patch to be reviewed and pushed, as having the XSLT be identical in the two major themes prior to moving it will make it easier to validate the consolidation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Galen Charlton changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 --- Comment #1 from Galen Charlton --- Created attachment 23972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23972&action=edit Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com Version|3.14|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
