[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Nick Clemens changed: What|Removed |Added Blocks||22553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 [Bug 22553] Unchecking a subpermission does not uncheck the top level permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED CC||martin.renvoize@ptfs-europe ||.com Resolution|--- |FIXED --- Comment #40 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #39 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #38 from Josef Moravec --- Rebased, conflict with bug 15774, which added new permission manage_additional_field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #36 from Josef Moravec --- Created attachment 86439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86439&action=edit Bug 11375: (QA follow-up) Fix typo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #37 from Josef Moravec --- Created attachment 86440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86440&action=edit Bug 11375: (QA follow-up) Remove some more treeview occurences Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Josef Moravec changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #35 from Josef Moravec --- Created attachment 86438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86438&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. Signed-off-by: Maryse Simard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Josef Moravec changed: What|Removed |Added Attachment #85622|0 |1 is obsolete|| Attachment #85623|0 |1 is obsolete|| Attachment #85624|0 |1 is obsolete|| Attachment #85625|0 |1 is obsolete|| --- Comment #34 from Josef Moravec --- Created attachment 86437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86437&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. Save and cancel buttons are now in a floating toolbar. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that the toolbar with Save and Cancel floats when scrolling. - Test that changing and saving permissions works correctly. Signed-off-by: Maryse Simard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Josef Moravec changed: What|Removed |Added Attachment #85576|0 |1 is obsolete|| Attachment #85577|0 |1 is obsolete|| --- Comment #30 from Josef Moravec --- Created attachment 85622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85622&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. Save and cancel buttons are now in a floating toolbar. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that the toolbar with Save and Cancel floats when scrolling. - Test that changing and saving permissions works correctly. Signed-off-by: Maryse Simard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #31 from Josef Moravec --- Created attachment 85623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85623&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. Signed-off-by: Maryse Simard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #33 from Josef Moravec --- Created attachment 85625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85625&action=edit Bug 11375: (QA follow-up) Remove some more treeview occurences Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #32 from Josef Moravec --- Created attachment 85624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85624&action=edit Bug 11375: (QA follow-up) Fix typo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #29 from Maryse Simard --- It works well and looks good! But there's one thing that I feel is missing. When a permission is checked and you uncheck one or more of it's subpermissions, the parent doesn't uncheck. That is current behavior and can be useful if you only want to have one subpermissions unchecked among a dozen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Maryse Simard changed: What|Removed |Added Attachment #85352|0 |1 is obsolete|| --- Comment #28 from Maryse Simard --- Created attachment 85577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85577&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Maryse Simard changed: What|Removed |Added Attachment #85351|0 |1 is obsolete|| --- Comment #27 from Maryse Simard --- Created attachment 85576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85576&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. Save and cancel buttons are now in a floating toolbar. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that the toolbar with Save and Cancel floats when scrolling. - Test that changing and saving permissions works correctly. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #26 from Owen Leonard --- Created attachment 85352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85352&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Attachment #84701|0 |1 is obsolete|| Attachment #84702|0 |1 is obsolete|| --- Comment #25 from Owen Leonard --- Created attachment 85351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85351&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. Save and cancel buttons are now in a floating toolbar. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that the toolbar with Save and Cancel floats when scrolling. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||maryse.sim...@inlibro.com --- Comment #24 from Maryse Simard --- Patch doesn't apply Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11375: Improve patrons permissions display Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Removing koha-tmpl/intranet-tmpl/prog/css/treeview/jquery.treeview.css Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-red.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-red-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-gray.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-gray-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-famfamfam.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-famfamfam-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-default.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-default-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-black.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-black-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/plus.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/minus.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/folder.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/folder-closed.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/file.gif Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Removing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.treeview.pack.js error: Failed to merge in the changes. Patch failed at 0001 Bug 11375: Improve patrons permissions display The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11375-Improve-patrons-permissions-display-P1z7Qv.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Bug 11375 depends on bug 21751, which changed state. Bug 21751 Summary: fixFloat toolbar not displaying properly in Chrome https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #23 from Owen Leonard --- Created attachment 84702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84702&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #22 from Owen Leonard --- Created attachment 84701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84701&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. Save and cancel buttons are now in a floating toolbar. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that the toolbar with Save and Cancel floats when scrolling. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Attachment #84140|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Attachment #84700|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Attachment #84143|0 |1 is obsolete|| --- Comment #21 from Owen Leonard --- Created attachment 84700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84700&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #20 from Katrin Fischer --- Tried to apply on top of patches for 21751, but got a conflict: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11375: Improve patrons permissions display error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). error: could not build fake ancestor Patch failed at 0001 Bug 11375: Improve patrons permissions display The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11375-Improve-patrons-permissions-display-jTsU_R.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #19 from Katrin Fischer --- Passed QA on depenency, unlocking this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Bug 11375 depends on bug 21964, which changed state. Bug 21964 Summary: Switch two-column templates to Bootstrap grid: Patrons part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #18 from Owen Leonard --- Created attachment 84143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84143&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Attachment #83296|0 |1 is obsolete|| --- Comment #17 from Owen Leonard --- Created attachment 84140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84140&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. Save and cancel buttons are now in a floating toolbar. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that the toolbar with Save and Cancel floats when scrolling. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Depends on||21964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 [Bug 21964] Switch two-column templates to Bootstrap grid: Patrons part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Claire Gravely changed: What|Removed |Added Attachment #82932|0 |1 is obsolete|| --- Comment #16 from Claire Gravely --- Created attachment 83296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83296&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. To test, apply the patch and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that changing and saving permissions works correctly. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Depends on|21964 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 [Bug 21964] Switch two-column templates to Bootstrap grid: Patrons part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Attachment #77486|0 |1 is obsolete|| --- Comment #15 from Owen Leonard --- Created attachment 82932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82932&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. To test, apply the patch and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Depends on||21751, 21964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 [Bug 21751] fixFloat toolbar not displaying properly in Chrome https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 [Bug 21964] Switch two-column templates to Bootstrap grid: Patrons part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com --- Comment #14 from Cab Vinton --- All works as expected. A couple minor suggestions to consider: 1./ Add Save/ Cancel buttons to the top of the screen (to avoid having to scroll to the bottom of the screen). 2./ Add Show/ Hide all details buttons (for easier navigation) Very nice work! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #13 from sandbo...@biblibre.com --- Created attachment 77486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77486&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. To test, apply the patch and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that changing and saving permissions works correctly. Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 sandbo...@biblibre.com changed: What|Removed |Added Attachment #77333|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Failed QA |Signed Off --- Comment #12 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20813 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added Attachment #75967|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 77333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77333&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. To test, apply the patch and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #10 from Katrin Fischer --- Hi Owen, I've rebased the patch to add the new permissions, hope I got everything right. Some things I notice: 1) Currently, when you click on a sub-permission, the top-level permission checkbox gets unchecked. With the new patches this no longer happens, which I think could lead to errors. Could we restore this behaviour? 2) Ok... searched up and down, otherwise this appears to work great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Version|unspecified |master Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #9 from Owen Leonard --- Created attachment 75967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75967&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. To test, apply the patch and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that changing and saving permissions works correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #8 from Owen Leonard --- (In reply to Katrin Fischer from comment #7) > Hi Owen, are you still working on this? Whoops, I missed this question when you first asked. I still have an up-to-date branch with this. I'm thinking about trying to get it in with Bug 20813 (unless that bug proves to be controversial?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #7 from Katrin Fischer --- Hi Owen, are you still working on this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #6 from Katrin Fischer --- I like it! Only thing maybe is that I like the top level permission clickable, as that seems a bit faster than the 'show details' link when you have to enter a lot of accounts as we usually do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer changed: What|Removed |Added Summary|Patron permission names are |Improve patrons permissions |untranslatable |display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/