[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #162 from Tomás Cohen Arazi  ---
Created attachment 44599
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44599=edit
Bug 11431: (QA followup) remove diags

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #151 from Kyle M Hall  ---
Created attachment 44400
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44400=edit
Bug 11431 [QA Followup] - Unit Tests

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #158 from Kyle M Hall  ---
Created attachment 44409
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44409=edit
Bug 11431 [QA Followup] - Add ability to edit audio alerts

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #156 from Kyle M Hall  ---
Created attachment 44407
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44407=edit
Bug 11431 [QA Followup] - Always allow audio alerts for audio alerts editor
page

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #155 from Kyle M Hall  ---
Created attachment 44405
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44405=edit
Bug 11431 [QA Followup] - Fix alter precedences on delete

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #149 from Kyle M Hall  ---
Created attachment 44398
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44398=edit
Bug 11431 - Update UsageStats.pm

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #154 from Kyle M Hall  ---
Created attachment 44404
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44404=edit
Bug 11431 [QA Followup] - Hard code list of sounds for security

The sounds directory is no longer available for listing for security.
It is better and safer to hard code the list of sounds.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #152 from Kyle M Hall  ---
Created attachment 44401
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44401=edit
Bug 11431 [QA Followup] - Simplify audio_alert_id to just id

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #157 from Kyle M Hall  ---
Created attachment 44408
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44408=edit
Bug 11431 [QA Followup] - Update help

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #159 from Kyle M Hall  ---
Created attachment 44411
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44411=edit
Bug 11431: QA follow-up: Typo in help file / variable name

Fixes the variable name to avoid a double-up that made it
impossible to turn off the sounds in general. If AudioAlerts
are turned off, they will only work on the audio administration
page now so you can set up and test the different sounds there.

Also fixes a little typo in the help file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #160 from Kyle M Hall  ---
Created attachment 44412
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44412=edit
Bug 11431 [QA Followup] - Make audio alerts sql top level

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43887|0   |1
is obsolete||
  Attachment #43888|0   |1
is obsolete||
  Attachment #43889|0   |1
is obsolete||
  Attachment #43890|0   |1
is obsolete||
  Attachment #43891|0   |1
is obsolete||
  Attachment #43892|0   |1
is obsolete||
  Attachment #43893|0   |1
is obsolete||
  Attachment #43894|0   |1
is obsolete||
  Attachment #43895|0   |1
is obsolete||
  Attachment #43896|0   |1
is obsolete||
  Attachment #43897|0   |1
is obsolete||
  Attachment #43898|0   |1
is obsolete||
  Attachment #43899|0   |1
is obsolete||
  Attachment #43900|0   |1
is obsolete||
  Attachment #43901|0   |1
is obsolete||
  Attachment #43902|0   |1
is obsolete||
  Attachment #43903|0   |1
is obsolete||
  Attachment #44391|0   |1
is obsolete||

--- Comment #143 from Kyle M Hall  ---
Created attachment 44392
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44392=edit
Bug 11431 [1] - Update database

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #153 from Kyle M Hall  ---
Created attachment 44402
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44402=edit
Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #142 from Kyle M Hall  ---
Created attachment 44391
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44391=edit
Bug 11431 [QA Followup] - Make audio alerts sql top level

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #144 from Kyle M Hall  ---
Created attachment 44393
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44393=edit
Bug 11431 [2] - Add audio alerts to installer

http://bugs.koha-community.org/show_bug.cgi?id=11431
Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #150 from Kyle M Hall  ---
Created attachment 44399
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44399=edit
Bug 11431 [QA Followup] - Fix js error

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #145 from Kyle M Hall  ---
Created attachment 44394
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44394=edit
Bug 11431 [3] - Update schema

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #146 from Kyle M Hall  ---
Created attachment 44395
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44395=edit
Bug 11431 [4] - Add additional sound options

This patch set replaces and extends Koha's current sound options.
This is implemented be removing the existing sound system, and
re-engineering using a table of selector/sound combinations such that
the highest precedence selector that is found in the DOM will trigger
and audio alert. The existing audio behaviors are implemented as a set
of default audio alerts.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable the AudioAlerts system preference
4) Test existing sounds
5) Enter the new alerts editor in the admin section
6) Add a new audo alert with the following selector:
"body:contains('Check in message')",
   choose any sound alert you wish, make sure it's not one of the 3
   sounds already used! Make this selector precedence 1
4) Browse to the checkins page, you should hear the default sound
5) Attempt to return an invalid barcode, you should hear your custom sound!

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #148 from Kyle M Hall  ---
Created attachment 44397
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44397=edit
Bug 11431 [QA Followup] - Fix POD

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #147 from Kyle M Hall  ---
Created attachment 44396
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44396=edit
Bug 11431 [QA Followup] - Allow https in sound URLs

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #161 from Tomás Cohen Arazi  ---
Patches pushed to master.

Great job Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #137 from Katrin Fischer  ---
Created attachment 43899
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43899=edit
[PASSED QA] Bug 11431 [QA Followup] - Fix alter precedences on delete

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #139 from Katrin Fischer  ---
Created attachment 43901
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43901=edit
[PASSED QA] Bug 11431 [QA Followup] - Update help

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #140 from Katrin Fischer  ---
Created attachment 43902
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43902=edit
[PASSED QA] Bug 11431 [QA Followup] - Add ability to edit audio alerts

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #138 from Katrin Fischer  ---
Created attachment 43900
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43900=edit
[PASSED QA] Bug 11431 [QA Followup] - Always allow audio alerts for audio
alerts editor page

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #141 from Katrin Fischer  ---
Created attachment 43903
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43903=edit
Bug 11431: QA follow-up: Typo in help file / variable name

Fixes the variable name to avoid a double-up that made it
impossible to turn off the sounds in general. If AudioAlerts
are turned off, they will only work on the audio administration
page now so you can set up and test the different sounds there.

Also fixes a little typo in the help file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #125 from Katrin Fischer  ---
Created attachment 43887
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43887=edit
[PASSED QA] Bug 11431 [1] - Update database

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #127 from Katrin Fischer  ---
Created attachment 43889
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43889=edit
[PASSED QA] Bug 11431 [3] - Update schema

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #126 from Katrin Fischer  ---
Created attachment 43888
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43888=edit
[PASSED QA] Bug 11431 [2] - Add audio alerts to installer

http://bugs.koha-community.org/show_bug.cgi?id=11431
Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #128 from Katrin Fischer  ---
Created attachment 43890
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43890=edit
[PASSED QA] Bug 11431 [4] - Add additional sound options

This patch set replaces and extends Koha's current sound options.
This is implemented be removing the existing sound system, and
re-engineering using a table of selector/sound combinations such that
the highest precedence selector that is found in the DOM will trigger
and audio alert. The existing audio behaviors are implemented as a set
of default audio alerts.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable the AudioAlerts system preference
4) Test existing sounds
5) Enter the new alerts editor in the admin section
6) Add a new audo alert with the following selector:
"body:contains('Check in message')",
   choose any sound alert you wish, make sure it's not one of the 3
   sounds already used! Make this selector precedence 1
4) Browse to the checkins page, you should hear the default sound
5) Attempt to return an invalid barcode, you should hear your custom sound!

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #136 from Katrin Fischer  ---
Created attachment 43898
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43898=edit
[PASSED QA] Bug 11431 [QA Followup] - Hard code list of sounds for security

The sounds directory is no longer available for listing for security.
It is better and safer to hard code the list of sounds.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #135 from Katrin Fischer  ---
Created attachment 43897
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43897=edit
[PASSED QA] Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #132 from Katrin Fischer  ---
Created attachment 43894
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43894=edit
[PASSED QA] Bug 11431 [QA Followup] - Fix js error

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #131 from Katrin Fischer  ---
Created attachment 43893
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43893=edit
[PASSED QA] Bug 11431 - Update UsageStats.pm

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #134 from Katrin Fischer  ---
Created attachment 43896
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43896=edit
[PASSED QA] Bug 11431 [QA Followup] - Simplify audio_alert_id to just id

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #133 from Katrin Fischer  ---
Created attachment 43895
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43895=edit
[PASSED QA] Bug 11431 [QA Followup] - Unit Tests

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #129 from Katrin Fischer  ---
Created attachment 43891
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43891=edit
[PASSED QA] Bug 11431 [QA Followup] - Allow https in sound URLs

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #130 from Katrin Fischer  ---
Created attachment 43892
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43892=edit
[PASSED QA] Bug 11431 [QA Followup] - Fix POD

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43759|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43754|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43760|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43758|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43757|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43761|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43755|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43753|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43756|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43763|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43764|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43762|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43817|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43765|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43824|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43825|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #118 from Kyle M Hall  ---
Created attachment 43817
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43817=edit
Bug 11431 [QA Followup] - Always allow audio alerts for audio alerts editor
page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #124 from Kyle M Hall  ---
Created attachment 43825
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43825=edit
Bug 11431 [QA Followup] - Add ability to edit audio alerts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43822|0   |1
is obsolete||
  Attachment #43823|0   |1
is obsolete||

--- Comment #123 from Kyle M Hall  ---
Created attachment 43824
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43824=edit
Bug 11431 [QA Followup] - Update help

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43820|0   |1
is obsolete||
  Attachment #43821|0   |1
is obsolete||

--- Comment #121 from Kyle M Hall  ---
Created attachment 43822
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43822=edit
Bug 11431 [QA Followup] - Add ability to edit audio alerts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #119 from Kyle M Hall  ---
Created attachment 43820
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43820=edit
Bug 11431 [QA Followup] - Add ability to edit audio alerts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #120 from Kyle M Hall  ---
Created attachment 43821
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43821=edit
Bug 11431 [QA Followup] - Update help

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #122 from Kyle M Hall  ---
Created attachment 43823
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43823=edit
Bug 11431 [QA Followup] - Update help

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #117 from Katrin Fischer  ---
Hi Kyle,

one small thing: If AudioAlerts is turned off the 'play' button on the
administration page won't work and save the entry instead. That was quite
confusing. I think independent of the AudioAlerts setting, you should be able
to 'preview' the sounds on the admin page. The second best solution would be to
not display the play button in this case.

Enhancement ideas:
- I'd really really like an option to play the sounds of saved entries for
easier testing and also the option of editing the entries - if you get your
selector wrong, it can be quite annoying to delete and start over.
- Adding an example to the help page would be great. The example on the bug
report is not quite so good, as it relies on the existence of an English string
in a certain place and would be hard to translate, but maybe another example
that is based on a class or id?

Can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #114 from Kyle M Hall  ---
Created attachment 43763
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43763=edit
Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #113 from Kyle M Hall  ---
Created attachment 43762
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43762=edit
Bug 11431 [QA Followup] - Simplify audio_alert_id to just id

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #116 from Kyle M Hall  ---
Created attachment 43765
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43765=edit
Bug 11431 [QA Followup] - Fix alter precedences on delete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #112 from Kyle M Hall  ---
Created attachment 43761
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43761=edit
Bug 11431 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42678|0   |1
is obsolete||
  Attachment #42679|0   |1
is obsolete||
  Attachment #42680|0   |1
is obsolete||
  Attachment #42681|0   |1
is obsolete||
  Attachment #42682|0   |1
is obsolete||
  Attachment #42683|0   |1
is obsolete||
  Attachment #42684|0   |1
is obsolete||
  Attachment #42685|0   |1
is obsolete||
  Attachment #42686|0   |1
is obsolete||
  Attachment #42687|0   |1
is obsolete||
  Attachment #42688|0   |1
is obsolete||
  Attachment #42689|0   |1
is obsolete||
  Attachment #42696|0   |1
is obsolete||

--- Comment #104 from Kyle M Hall  ---
Created attachment 43753
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43753=edit
Bug 11431 [1] - Update database

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #111 from Kyle M Hall  ---
Created attachment 43760
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43760=edit
Bug 11431 [QA Followup] - Fix js error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #115 from Kyle M Hall  ---
Created attachment 43764
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43764=edit
Bug 11431 [QA Followup] - Hard code list of sounds for security

The sounds directory is no longer available for listing for security.
It is better and safer to hard code the list of sounds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #106 from Kyle M Hall  ---
Created attachment 43755
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43755=edit
Bug 11431 [3] - Update schema

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #105 from Kyle M Hall  ---
Created attachment 43754
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43754=edit
Bug 11431 [2] - Add audio alerts to installer

http://bugs.koha-community.org/show_bug.cgi?id=11431
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #107 from Kyle M Hall  ---
Created attachment 43756
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43756=edit
Bug 11431 [4] - Add additional sound options

This patch set replaces and extends Koha's current sound options.
This is implemented be removing the existing sound system, and
re-engineering using a table of selector/sound combinations such that
the highest precedence selector that is found in the DOM will trigger
and audio alert. The existing audio behaviors are implemented as a set
of default audio alerts.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable the AudioAlerts system preference
4) Test existing sounds
5) Enter the new alerts editor in the admin section
6) Add a new audo alert with the following selector:
"body:contains('Check in message')",
   choose any sound alert you wish, make sure it's not one of the 3
   sounds already used! Make this selector precedence 1
4) Browse to the checkins page, you should hear the default sound
5) Attempt to return an invalid barcode, you should hear your custom sound!

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #108 from Kyle M Hall  ---
Created attachment 43757
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43757=edit
Bug 11431 [QA Followup] - Allow https in sound URLs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #109 from Kyle M Hall  ---
Created attachment 43758
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43758=edit
Bug 11431 [QA Followup] - Fix POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #110 from Kyle M Hall  ---
Created attachment 43759
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43759=edit
Bug 11431 - Update UsageStats.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #103 from Katrin Fischer  ---
Patch doesn't apply - please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #102 from Kyle M Hall  ---
Thanks for catching that! Followup posted!

(In reply to Nick Clemens from comment #100)
> Tested just to confirm my sign off.  Test plan works as expected.
> 
> Minor bug:  If you delete a sound alert, the preferences are not
> automatically renumbered and you get an error if you try to move another
> alert into the empty slot.
> 
> To recreate:
> 1 - Add an alert (example in test plan works fine)
> 2 - Move it to priority 2
> 3 - Delete it
> 4 - Remaining alerts are preference 1,3,4
> 5 - Try to move #3 up one slot
> 6 - Receive error: Can't call method "precedence" on an undefined value at
> /home/nick/kohaclone/Koha/AudioAlerts.pm line 96.
> 7 - Back up, move alert number 3 to top (second arrow)
> 8 - Priorities are renumbered correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Kyle M Hall  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #101 from Kyle M Hall  ---
Created attachment 42696
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42696=edit
Bug 11431 [QA Followup] - Fix alter precedences on delete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #97 from Kyle M Hall  ---
Created attachment 42688
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42688=edit
Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #98 from Kyle M Hall  ---
Created attachment 42689
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42689=edit
Bug 11431 [QA Followup] - Hard code list of sounds for security

The sounds directory is no longer available for listing for security.
It is better and safer to hard code the list of sounds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #88 from Kyle M Hall  ---
Created attachment 42679
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42679=edit
Bug 11431 [2] - Add audio alerts to installer

http://bugs.koha-community.org/show_bug.cgi?id=11431
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #40726|0   |1
is obsolete||
  Attachment #40727|0   |1
is obsolete||
  Attachment #40728|0   |1
is obsolete||
  Attachment #40729|0   |1
is obsolete||
  Attachment #40730|0   |1
is obsolete||
  Attachment #40731|0   |1
is obsolete||
  Attachment #40732|0   |1
is obsolete||
  Attachment #41634|0   |1
is obsolete||
  Attachment #41661|0   |1
is obsolete||
  Attachment #41662|0   |1
is obsolete||

--- Comment #87 from Kyle M Hall  ---
Created attachment 42678
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42678=edit
Bug 11431 [1] - Update database

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #89 from Kyle M Hall  ---
Created attachment 42680
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42680=edit
Bug 11431 [3] - Update schema

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #90 from Kyle M Hall  ---
Created attachment 42681
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42681=edit
Bug 11431 [4] - Add additional sound options

This patch set replaces and extends Koha's current sound options.
This is implemented be removing the existing sound system, and
re-engineering using a table of selector/sound combinations such that
the highest precedence selector that is found in the DOM will trigger
and audio alert. The existing audio behaviors are implemented as a set
of default audio alerts.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable the AudioAlerts system preference
4) Test existing sounds
5) Enter the new alerts editor in the admin section
6) Add a new audo alert with the following selector:
"body:contains('Check in message')",
   choose any sound alert you wish, make sure it's not one of the 3
   sounds already used! Make this selector precedence 1
4) Browse to the checkins page, you should hear the default sound
5) Attempt to return an invalid barcode, you should hear your custom sound!

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #93 from Kyle M Hall  ---
Created attachment 42684
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42684=edit
Bug 11431 - Update UsageStats.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #95 from Kyle M Hall  ---
Created attachment 42686
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42686=edit
Bug 11431 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #99 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #86)
> CONFLICT (content): Merge conflict in
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
> CONFLICT (content): Merge conflict in Koha/Template/Plugin/Koha.pm

Fixed!

> (In reply to Jonathan Druart from comment #81)
> > 2/ I really would like to see Koha::Template::Plugin::Koha::AudioAlerts
> > moved somewhere else
> 
> Still needs an answer.
> Are not you afraid that this plugin become a holdall?

I understand what you mean. Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #96 from Kyle M Hall  ---
Created attachment 42687
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42687=edit
Bug 11431 [QA Followup] - Simplify audio_alert_id to just id

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #92 from Kyle M Hall  ---
Created attachment 42683
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42683=edit
Bug 11431 [QA Followup] - Fix POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #94 from Kyle M Hall  ---
Created attachment 42685
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42685=edit
Bug 11431 [QA Followup] - Fix js error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #91 from Kyle M Hall  ---
Created attachment 42682
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42682=edit
Bug 11431 [QA Followup] - Allow https in sound URLs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #100 from Nick Clemens  ---
Tested just to confirm my sign off.  Test plan works as expected.

Minor bug:  If you delete a sound alert, the preferences are not automatically
renumbered and you get an error if you try to move another alert into the empty
slot.

To recreate:
1 - Add an alert (example in test plan works fine)
2 - Move it to priority 2
3 - Delete it
4 - Remaining alerts are preference 1,3,4
5 - Try to move #3 up one slot
6 - Receive error: Can't call method "precedence" on an undefined value at
/home/nick/kohaclone/Koha/AudioAlerts.pm line 96.
7 - Back up, move alert number 3 to top (second arrow)
8 - Priorities are renumbered correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #86 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
CONFLICT (content): Merge conflict in Koha/Template/Plugin/Koha.pm


(In reply to Jonathan Druart from comment #81)
> 2/ I really would like to see Koha::Template::Plugin::Koha::AudioAlerts
> moved somewhere else

Still needs an answer.
Are not you afraid that this plugin become a holdall?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #83 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41661
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41661action=edit
Bug 11431 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/