[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #7 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Galen Charlton from comment #5) Pushed to master, although as you can probably see from the comment I made in the commit message, I would suggest that it is a good idea to not lose perspective on the difference between a minor convention meant to reduce the chance of merge conflicts as opposed to an actual error. Galen, Yes I completely agree, it is not an error. The (small) problem occurs when the file is already badly sorted. In this case, the qa script doesn't catch a patch introducing a line in the wrong place. This means if a pref is added at the end of the file (as we previously did), there is no warning. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #25392|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 25533 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25533action=edit Bug 11562: sysprefs.sql is not correctly sorted. The QA tools does not manage to catch error sorting on the sysprefs.sql file if it is already bad sorted. This patch tidies up the sysprefs file. TEST PLAN - 0) Back up your system preferences table. 1) check out master 2) Use your koha database, and then: DELETE FROM systempreferences; SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql 3) suspend your mysql client and type something similar to: mysql -u root -p -e 'USE kohadata;SELECT * from systempreferences ORDER BY Variable;' ~/master_sysprefs 4) apply the patch 5) foreground your mysql client, and then: DELETE FROM systempreferences; SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql 6) suspend your mysql client and type something similar to: mysql -u root -p -e 'USE kohadata;SELECT * from systempreferences ORDER BY Variable;' ~/11562_sysprefs 7) foreground your mysql client and quit 8) Take a diff, they should be identical diff ~/master_sysprefs ~/11562_sysprefs NOTE: You can't use your own system preferences values, because upgrades and changed values would require a lot of time to compare the results. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton gmcha...@gmail.com --- Pushed to master, although as you can probably see from the comment I made in the commit message, I would suggest that it is a good idea to not lose perspective on the difference between a minor convention meant to reduce the chance of merge conflicts as opposed to an actual error. Thanks, Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #24409|0 |1 is obsolete|| --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Created attachment 25392 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25392action=edit [SIGNED OFF] Bug 11562: sysprefs.sql is not correctly sorted. The QA tools does not manage to catch error sorting on the sysprefs.sql file if it is already bad sorted. This patch tidies up the sysprefs file. TEST PLAN - 0) Back up your system preferences table. 1) check out master 2) Use your koha database, and then: DELETE FROM systempreferences; SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql 3) suspend your mysql client and type something similar to: mysql -u root -p -e 'USE kohadata;SELECT * from systempreferences ORDER BY Variable;' ~/master_sysprefs 4) apply the patch 5) foreground your mysql client, and then: DELETE FROM systempreferences; SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql 6) suspend your mysql client and type something similar to: mysql -u root -p -e 'USE kohadata;SELECT * from systempreferences ORDER BY Variable;' ~/11562_sysprefs 7) foreground your mysql client and quit 8) Take a diff, they should be identical diff ~/master_sysprefs ~/11562_sysprefs NOTE: You can't use your own system preferences values, because upgrades and changed values would require a lot of time to compare the results. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24409 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24409action=edit Bug 11562: sysprefs.sql is not correctly sorted. The QA tools does not manage to catch error sorting on the sysprefs.sql file if it is already bad sorted. This patch tidies up the sysprefs file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11562] QA: the sysprefs.sql is not correctly sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- This one needs a quick push. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
