[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org Depends on|12165 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Nick Clemens n...@quecheelibrary.org --- Needs a rebase, and I am unclear on whether to apply just the last three patches, or all 5? I hit conflicts in both scenarios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |wizzy...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #17 from wajasu matted-34...@mypacks.net --- I had originally went to sign off after reading comment4. Then I took a shot at the fix. Comment6 was my attempt to fix it. I also saw afterward that accountlines was being worked on. The fix I did was an attempt to consistently display the descriptions that I could find through the system codebase at that time without resorting to trying to change user data. At least the obsolete patch documented my attempt to centralize a mapping of descriptions for the set of codes I researched. It was to lay a groundwork for future accountlines rewrite or such to know what would need to be handled in schema design. I can barely remember if a messy part was the storage of a code in the description field, which required a string scan. Well it looks like a newer effort is pending signoff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #16 from Owen Leonard oleon...@myacpl.org --- What is the status of this bug? It is just waiting for a signoff on attachment 27824? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|new feature |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- The third patch on this patch set does not apply, and also has some problems. - capitalization, not including OPAC templates. I'd suggest we split this up into some smaller steps. Starting with fixing the rentals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #25715|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Comment on attachment 25715 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25715 Followup Bug-11573-display-derived-account-fines-tab-description Obsoleting here - moving it to another bug later. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on||12165 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27823 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27823action=edit [SIGNED OFF] Bug 11573 - removing title double ups on boraccount.tt To test: 1. Create a bunch of fines (or view your existing fines data) - it should have lost entries, rentals, rental renewals, and regular fines and fine updates. 2. View the fines tab for your borrower with fines 3. without the patch, it will look like the submitted screenshot 4. with the patch, there will be few, if any, doubleups of title This patch may be incomplete - there may be cases that still need work. I'm happy to do followups. Rental fees and rental renewals will not look wholly consistent without the other attached patch, but this one does not require it. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 27824 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27824action=edit Bug 11573: Follow-up: Include changes in OPAC templates Patch adds changes from earlier patches to OPAC prog and bootstrap templates. Patch radds a description for FU - Accrued fine. Removes a stray space before the comma, using some TT magic. To test: - Test like the other patch, display in OPAC prog, OPAC bootstrap, Staff Pay fines tab and Staff Accounts tab should be the same. - No ' , ' should be seen. - FU fines should now display a description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||12166 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Wajasu, I am not sure about your patch, as there are some problems with, would you mind going step by step? We could also check then that the other codes are still in use and have test plans for each. I haven't moved your patch to another bug yet, but happy to do so if you want me to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- 'new feature' is not right for the attached patches - looks more like something between a bug fix and an enh. hm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #6 from wajasu matted-34...@mypacks.net --- Created attachment 25715 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25715action=edit Followup Bug-11573-display-derived-account-fines-tab-description Tested 24485 and 24486 patch ids, but could not signoff so I added a floowup patch. Followup patch 'display-derived-account-fines-tab-description'. After applying patches 24485 and 24486 above, this patch will adjust things so that the fines realated Account and Pay Fines tabs will show a description column that is more concise without the duplicated title problem that this bug attempts to address. The templates have been expanded to handle accounttype codes that I could find mentioned in the existing codebase. In the case of the renewal, where no explicit accounttype code exists as of yet, the template checks for 'enewal' in the accountline.description field and adjusts accordingly. The original code that is building description can be historically preserved (though not shown), and we will just depend on the other columns to formulate a description. A barcode is shown if one exists, alongside the title. The set of accounttype codes handled in the template has been expanded. Unhandled codes will just appear untransformed as it does now. Someone with a long history of fines usage can 'select distinct accounttype from accountlines;' to confirm the set is sufficiently handled in the pay.tt and boraccount.tt templates. The reason for this followup was because the original two patches fixed things by modifying accountlines, but indirectly cause 'Pay fines' tab to have duplicate titles. One could work on the 'enewal' hack, but that would require a new accounttype and testing of other circulation/account/reserve code to consider it in their where clauses. Also, this may put us in a better position to translate the description in a later patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #7 from wajasu matted-34...@mypacks.net --- Account tab lines look like: Rental Renewal ( A heart for God / ) View item Pay Fine tab lines look like: Rental Renewal ( A heart for God / ) With the followup patch. See patch for accounttype transformations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #8 from wajasu matted-34...@mypacks.net --- I think my followup partially fixed bug 11301 (barcode display, but not assession number). It also should have fixed bug 2696, since I show the (Title / barcode) when an item exists for a payment/accountline. If folks want to keep adding fields, we could add a View Item link to the Pay fines tab, just like the Account tab has. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Version|3.12|master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 wajasu matted-34...@mypacks.net changed: What|Removed |Added CC||matted-34...@mypacks.net --- Comment #5 from wajasu matted-34...@mypacks.net --- I generated a rental, and renewal of rental item: 26/02/2014 Rent, Renewal of Rental Item A heart for God / View item A heart for God / 5.00 5.00 Print 26/02/2014 Rent, Rental View item A heart for God / 5.00 5.00 Print then applied patches 26/02/2014 Rent, Renewal of Rental Item A heart for God / View item 5.00 5.00 Print 26/02/2014 Rent, A heart for God / View item 5.00 5.00 Print Overall this patch seems to make the Patron Fines Account tab more succinct not showing the duplicate title info. It also appends the barcode number for Rentals and renewal entries. ---But The Pay Fines tab now has title duplicated in parenthesis, which might need to be taken off, now that its part of the accountlines description from this patch. koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt could have line 129 removed, [% IF line.title %]([% line.title |html_entity %])[% END %] but we need to preserve historical context for the historically generated accountline that may not have a title. We could: a) test to see if the title is already in the description and if not, append it. (but what if the title changes in the item record? does that matter) b) perform a one time database update, appending the title to the accountline description if its not already in there - gotta think about this. -- BIG UPDATE for some follks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz --- I can't sign off on this, can someone outside of catalyst take a look please -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Liz Rea wizzy...@gmail.com changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #1 from Liz Rea wizzy...@gmail.com --- Hi Marjorie, Thanks for your report. As a general note, when taking a screenshot it's useful for us to see the whole page, including the URL, so we know exactly what page you are looking at. Cheers, Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #3 from Liz Rea l...@catalyst.net.nz --- Created attachment 24486 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24486action=edit Bug 11573 - removing title double ups on boraccount.tt To test: 1. Create a bunch of fines (or view your existing fines data) - it should have lost entries, rentals, rental renewals, and regular fines and fine updates. 2. View the fines tab for your borrower with fines 3. without the patch, it will look like the submitted screenshot 4. with the patch, there will be few, if any, doubleups of title This patch may be incomplete - there may be cases that still need work. I'm happy to do followups. Rental fees and rental renewals will not look wholly consistent without the other attached patch, but this one does not require it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #2 from Liz Rea l...@catalyst.net.nz --- Created attachment 24485 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24485action=edit Bug 11573 - Make fine display more consistent for rentals To test: 1. Set up an item type with a rental charge 2. issue an item from that item type 3. Check fines - the rental charge does not show the title of the issued item 4. Renew that item, the renewal charge does show the title of the issued item 5. Apply the patch 6. Repeat steps 1-4, both should show the title of the issued item in the description. This change is proposed in order to get rid of some double ups in the title on the boraccount template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
