[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED
  Component|Circulation |Fines and fees

--- Comment #34 from Katrin Fischer  ---
Not sure if this is a duplicate to bug 21953 - Rental vs. Lost. 

It looks like Rental might still have issues:

C4/Circulation.pm

if ( $charge > 0 ) {
my $description = "Rental";
AddIssuingCharge( $issue, $charge, $description );
}

if ( $accumulate_charge > 0 ) {
my $type_desc = "Renewal of Daily Rental Item " . $biblio->title . "
$item_unblessed->{'barcode'}";
AddIssuingCharge( $issue, $accumulate_charge, $type_desc )
}

And same without Daily.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #33 from Martin Renvoize  ---
This one hasn't received any love for a while and there are new reports (and
patches) in it's place.. I'm going to look at the more recent efforts and see
fi those resolve it.

Marking as duplicate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |DUPLICATE
 Status|Failed QA   |RESOLVED

--- Comment #32 from Martin Renvoize  ---


*** This bug has been marked as a duplicate of bug 21953 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Josef Moravec  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21678

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #31 from Jonathan Druart  
---
Comment on attachment 47289
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47289
[SIGNED-OFF] Bug 11573 - Make fine display more consistent for rentals

Review of attachment 47289:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11573=47289)
-

I am not sure I have understood what is expected.
I get:

Without the patch:
Rental, Rental (my_title_99)Rent0   0   1.00   
1.00

Rental, Renewal of Rental Item my_title_99 my_barcode_992 (my_title_99)
Rent0   0   1.001.00
With the patch:
Rental, my_title_99 my_barcode_992 (my_title_99)Rent   
0   0   1.001.00

Rental, Renewal of Rental Item my_title_99 my_barcode_992 (my_title_99)

I still get the title displayed twice.

::: C4/Circulation.pm
@@ +3189,4 @@
>  my $dbh = C4::Context->dbh;
>  my $nextaccntno = getnextacctno( $borrowernumber );
>  my $manager_id = 0;
> +my $item = GetBiblioFromItemNumber($itemnumber);

GetBiblioFromItemNumber returns a biblio, not an item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #30 from Aleisha Amohia  ---
Created attachment 47291
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47291=edit
[SIGNED-OFF] Bug 11573: Follow-up: Include changes in OPAC templates

Patch adds changes from earlier patches to OPAC prog and
bootstrap templates.

Patch radds a description for FU - Accrued fine.

Removes a stray space before the comma, using some TT magic.

To test:
- Test like the other patch, display in OPAC prog, OPAC bootstrap,
  Staff Pay fines tab and Staff Accounts tab should be the same.
- No ' , ' should be seen.
- FU fines should now display a description.

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #29 from Aleisha Amohia  ---
Created attachment 47290
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47290=edit
[SIGNED-OFF] Bug 11573 - removing title double ups on boraccount.tt

To test:
1. Create a bunch of fines (or view your existing fines data) - it should have
lost entries, rentals, rental renewals, and regular fines and fine updates.
2. View the fines tab for your borrower with fines
3. without the patch, it will look like the submitted screenshot
4. with the patch, there will be few, if any, doubleups of title

This patch may be incomplete - there may be cases that still need work. I'm
happy to do followups.
Rental fees and rental renewals will not look wholly consistent without the
other attached patch, but this one does not require it.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #47239|0   |1
is obsolete||
  Attachment #47240|0   |1
is obsolete||
  Attachment #47242|0   |1
is obsolete||

--- Comment #27 from Aleisha Amohia  ---
Created attachment 47288
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47288=edit
[SIGNED-OFF] Bug 11573 - Make fine display more consistent for rentals

To test:

1. Set up an item type with a rental charge
2. issue an item from that item type
3. Check fines - the rental charge does not show the title of the issued item
4. Renew that item, the renewal charge does show the title of the issued item
5. Apply the patch
6. Repeat steps 1-4, both should show the title of the issued item in the
description.

This change is proposed in order to get rid of some double ups in the title on
the boraccount template.

Signed-off-by: Katrin Fischer 

Tested with rental lines created before and after applying the patch.
After applying the patch it's better, but old lines will still look ok.

There is still a double up on the title on the 'pay' tab, as we get the
title from the itemnumber and also display the description. I think
getting all the information from the itemnumber for display would be
a bit nicer in the future. Butthis is an improvement.

Passes tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #47288|0   |1
is obsolete||

--- Comment #28 from Aleisha Amohia  ---
Created attachment 47289
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47289=edit
[SIGNED-OFF] Bug 11573 - Make fine display more consistent for rentals

To test:

1. Set up an item type with a rental charge
2. issue an item from that item type
3. Check fines - the rental charge does not show the title of the issued item
4. Renew that item, the renewal charge does show the title of the issued item
5. Apply the patch
6. Repeat steps 1-4, both should show the title of the issued item in the
description.

This change is proposed in order to get rid of some double ups in the title on
the boraccount template.

Signed-off-by: Katrin Fischer 

Tested with rental lines created before and after applying the patch.
After applying the patch it's better, but old lines will still look ok.

There is still a double up on the title on the 'pay' tab, as we get the
title from the itemnumber and also display the description. I think
getting all the information from the itemnumber for display would be
a bit nicer in the future. Butthis is an improvement.

Passes tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

  Attachment #47241|0   |1
is obsolete||

--- Comment #25 from M. Tompsett  ---
Created attachment 47242
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47242=edit
Bug 11573: Follow-up: Include changes in OPAC templates

Patch adds changes from earlier patches to OPAC prog and
bootstrap templates.

Patch radds a description for FU - Accrued fine.

Removes a stray space before the comma, using some TT magic.

To test:
- Test like the other patch, display in OPAC prog, OPAC bootstrap,
  Staff Pay fines tab and Staff Accounts tab should be the same.
- No ' , ' should be seen.
- FU fines should now display a description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

  Attachment #47237|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
  Attachment #47236|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

  Attachment #47238|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #24 from M. Tompsett  ---
Created attachment 47241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47241=edit
Bug 11573: Follow-up: Include changes in OPAC templates

Patch adds changes from earlier patches to OPAC prog and
bootstrap templates.

Patch radds a description for FU - Accrued fine.

Removes a stray space before the comma, using some TT magic.

To test:
- Test like the other patch, display in OPAC prog, OPAC bootstrap,
  Staff Pay fines tab and Staff Accounts tab should be the same.
- No ' , ' should be seen.
- FU fines should now display a description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #22 from M. Tompsett  ---
Created attachment 47239
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47239=edit
Bug 11573 - Make fine display more consistent for rentals

To test:

1. Set up an item type with a rental charge
2. issue an item from that item type
3. Check fines - the rental charge does not show the title of the issued item
4. Renew that item, the renewal charge does show the title of the issued item
5. Apply the patch
6. Repeat steps 1-4, both should show the title of the issued item in the
description.

This change is proposed in order to get rid of some double ups in the title on
the boraccount template.

Signed-off-by: Katrin Fischer 
Tested with rental lines created before and after applying the patch.
After applying the patch it's better, but old lines will still look ok.

There is still a double up on the title on the 'pay' tab, as we get the
title from the itemnumber and also display the description. I think
getting all the information from the itemnumber for display would be
a bit nicer in the future. Butthis is an improvement.

Passes tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #23 from M. Tompsett  ---
Created attachment 47240
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47240=edit
Bug 11573 - removing title double ups on boraccount.tt

To test:
1. Create a bunch of fines (or view your existing fines data) - it should have
lost entries, rentals, rental renewals, and regular fines and fine updates.
2. View the fines tab for your borrower with fines
3. without the patch, it will look like the submitted screenshot
4. with the patch, there will be few, if any, doubleups of title

This patch may be incomplete - there may be cases that still need work. I'm
happy to do followups.
Rental fees and rental renewals will not look wholly consistent without the
other attached patch, but this one does not require it.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

  Attachment #27823|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

  Attachment #27822|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

  Attachment #24486|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

  Attachment #24485|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #19 from M. Tompsett  ---
Created attachment 47236
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47236=edit
Bug 11573 - Make fine display more consistent for rentals

To test:

1. Set up an item type with a rental charge
2. issue an item from that item type
3. Check fines - the rental charge does not show the title of the issued item
4. Renew that item, the renewal charge does show the title of the issued item
5. Apply the patch
6. Repeat steps 1-4, both should show the title of the issued item in the
description.

This change is proposed in order to get rid of some double ups in the title on
the boraccount template.

Signed-off-by: Katrin Fischer 
Tested with rental lines created before and after applying the patch.
After applying the patch it's better, but old lines will still look ok.

There is still a double up on the title on the 'pay' tab, as we get the
title from the itemnumber and also display the description. I think
getting all the information from the itemnumber for display would be
a bit nicer in the future. Butthis is an improvement.

Passes tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #20 from M. Tompsett  ---
Created attachment 47237
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47237=edit
Bug 11573 - removing title double ups on boraccount.tt

To test:
1. Create a bunch of fines (or view your existing fines data) - it should have
lost entries, rentals, rental renewals, and regular fines and fine updates.
2. View the fines tab for your borrower with fines
3. without the patch, it will look like the submitted screenshot
4. with the patch, there will be few, if any, doubleups of title

This patch may be incomplete - there may be cases that still need work. I'm
happy to do followups.
Rental fees and rental renewals will not look wholly consistent without the
other attached patch, but this one does not require it.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

--- Comment #21 from M. Tompsett  ---
Created attachment 47238
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47238=edit
Bug 11573: Follow-up: Include changes in OPAC templates

Patch adds changes from earlier patches to OPAC prog and
bootstrap templates.

Patch radds a description for FU - Accrued fine.

Removes a stray space before the comma, using some TT magic.

To test:
- Test like the other patch, display in OPAC prog, OPAC bootstrap,
  Staff Pay fines tab and Staff Accounts tab should be the same.
- No ' , ' should be seen.
- FU fines should now display a description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #26 from M. Tompsett  ---
It now applies, and should be identical to before.
Admittedly, the commit messages probably should be tweaked to reflect minor
changes, but that would make comparing patches more difficult. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

M. Tompsett  changed:

   What|Removed |Added

  Attachment #27824|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11573] change description of rental charges in account fines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Summary|change description of   |change description of
   |charges in account fines|rental charges in account
   ||fines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/