[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||aleishaamo...@hotmail.com

--- Comment #24 from Aleisha Amohia  ---
Applying: Bug 11651: Add possibility to print holds from holds queue
fatal: sha1 information is lacking or useless (C4/HoldsQueue.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 11651: Add possibility to print holds from holds queue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

  Attachment #32680|0   |1
is obsolete||

--- Comment #21 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 38079
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38079action=edit
Bug 11651: Add possibility to print holds from holds queue

This patch adds possibility to print holds slip, directly from holds
queue page.
Added preference to enable or disable. When enabled in holds queue are 2
new buttons and checkboxes to select holds to print. First button prints
selected holds on RESERVESLIP form. Second is to switch between
display printed or not printed holds. In this mode isn't possible
to display printed and non printed together.

Test plan:
1) Apply patch
2) Update database
3) Make 2 new holds, 1 on specific copy, another on next available
4) Update holds queue by running
$KOHAPATH/misc/cronjobs/holds/build_holds_queue.pl
5) Check holds queue there should be 2 new holds from step 3
6) Enable printSlipFromHoldsQueue in preferences- circulation- interface
7) Go to holds after submit branch there should be 2 new buttons and
checkboxes in table.
8) Print both holds and check if on slip are all biblio and item info.
9) click show printed to display printed holds
10) click hide printed, now holds queue shuld be empty
11) disable printSlipFromHoldsQueue go to holds queue and check if holds
are again visible.

Signed-off-by: Aurelie Fichot aurelie.fic...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

  Attachment #32681|0   |1
is obsolete||

--- Comment #22 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 38080
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38080action=edit
Bug 11651: (QA Follow-up) Add possibility to print holds from holds queue.

Added unit tests, for new and modified subroutines.
Fixed minor qa suggestions.
Koha-qa.pl - pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Three issues:

1) The layout on this appears to be a bit wonky. I think it needs to use the
toolbar markup used in many other places in Koha.

2) The show/hide printed holds button doesn't do what it says. It switches to
showing only printed holds or non-printed holds. The language should be View
printed holds and View un-printed holds or some such thing.

3) Print checked holds should be Print selected holds or maybe just Print
selected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #23 from Rafal Kopaczka rkopac...@afm.edu.pl ---
(In reply to Kyle M Hall from comment #20)
 Three issues:
 
 1) The layout on this appears to be a bit wonky. I think it needs to use the
 toolbar markup used in many other places in Koha.

Added toolbar, looks much better :) 

 2) The show/hide printed holds button doesn't do what it says. It switches
 to showing only printed holds or non-printed holds. The language should be
 View printed holds and View un-printed holds or some such thing.
 3) Print checked holds should be Print selected holds or maybe just
 Print selected

Fixed. 
Also rebased to current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #15 from Owen Leonard oleon...@myacpl.org ---
This isn't working for me. When I select 4 titles in the holds queue to print,
the resulting printout says:

Reserve not foundReserve not foundReserve not foundReserve not found

Looks like reserve_id isn't getting passed to the template?

Note that the term hold should be used instead of reserve. We only use
reserve in the context of Course Reserves.

Looks like that text is coming directly from the .pl file. English strings
should be handled in a way which is translatable, preferably by putting them in
the template. printslip.tt appears to be capable of handling it already?

Some other suggestions:

- Leave the header cell in the checkbox column empty. It doesn't
  need the word Check.
- Exclude the checkbox column from being sorted by the table sorter.
- Add a warning to the user if they click the Print checked holds
  without checking anything.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #16 from Rafal Kopaczka rkopac...@afm.edu.pl ---
(In reply to Owen Leonard from comment #15)
 This isn't working for me. When I select 4 titles in the holds queue to
 print, the resulting printout says:
 
 Reserve not foundReserve not foundReserve not foundReserve not found
 
 Looks like reserve_id isn't getting passed to the template?

It says, that reserve not found, so some id must be passed to script, have
you updated database and re-run build_holds_queue.pl after that? 
Printing from holds queue require reserve_id in tmp_holdsqueue, which is
populated by build holds queue after patch. If this didn't work let me know. 

 
 Note that the term hold should be used instead of reserve. We only use
 reserve in the context of Course Reserves.
 
 Looks like that text is coming directly from the .pl file. English strings
 should be handled in a way which is translatable, preferably by putting them
 in the template. printslip.tt appears to be capable of handling it already?

printslip.tt only partial can handle this case, since it print hold not
found, only if slip variable is undef. In case of printing many holds only few
may be not found, while other will define slip. So hold not found info would
not show.
I'll try to figure out some error handling in print for this case.

 
 Some other suggestions:
 
 - Leave the header cell in the checkbox column empty. It doesn't
   need the word Check.
 - Exclude the checkbox column from being sorted by the table sorter.
 - Add a warning to the user if they click the Print checked holds
   without checking anything.

Will do. 

Thanks for test!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #17 from Owen Leonard oleon...@myacpl.org ---
(In reply to Rafal Kopaczka from comment #16)
 It says, that reserve not found, so some id must be passed to script, have
 you updated database and re-run build_holds_queue.pl after that? 

I must not have rebuilt the holds queue. Sorry about that. I can confirm now
that the selected holds are printed and that they are subsequently hidden from
the holds queue report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

  Attachment #32126|0   |1
is obsolete||

--- Comment #18 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 32680
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32680action=edit
Bug 11651: Add possibility to print holds from holds queue

This patch adds possibility to print holds slip, directly from holds
queue page.
Added preference to enable or disable. When enabled in holds queue are 2
new buttons and checkboxes to select holds to print. First button prints
selected holds on RESERVESLIP form. Second is to switch between
display printed or not printed holds. In this mode isn't possible
to display printed and non printed together.

Test plan:
1) Apply patch
2) Update database
3) Make 2 new holds, 1 on specific copy, another on next available
4) Update holds queue by running
$KOHAPATH/misc/cronjobs/holds/build_holds_queue.pl
5) Check holds queue there should be 2 new holds from step 3
6) Enable printSlipFromHoldsQueue in preferences- circulation- interface
7) Go to holds after submit branch there should be 2 new buttons and
checkboxes in table.
8) Print both holds and check if on slip are all biblio and item info.
9) click show printed to display printed holds
10) click hide printed, now holds queue shuld be empty
11) disable printSlipFromHoldsQueue go to holds queue and check if holds
are again visible.

Signed-off-by: Aurelie Fichot aurelie.fic...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

  Attachment #32127|0   |1
is obsolete||

--- Comment #19 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 32681
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32681action=edit
Bug 11651: (QA Follow-up) Add possibility to print holds from holds queue.

Added unit tests, for new and modified subroutines.
Fixed minor qa suggestions.
Koha-qa.pl - pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

  Attachment #26262|0   |1
is obsolete||
  Attachment #28574|0   |1
is obsolete||

--- Comment #12 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 32126
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32126action=edit
Bug 11651: Add possibility to print holds from holds queue

This patch adds possibility to print holds slip, directly from holds
queue page.
Added preference to enable or disable. When enabled in holds queue are 2
new buttons and checkboxes to select holds to print. First button prints
selected holds on RESERVESLIP form. Second is to switch between
display printed or not printed holds. In this mode isn't possible
to display printed and non printed together.

Test plan:
1) Apply patch
2) Update database
3) Make 2 new holds, 1 on specific copy, another on next available
4) Update holds queue by running
$KOHAPATH/misc/cronjobs/holds/build_holds_queue.pl
5) Check holds queue there should be 2 new holds from step 3
6) Enable printSlipFromHoldsQueue in preferences- circulation- interface
7) Go to holds after submit branch there should be 2 new buttons and
checkboxes in table.
8) Print both holds and check if on slip are all biblio and item info.
9) click show printed to display printed holds
10) click hide printed, now holds queue shuld be empty
11) disable printSlipFromHoldsQueue go to holds queue and check if holds
are again visible.

Signed-off-by: Aurelie Fichot aurelie.fic...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #13 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 32127
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32127action=edit
Bug 11651: (QA Follow-up) Add possibility to print holds from holds queue.

Added unit tests, for new and modified subroutines.
Fixed minor qa suggestions.
Koha-qa.pl - pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #14 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Rebased, against master. Also few minor changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #10 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 28574
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28574action=edit
Bug 11651: (QA Follow-up) Add possibility to print holds from holds queue.
Added unit tests, for new and modified subroutines. Fixed minor qa suggestions.
Koha-qa.pl - pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #11 from Rafal Kopaczka rkopac...@afm.edu.pl ---
(In reply to Jonathan Druart from comment #9)
 Comment on attachment 26262 [details] [review]
 Bug 11651: Add possibility to print holds from holds queue
 
 Review of attachment 26262 [details] [review]:
 -
 
 Please take a look at the following.
 Marked as Failed QA.
  +MarkHoldPrinted
  +GetItemNumberFromTmpHold
 
 New unit tests should be provided for these 2 new subroutines.
 @@ +136,5 @@
  +if (C4::Context-preference('printSlipFromHoldsQueue')){
  +$query .= $branchli
 
 New unit tests should be provided for this subroutine change.
 
 ::: C4/Reserves.pm
 @@ +2255,5 @@
  +'biblio'  = $reserve-{biblionumber},
  +'items'   = $itemnumber,
 At least one unit test should be provided for this new subroutine.

Fixed. But please, take a look to this test. I'm new in writing unit tests. So
any feedback may be helpful. 


 ::: circ/hold-pull-print.pl
 License should be GPLv3.
  +use strict;
  +#use warnings; #FIXME - Bug 2505
 
 replace use strict/warnings with use Modern::Perl.
 
Fixed.

 ::: circ/view_holdsqueue.pl
 @@ +76,4 @@
   $template-param(
branchloop = GetBranchesLoop(C4::Context-userenv-{'branch'}),
  itemtypeloop = \@itemtypesloop,
  +   printenable = C4::Context-preference('printSlipFromHoldsQueue'),
 
 Same as previously.
I don't get it, what is wrong here? Not unit test I think?

 
 ::: installer/data/mysql/updatedatabase.pl

  +print Upgrade to $DBversion done \n;
 
 you forgot the SetVersion call here.

Fixed, also rebased to master.

 you can use [un]checkCheckboxes functions provided by
 jquery.checkboxes.min.js to do that.
Fixed.
 
 @@ +93,2 @@
   [% IF ( itemsloop ) %]
  +form id=hold_print name=hold_print method=get 
  action=/cgi-bin/koha/circ/hold-pull-print.pl target=_blank
 
 why do you use target=_blank here?
Print slip must be open in new window it is in form to print, same as all
printable reports in Koha (Reserve slip/Borrower sumary etc.). Why here? It
works, at least for me :)

 @@ +142,5 @@
   [% IF ( printenable ) %]
  +/form
 
 This close tag is in a IF but not the form.

Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 26262
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26262
Bug 11651: Add possibility to print holds from holds queue

Review of attachment 26262:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11651attachment=26262)
-

Please take a look at the following.
Marked as Failed QA.

::: C4/HoldsQueue.pm
@@ +47,5 @@
  TransportCostMatrix
  UpdateTransportCostMatrix
 +
 +MarkHoldPrinted
 +GetItemNumberFromTmpHold

New unit tests should be provided for these 2 new subroutines.

@@ +136,5 @@
 +if (C4::Context-preference('printSlipFromHoldsQueue')){
 +$query .= $branchlimit ?  AND :  WHERE;
 +$query .=  tmp_holdsqueue.print_status = ?;
 +push @bind_params, $printstatus;
 +}

New unit tests should be provided for this subroutine change.

::: C4/Reserves.pm
@@ +2255,5 @@
 +'biblio'  = $reserve-{biblionumber},
 +'items'   = $itemnumber,
 +},
 +);
 +}

At least one unit test should be provided for this new subroutine.

::: circ/hold-pull-print.pl
@@ +12,5 @@
 +# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License along
 +# with Koha; if not, write to the Free Software Foundation, Inc.,
 +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

License should be GPLv3.

@@ +15,5 @@
 +# with Koha; if not, write to the Free Software Foundation, Inc.,
 +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 +
 +use strict;
 +#use warnings; #FIXME - Bug 2505

replace use strict/warnings with use Modern::Perl.

::: circ/view_holdsqueue.pl
@@ +76,4 @@
  $template-param(
   branchloop = GetBranchesLoop(C4::Context-userenv-{'branch'}),
 itemtypeloop = \@itemtypesloop,
 +   printenable = C4::Context-preference('printSlipFromHoldsQueue'),

Same as previously.

::: installer/data/mysql/updatedatabase.pl
@@ +8071,5 @@
 +$dbh-do(ALTER TABLE old_reserves ADD print_status BOOLEAN NOT NULL 
 DEFAULT '0');
 +$dbh-do(ALTER TABLE tmp_holdsqueue ADD print_status BOOLEAN NOT NULL 
 DEFAULT '0');
 +$dbh-do(ALTER TABLE tmp_holdsqueue ADD reserve_id INT ( 11 ) FIRST);
 +$dbh-do(INSERT INTO systempreferences 
 (variable,value,options,explanation,type) VALUES('printSlipFromHoldsQueue', 
 '0', 'NULL', 'If enabled reserve slips can be printed from Holds Queue 
 screen,', 'YesNo'););
 +print Upgrade to $DBversion done \n;

you forgot the SetVersion call here.

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
@@ +44,5 @@
 +for (var i=0; i  document.hold_print.reserve_id.length; i++) {
 +document.hold_print.reserve_id[i].checked=false;
 +}
 +}
 +}

you can use [un]checkCheckboxes functions provided by jquery.checkboxes.min.js
to do that.

@@ +93,2 @@
  [% IF ( itemsloop ) %]
 +form id=hold_print name=hold_print method=get 
 action=/cgi-bin/koha/circ/hold-pull-print.pl target=_blank

why do you use target=_blank here?

@@ +142,5 @@
  /tr
  [% END %]/tbody
  /table
 +[% IF ( printenable ) %]
 +/form

This close tag is in a IF but not the form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

  Attachment #24948|0   |1
is obsolete||
 Status|Failed QA   |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |rkopac...@afm.edu.pl
   |ity.org |

--- Comment #3 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 26239
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26239action=edit
Bug-11651-Add-possibility-to-print-holds-from-holds

(In reply to Aurélie Fichot from comment #2)
 The text plan is OK until the 3 step.
 Holds queue is not updating by running
 $KOHAPATH/misc/cronjobs/holds/build_holds_queue.pl
 We can see the 2 holds in patron's information page but not in the hold
 queue (view_holdsqueue.pl) 
 
 But we see the 2 new buttons but not the items (No items found).

Should work now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Aurélie Fichot aurelie.fic...@iepg.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Aurélie Fichot aurelie.fic...@iepg.fr ---
Ok until step 7.
When we try to print, a new window is open (strange ?)

with '404 error' at this URL : 

http://pro.test2.biblibre.com/cgi-bin/koha/circ/hold-pull-print.pl?reserve_id=1424reserve_id=1425

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

  Attachment #26239|0   |1
is obsolete||

--- Comment #5 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 26252
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26252action=edit
0001-Bug-11651-Add-possibility-to-print-holds-from-holds

(In reply to Aurélie Fichot from comment #4)
 Ok until step 7.
 When we try to print, a new window is open (strange ?)

Sorry, forget to add new file to git. 
New window is ok, this is where reserve slip is printed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #8 from Aurélie Fichot aurelie.fic...@iepg.fr ---
It works !

8) The Print botton open a new window just for printing the holds, with all
biblio and item info.
9) click show printed to display printed holds : OK
10) click hide printed, now holds queue shuld be empty : OK
11) disable printSlipFromHoldsQueue go to holds queue and check if holds
are again visible : OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

  Attachment #26252|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #7 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Created attachment 26262
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26262action=edit
Bug 11651: Add possibility to print holds from holds queue

This patch adds possibility to print holds slip, directly from holds
queue page.
Added preference to enable or disable. When enabled in holds queue are 2
new buttons and checkboxes to select holds to print. First button prints
selected holds on RESERVESLIP form. Second is to switch between
display printed or not printed holds. In this mode isn't possible
to display printed and non printed together.

Test plan:
1) Apply patch
2) Update database
3) Make 2 new holds, 1 on specific copy, another on next available
4) Update holds queue by running
$KOHAPATH/misc/cronjobs/holds/build_holds_queue.pl
5) Check holds queue there should be 2 new holds from step 3
6) Enable printSlipFromHoldsQueue in preferences- circulation- interface
7) Go to holds after submit branch there should be 2 new buttons and
checkboxes in table.
8) Print both holds and check if on slip are all biblio and item info.
9) click show printed to display printed holds
10) click hide printed, now holds queue shuld be empty
11) disable printSlipFromHoldsQueue go to holds queue and check if holds
are again visible.

Signed-off-by: Aurelie Fichot aurelie.fic...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #6 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Patch tested with a sandbox, by Aurelie Fichot aurelie.fic...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Aurélie Fichot aurelie.fic...@iepg.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||aurelie.fic...@iepg.fr

--- Comment #2 from Aurélie Fichot aurelie.fic...@iepg.fr ---
The text plan is OK until the 3 step.
Holds queue is not updating by running
$KOHAPATH/misc/cronjobs/holds/build_holds_queue.pl
We can see the 2 holds in patron's information page but not in the hold queue
(view_holdsqueue.pl) 

But we see the 2 new buttons but not the items (No items found).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #1 from Rafal Kopaczka rkopac...@afm.edu.pl ---
Created attachment 24948
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24948action=edit
Bug-11651-Add-possibility-to-print-holds-from-holds-.patch

This patch adds possibility to print holds slip, directly from holds
queue page.
Added preference to enable or disable. When enabled in holds queue are 2
new buttons and checkboxes to select holds to print. First button prints
selected holds on RESERVESLIP form. Second is to switch between
display printed or not printed holds. In this mode isn't possible
to display printed and non printed together.

Test plan:
1) Apply patch
2) Update database
3) Make 2 new holds, 1 on specific copy, another on next available
4) Update holds queue by running
$KOHAPATH/misc/cronjobs/holds/build_holds_queue.pl
5) Check holds queue there should be 2 new holds from step 3
6) Enable printSlipFromHoldsQueue in preferences- circulation- interface
7) Go to holds after submit branch there should be 2 new buttons and
checkboxes in table.
8) Print both holds and check if on slip are all biblio and item info.
9) click show printed to display printed holds
10) click hide printed, now holds queue shuld be empty
11) disable printSlipFromHoldsQueue go to holds queue and check if holds
are again visible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

Rafal Kopaczka rkopac...@afm.edu.pl changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/