[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

--- Comment #12 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #11)
> (In reply to Esther Melander from comment #10)
> > It would be nice to change serial statuses to authorized values so that
> > custom statuses can be added with added functionality.
> > 
> > One example is to have a status that says "bindery" to indicate a serial
> > which is temporarily unavailable. It is not currently possible to do this.
> > And in general there is no way to edit the serial status in the serial
> > collection after it has been received.
> 
> Hi Esther, 23.05 has a bindery status :) 
> 
> The magic numbers here refer to the fact that numbers are used internally
> instead of codes, which would make reporting etc. easier. As the AV are
> shown to the users in the OPAC I am not too fond of the AV idea yet, because
> AV are not multi-lingual (yet). I hope someday they will be :)

Bug 32752

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

--- Comment #11 from Katrin Fischer  ---
(In reply to Esther Melander from comment #10)
> It would be nice to change serial statuses to authorized values so that
> custom statuses can be added with added functionality.
> 
> One example is to have a status that says "bindery" to indicate a serial
> which is temporarily unavailable. It is not currently possible to do this.
> And in general there is no way to edit the serial status in the serial
> collection after it has been received.

Hi Esther, 23.05 has a bindery status :) 

The magic numbers here refer to the fact that numbers are used internally
instead of codes, which would make reporting etc. easier. As the AV are shown
to the users in the OPAC I am not too fond of the AV idea yet, because AV are
not multi-lingual (yet). I hope someday they will be :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #10 from Esther Melander  ---
It would be nice to change serial statuses to authorized values so that custom
statuses can be added with added functionality.

One example is to have a status that says "bindery" to indicate a serial which
is temporarily unavailable. It is not currently possible to do this. And in
general there is no way to edit the serial status in the serial collection
after it has been received.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Noémie Labine  changed:

   What|Removed |Added

 CC||noemie.lab...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

--- Comment #9 from Katrin Fischer  ---
(In reply to Caroline Cyr La Rose from comment #8)
> Are authorized values translatable now? I feel like we should be able to
> customized the serial statuses like we do regular statuses.

You can translate them, but they are not multi-lingual - you can not have them
in English and German for example. And we don't have installers for a lot of
different languages, so it's manual work to translate them often.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #8 from Caroline Cyr La Rose  ---
Are authorized values translatable now? I feel like we should be able to
customized the serial statuses like we do regular statuses.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #0)
 [3] Create a new serial_issue_status column to manage the statuses.  It
 might look like this:
 
 id INTEGER -- status ID
 name VARCHAR(255) -- label of status
 missing BOOLEAN -- whether or not the status should be considered to
 represent an issue that was never received

I'm not sure it is enough.
The status value is checked at several places in the code:

 1/ (planneddate  now() AND serial.status=1) OR serial.STATUS IN (3, 4, 41,
42, 43, 44)

 2/ WHERE ((planneddate  now() AND serial.STATUS =1) OR serial.STATUS = 3)

and some others.

The missing boolean won't permit to write a SQL query doing the same thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10851

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 25045
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25045action=edit
Bug 11687: statecollection.pl is no longer in use

It can be removed.

Test plan:
  git grep statecollection
returns no occurrence.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #25045|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 25045
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25045
Bug 11687: statecollection.pl is no longer in use

Arg, bad bz number.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

--- Comment #7 from Galen Charlton gmcha...@gmail.com ---
(In reply to Jonathan Druart from comment #4)
 (In reply to Galen Charlton from comment #0)
  [3] Create a new serial_issue_status column to manage the statuses.  It
  might look like this:
  
  id INTEGER -- status ID
  name VARCHAR(255) -- label of status
  missing BOOLEAN -- whether or not the status should be considered to
  represent an issue that was never received
 
 I'm not sure it is enough.
 The status value is checked at several places in the code:
 
  1/ (planneddate  now() AND serial.status=1) OR serial.STATUS IN (3, 4, 41,
 42, 43, 44)
 
  2/ WHERE ((planneddate  now() AND serial.STATUS =1) OR serial.STATUS = 3)
 
 and some others.
 
 The missing boolean won't permit to write a SQL query doing the same thing.

Good point.  Additional flags would cover the cases you've listed, e.g.,

is_expected_status
is_late_status
is_claimed_status

However, we could also pin the IDs for those statuses and use named constants
in the code for those, and use an deletable flag in the serial_issue_status to
control whether the user can remove that status.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
The problem with authorized values is that there is currently no way to have
multiple translations. The standard statuses right now are located in the
tepmlates and are therefore translated into any installed lanugage.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm,  might be misunderstanding.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11682] serials.status is too dependent on magic numbers

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Ok, no more commenting in the late evenings? :) Maybe we could allow to define
custom statuses and still keep a few standard ones, similar to the suggestion
status.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/