[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Owen Leonard  changed:

   What|Removed |Added

 Blocks|13614   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614
[Bug 13614] Replace usage of YUI on basket groups page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #298 from Katrin Fischer  ---
I have a sense of déjà vu with this one... :)

1) QA tools:

 FAIL   t/db_dependent/Acquisition/Basketgroups.t
   OK critic
   FAIL   forbidden patterns
forbidden pattern: Use of DateTime->now should certainly be
replaced with dt_from_string (bug 24840) (line 42)

 FAIL   t/db_dependent/Acquisition/Basketgroups.t
   OK critic
   FAIL   forbidden patterns
forbidden pattern: Use of DateTime->now should certainly be
replaced with dt_from_string (bug 24840) (line 42)

 FAIL   acqui/basketgroup.pl
   OK critic
   FAIL   forbidden patterns
forbidden pattern: Script permissions is authnotrequired => 0,
it could be correct for an OPAC script if it is was you really want error (bug
24663) (line 69)

Can you please fix?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #297 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #288)
> 0) There is a QA script fail:
Fixed

> 3) When there are no basket groups yet, the link in the sidebar leads to an
> empty page. It might be nicer to display a little message.
Fixed

> 4) The datatable on the new basket group page is broken:
> TypeError: $(...).kohaDataTable is not a function
I cannot reproduce. kohaDataTable is declared in those patches. Maybe a browser
cache issue ?

> 5) When you are on the pages of a vendor, there is a tab labelled 'Basket
> groups' and there is also a link now below with the same label. This could
> be confusing. Not sure what to do about that - noting it to see if someone
> has a good idea.
I changed it to 'All basket groups'... The UI can certainly be improved in this
area

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #295 from Julian Maurice  ---
Created attachment 104934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104934=edit
Bug 11708: Show a message when there are no basket groups

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #296 from Julian Maurice  ---
Created attachment 104935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104935=edit
Bug 11708: Remove useless type attribute from script tag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #294 from Julian Maurice  ---
Created attachment 104933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104933=edit
Bug 11708: Reword 'Basket groups' into 'All basket groups'

Hopefully this will be enough to clarify the difference between this
link and the 'Basket groups' tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #93487|0   |1
is obsolete||

--- Comment #293 from Julian Maurice  ---
Created attachment 104932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104932=edit
Bug 11708: Fix PDF export

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #93483|0   |1
is obsolete||

--- Comment #290 from Julian Maurice  ---
Created attachment 104929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104929=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed
5. prove t/db_dependent/Koha/Acquisition/Basket.t

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #93484|0   |1
is obsolete||

--- Comment #291 from Julian Maurice  ---
Created attachment 104930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104930=edit
Bug 11708: Add missing POD in Koha::Acquisition::Basket

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #93485|0   |1
is obsolete||

--- Comment #292 from Julian Maurice  ---
Created attachment 104931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104931=edit
Bug 11708: Use bootstrap grid instead of yui

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #93482|0   |1
is obsolete||

--- Comment #289 from Julian Maurice  ---
Created attachment 104928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104928=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com

--- Comment #288 from Katrin Fischer  ---
0) There is a QA script fail:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt
   OK filters
   FAIL   forbidden patterns
forbidden pattern: Attribute type should not be used for script
tags (bug 20053) (line 122)

1) Not sure about the naming of these: ordered_titles_count,
received_titles_count
Not a blocker, just noting (no blocker)

2) Effects on EDI
I wonder if the change to closeddate affects EDI. Asking Kyle/Martin to have a
look.

3) When there are no basket groups yet, the link in the sidebar leads to an
empty page. It might be nicer to display a little message.

4) The datatable on the new basket group page is broken:
TypeError: $(...).kohaDataTable is not a function

5) When you are on the pages of a vendor, there is a tab labelled 'Basket
groups' and there is also a link now below with the same label. This could be
confusing. Not sure what to do about that - noting it to see if someone has a
good idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #287 from sandbo...@biblibre.com  ---
Created attachment 93487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93487=edit
Bug 11708: Fix PDF export

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #286 from sandbo...@biblibre.com  ---
Created attachment 93485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93485=edit
Bug 11708: Use bootstrap grid instead of yui

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #285 from sandbo...@biblibre.com  ---
Created attachment 93484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93484=edit
Bug 11708: Add missing POD in Koha::Acquisition::Basket

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #284 from sandbo...@biblibre.com  ---
Created attachment 93483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93483=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed
5. prove t/db_dependent/Koha/Acquisition/Basket.t

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #283 from sandbo...@biblibre.com  ---
Created attachment 93482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93482=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #93464|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #93463|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #93462|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #93461|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #93460|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #282 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92382|0   |1
is obsolete||

--- Comment #281 from Julian Maurice  ---
Created attachment 93464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93464=edit
Bug 11708: Fix PDF export

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92380|0   |1
is obsolete||

--- Comment #279 from Julian Maurice  ---
Created attachment 93462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93462=edit
Bug 11708: Add missing POD in Koha::Acquisition::Basket

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92381|0   |1
is obsolete||

--- Comment #280 from Julian Maurice  ---
Created attachment 93463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93463=edit
Bug 11708: Use bootstrap grid instead of yui

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92379|0   |1
is obsolete||

--- Comment #278 from Julian Maurice  ---
Created attachment 93461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93461=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed
5. prove t/db_dependent/Koha/Acquisition/Basket.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92378|0   |1
is obsolete||

--- Comment #277 from Julian Maurice  ---
Created attachment 93460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93460=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #276 from Séverine Queune  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 11708:
Something went wrong !Applying: Bug 11708: Change
aqbasketgroups.closed to closeddate
Warning: commit message did not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitencoding to the encoding your project uses.
Applying: Bug 11708: New page for basket groups
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
M   koha-tmpl/intranet-tmpl/prog/js/datatables.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/datatables.js
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/js/datatables.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
error: Failed to merge in the changes.
Patch failed at 0001 Bug 11708: New page for basket groups

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #91286|0   |1
is obsolete||

--- Comment #272 from Julian Maurice  ---
Created attachment 92379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92379=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed
5. prove t/db_dependent/Koha/Acquisition/Basket.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #275 from Julian Maurice  ---
Created attachment 92382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92382=edit
Bug 11708: Fix PDF export

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #91285|0   |1
is obsolete||

--- Comment #271 from Julian Maurice  ---
Created attachment 92378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92378=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #274 from Julian Maurice  ---
Created attachment 92381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92381=edit
Bug 11708: Use bootstrap grid instead of yui

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #273 from Julian Maurice  ---
Created attachment 92380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92380=edit
Bug 11708: Add missing POD in Koha::Acquisition::Basket

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #270 from Owen Leonard  ---
Overall this looks good to me. There are a couple of issues raised by the QA
tool which need to be addressed.

The only problem I ran into was exporting as PDF. I get this error:

Can't call method "header" on an undefined value at
/home/vagrant/kohaclone/acqui/basketgroup.pl line 159

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #85787|0   |1
is obsolete||

--- Comment #269 from Julian Maurice  ---
Created attachment 91286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91286=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed
5. prove t/db_dependent/Koha/Acquisition/Basket.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #85786|0   |1
is obsolete||

--- Comment #268 from Julian Maurice  ---
Created attachment 91285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91285=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #267 from Séverine Queune  ---
Sorry Julian for the lack of reaction...

CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc
Auto-merging acqui/basketgroup.pl
CONFLICT (content): Merge conflict in acqui/basketgroup.pl
Auto-merging acqui/basket.pl
Auto-merging Koha/Acquisition/Basket.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 11708: New page for basket groups

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #266 from Julian Maurice  ---
Patches rebased + squashed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #80979|0   |1
is obsolete||

--- Comment #264 from Julian Maurice  ---
Created attachment 85786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85786=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #80980|0   |1
is obsolete||
  Attachment #80981|0   |1
is obsolete||
  Attachment #80982|0   |1
is obsolete||

--- Comment #265 from Julian Maurice  ---
Created attachment 85787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85787=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed
5. prove t/db_dependent/Koha/Acquisition/Basket.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #263 from Owen Leonard  ---
I get an error when I close a basket group and choose 'Generate EDIFACT order':

bookseller id is required to edit a basketgroup at
/home/vagrant/kohaclone/C4/Acquisition.pm line 1100.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #80700|0   |1
is obsolete||

--- Comment #262 from Julian Maurice  ---
Created attachment 80982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80982=edit
Bug 11708: Add missing TT filters and fix perlcritic errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #80699|0   |1
is obsolete||

--- Comment #261 from Julian Maurice  ---
Created attachment 80981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80981=edit
Bug 11708: Fix QA issues

- Change how closedate is set in database update
- Reword bookseller to vendor in Koha::Acquisition::BasketGroup
- Do not "cache" baskets in Koha::Acquisition::BasketGroup
- Remove useless IF in basketgroup.tt
- Move JS to bottom in basketgroups.tt
- Fix some links to basketgroup.pl
- Remove useless use in acqui/basketgroup.pl
- Remove useless sub displaybasketgroups in acqui/basketgroup.pl
- Remove useless code in C4::Acquisition

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #80698|0   |1
is obsolete||

--- Comment #260 from Julian Maurice  ---
Created attachment 80980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80980=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #80697|0   |1
is obsolete||

--- Comment #259 from Julian Maurice  ---
Created attachment 80979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80979=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #258 from Owen Leonard  ---
This patch inadvertently changes the filename of two existing files (which
didn't exist when the patch was written): BasketGroup.pm and BasketGroups.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #257 from Katrin Fischer  ---
Patches apply, QA script is clean.

I am wondering about the changes to
koha-tmpl/intranet-tmpl/prog/js/datatables.js as well. Adding Owen, maybe he
has a moment to take a look at the datatables question here.

Jonathan, could you have another look at Julian's answers in comment#249?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #256 from Julian Maurice  ---
Patches rebased + another patch of QA fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #255 from Julian Maurice  ---
Created attachment 80700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80700=edit
Bug 11708: Add missing TT filters and fix perlcritic errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #78664|0   |1
is obsolete||

--- Comment #254 from Julian Maurice  ---
Created attachment 80699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80699=edit
Bug 11708: Fix QA issues

- Change how closedate is set in database update
- Reword bookseller to vendor in Koha::Acquisition::Basketgroup
- Do not "cache" baskets in Koha::Acquisition::Basketgroup
- Remove useless IF in basketgroup.tt
- Move JS to bottom in basketgroups.tt
- Fix some links to basketgroup.pl
- Remove useless use in acqui/basketgroup.pl
- Remove useless sub displaybasketgroups in acqui/basketgroup.pl
- Remove useless code in C4::Acquisition

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #78663|0   |1
is obsolete||

--- Comment #253 from Julian Maurice  ---
Created attachment 80698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80698=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #78662|0   |1
is obsolete||

--- Comment #252 from Julian Maurice  ---
Created attachment 80697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80697=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #251 from Katrin Fischer  ---
Please also make sure to run the newest qa script on the code to check for
missing filters!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #250 from Katrin Fischer  ---
Sorry, this no longer applies, can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11708: Change aqbasketgroups.closed to closeddate
Applying: Bug 11708: New page for basket groups
fatal: sha1 information is lacking or useless (C4/Acquisition.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 11708: New page for basket groups
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-11708-New-page-for-basket-groups-maTm2R.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #249 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #245)
> 1. aqbasketgroups.closedate is set to NOW, maybe better to use
> basket.closedate (the latest)?
Fixed

> 2. ->bookseller should be ->vendor (not blocker as we already have both in
> Koha::*...)
Fixed

> 3. a. I would not "cache" ->baskets, we already deal with the context in
> Koha::Objects->search
I don't know what is the context you are talking about, but I removed the
"caching"

> b. ->baskets_count - no need to have it, it should be replaced with
> baskets->count
> => Maybe you want to keep them for performance purpose, but is it really a
> performance improvement?
It's used only in templates, because TT seems to force the list context even
with a directive like this: [% basketgroup.baskets.count %]
It tries to call count on the first item of @{ $basketgroup->baskets }
I'd happily remove this sub if you have a better idea.

> 5. basketgroup.tt has a [% IF booksellerid %], it should not be useful now.
Fixed

> We may want to display a friendly message if called without a [valid] id
Is returning a 404 error friendly ? Because it's probably what should be done
if
the id is invalid.

> 6. basketgroups.tt should have JS at the bottom
Fixed

> 7. Some links still point to basketgroup.pl?booksellerid=X without the
> basketgroupid, they should be replaced right?
> i.e. code related to 'sub displaybasketgroups' in basketgroup.pl should be
> removed (?)
Fixed

> 8. Are you sure you need the changes done to C4::Acquisition?
No. They're not needed anymore. I removed them.

> 9. acqui/basketgroup.pl
> + use List::MoreUtils qw/uniq/;
> => Not needed
Fixed

> 10. "kohaDataTable": We already have KohaTable. You are adding a 3rd way to
> init a table.
We already have 3 ways to initialize DT:
1. The "legacy API" way:
   $("#table_id").dataTable($.extend(true, {}, dataTablesDefaults, { ... });
2. The "legacy API + column_settings" way:
   KohaTable('table_id', ...);
3. The "1.10+ API" way
   $('#table_id').DataTable(...)

kohaDataTable is just a wrapper around the 3rd that provides the same defaults
than the 1st and 2nd methods.
I don't see how this is bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #248 from Julian Maurice  ---
Created attachment 78664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78664=edit
Bug 11708: Fix QA issues

- Change how closedate is set in database update
- Reword bookseller to vendor in Koha::Acquisition::Basketgroup
- Do not "cache" baskets in Koha::Acquisition::Basketgroup
- Remove useless IF in basketgroup.tt
- Move JS to bottom in basketgroups.tt
- Fix some links to basketgroup.pl
- Remove useless use in acqui/basketgroup.pl
- Remove useless sub displaybasketgroups in acqui/basketgroup.pl
- Remove useless code in C4::Acquisition

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #75909|0   |1
is obsolete||

--- Comment #247 from Julian Maurice  ---
Created attachment 78663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78663=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #75908|0   |1
is obsolete||

--- Comment #246 from Julian Maurice  ---
Created attachment 78662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78662=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #245 from Jonathan Druart  
---
1. aqbasketgroups.closedate is set to NOW, maybe better to use basket.closedate
(the latest)?

2. ->bookseller should be ->vendor (not blocker as we already have both in
Koha::*...)

3. a. I would not "cache" ->baskets, we already deal with the context in
Koha::Objects->search
b. ->baskets_count - no need to have it, it should be replaced with
baskets->count
=> Maybe you want to keep them for performance purpose, but is it really a
performance improvement?

5. basketgroup.tt has a [% IF booksellerid %], it should not be useful now.
We may want to display a friendly message if called without a [valid] id

6. basketgroups.tt should have JS at the bottom

7. Some links still point to basketgroup.pl?booksellerid=X without the
basketgroupid, they should be replaced right?
i.e. code related to 'sub displaybasketgroups' in basketgroup.pl should be
removed (?)

8. Are you sure you need the changes done to C4::Acquisition?

9. acqui/basketgroup.pl
+ use List::MoreUtils qw/uniq/;
=> Not needed

10. "kohaDataTable": We already have KohaTable. You are adding a 3rd way to
init a table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #244 from Julian Maurice  ---
Patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #75004|0   |1
is obsolete||

--- Comment #243 from Julian Maurice  ---
Created attachment 75909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75909=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #75003|0   |1
is obsolete||

--- Comment #242 from Julian Maurice  ---
Created attachment 75908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75908=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Séverine Queune  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #241 from Séverine Queune  ---
I tried to test bug 20810 but this dependency doesn't apply :

Bug 11708 - Display all basketgroups on one page, and new column
aqbasketgroups.closeddate

75003 - Bug 11708: Change aqbasketgroups.closed to closeddate
75004 - Bug 11708: New page for basket groups

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11708: Change aqbasketgroups.closed to closeddate
Applying: Bug 11708: New page for basket groups
Using index info to reconstruct a base tree...
M   acqui/basketgroup.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
Falling back to patching base and 3-way merge...
error: The following untracked working tree files would be overwritten by
merge:
Koha/Acquisition/Basketgroup.pm
Koha/Acquisition/Basketgroups.pm
acqui/basketgroups.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt
Please move or remove them before you can merge.
Aborting

Also failed on Biblibre's sandbox #11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Blocks||20810


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810
[Bug 20810] Add filters and links in basketgroups page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #240 from Julian Maurice  ---
Katrin, thanks for the review !

I did a bit of cleanup here : I squashed all patches into only two patches and
removed all changes that were not related to (or needed by) this patchset. I
think it will be easier to read.
QA script is happy now and I think I fixed every problem you mentioned in
comment 237, except for the following:

> +my $pdfformatfile = './' . ($pdfformat =~ s,::,/,gr) . '.pm';
> +require $pdfformatfile;
> Seems to be an unrelated change? I remember that we hardcoded the valid 
> template names once for added security. could only find one mention of it 
> tho: bug 11459#c11
It's just part of the "basketgroup.pl cleanup" process. perlcritic complains
when we use the eval "string" construct. It shouldn't change anything.

> f) Changes to koha-tmpl/intranet-tmpl/prog/js/datatables.js
> Do you remember why those changes were needed or was it not intentional? 
> Trying to figure out what needs to be tested with this patch and it turns out 
> a lot of code is touched.
I don't remember why exactly, but I needed to use the 1.10+ API of DataTables.
These changes just map legacy API defaults to new API ones. This shouldn't
change anything for code using the legacy API.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74351|0   |1
is obsolete||
  Attachment #74353|0   |1
is obsolete||
  Attachment #74354|0   |1
is obsolete||
  Attachment #74357|0   |1
is obsolete||
  Attachment #74358|0   |1
is obsolete||

--- Comment #239 from Julian Maurice  ---
Created attachment 75004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75004=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74349|0   |1
is obsolete||
  Attachment #74350|0   |1
is obsolete||
  Attachment #74352|0   |1
is obsolete||
  Attachment #74355|0   |1
is obsolete||
  Attachment #74356|0   |1
is obsolete||

--- Comment #238 from Julian Maurice  ---
Created attachment 75003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75003=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #237 from Katrin Fischer  ---
Sorry Julian, patches apply, but still some problems:

1) QA scripts

Lots of those:
 FAIL   Koha/Baskets.pm
   FAIL   git manipulation
The file has been added and deleted in the same patchset
Maybe see if you can squash some with the same sign-offer?

And:

 FAIL   t/db_dependent/Acquisition/close_reopen_basket.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
Global symbol "$order1" requires explicit package name 
Global symbol "$order2" requires explicit package name 
t/db_dependent/Acquisition/close_reopen_basket.t had
compilation errors.

 FAIL   t/db_dependent/Acquisition/Basketgroups.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
"AddBookseller" is not exported by the C4::Bookseller module
Can't continue after import errors 

2) Code review

a) Koha/Acquisition/Baskets.pm
-# Copyright 2017 Aleisha Amohia 
-#
Why remove the Copyright statement? And POD?

b) Similar: Koha/Acquisition/Orders.pm

+my $pdfformatfile = './' . ($pdfformat =~ s,::,/,gr) . '.pm';
+require $pdfformatfile;
Seems to be an unrelated change? I remember that we hardcoded the valid
template names once for added security. could only find one mention of it tho:
bug 11459#c11

c) admin/currency.pl
+use Koha::Acquisition::Currency;
Unrelated change?

d) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt
Bookseller
Should be vendor!

e) Generate EDIFACT Order
Capitalization: Generate EDIFACT order

f) Changes to koha-tmpl/intranet-tmpl/prog/js/datatables.js
Do you remember why those changes were needed or was it not intentional? Trying
to figure out what needs to be tested with this patch and it turns out a lot of
code is touched.

g) Merge atomicupdates?

3) Unit tests

prove t/db_dependent/Acquisition/Basketgroups.t
t/db_dependent/Acquisition/Basketgroups.t .. "AddBookseller" is not exported by
the C4::Bookseller module
Can't continue after import errors at t/db_dependent/Acquisition/Basketgroups.t
line 9.
BEGIN failed--compilation aborted at t/db_dependent/Acquisition/Basketgroups.t
line 9.

prove t/db_dependent/Acquisition/close_reopen_basket.t
t/db_dependent/Acquisition/close_reopen_basket.t .. Global symbol "$order1"
requires explicit package name at
t/db_dependent/Acquisition/close_reopen_basket.t line 58.
Global symbol "$order2" requires explicit package name at
t/db_dependent/Acquisition/close_reopen_basket.t line 68.
Execution of t/db_dependent/Acquisition/close_reopen_basket.t aborted due to
compilation errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74310|0   |1
is obsolete||

--- Comment #235 from Julian Maurice  ---
Created attachment 74357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74357=edit
Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace

and fix Koha::Acquisition::Order usage everywhere

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74311|0   |1
is obsolete||

--- Comment #236 from Julian Maurice  ---
Created attachment 74358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74358=edit
Bug 11708: Use Asset plugin in acqui/basketgroups.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74308|0   |1
is obsolete||

--- Comment #233 from Julian Maurice  ---
Created attachment 74355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74355=edit
Bug 11708: UT: Replace 'ok' by 'is' where appropriate

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74309|0   |1
is obsolete||

--- Comment #234 from Julian Maurice  ---
Created attachment 74356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74356=edit
Bug 11708: UT: Use DateTime instead of localtime+sprintf

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74306|0   |1
is obsolete||

--- Comment #231 from Julian Maurice  ---
Created attachment 74353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74353=edit
Bug 11708: Place "Basket groups" menu entry on top of the side navigation

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74307|0   |1
is obsolete||

--- Comment #232 from Julian Maurice  ---
Created attachment 74354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74354=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

In the process, this patch adds 4 new "Koha::Object" modules:
- Koha::Bookseller(s)
- Koha::Basket(s)
- Koha::Basketgroup(s)
- Koha::Order(s)

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74305|0   |1
is obsolete||

--- Comment #230 from Julian Maurice  ---
Created attachment 74352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74352=edit
Bug 11708: Remove column aqbasketgroups.closed

It is redundant with aqbasketgroups.closeddate

Signed-off-by: Paola Rossi 

Patch updated: use atomic update

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74304|0   |1
is obsolete||

--- Comment #229 from Julian Maurice  ---
Created attachment 74351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74351=edit
Bug 11708: basketgroup.pl can now display basketgroups for all suppliers

This happens when no booksellerid is given.
This patch also adds 4 columns:
- No. of ordered titles
- No. of received titles
- Ordered amount
- Charged amount (amount of received orders)

Add filters to basketgroup tables columns
Show closed date in closed basketgroups tables

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74303|0   |1
is obsolete||

--- Comment #228 from Julian Maurice  ---
Created attachment 74350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74350=edit
Bug 11708: Unit tests for aqbasketgroups.closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74302|0   |1
is obsolete||

--- Comment #227 from Julian Maurice  ---
Created attachment 74349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74349=edit
Bug 11708: Add aqbasketgroups.closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 

Patch updated: Use atomic update

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74222|0   |1
is obsolete||

--- Comment #226 from Julian Maurice  ---
Created attachment 74311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74311=edit
Bug 11708: Use Asset plugin in acqui/basketgroups.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74220|0   |1
is obsolete||

--- Comment #224 from Julian Maurice  ---
Created attachment 74309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74309=edit
Bug 11708: UT: Use DateTime instead of localtime+sprintf

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74218|0   |1
is obsolete||

--- Comment #222 from Julian Maurice  ---
Created attachment 74307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74307=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

In the process, this patch adds 4 new "Koha::Object" modules:
- Koha::Bookseller(s)
- Koha::Basket(s)
- Koha::Basketgroup(s)
- Koha::Order(s)

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74221|0   |1
is obsolete||

--- Comment #225 from Julian Maurice  ---
Created attachment 74310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74310=edit
Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace

and fix Koha::Acquisition::Order usage everywhere

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74217|0   |1
is obsolete||

--- Comment #221 from Julian Maurice  ---
Created attachment 74306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74306=edit
Bug 11708: Place "Basket groups" menu entry on top of the side navigation

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74219|0   |1
is obsolete||

--- Comment #223 from Julian Maurice  ---
Created attachment 74308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74308=edit
Bug 11708: UT: Replace 'ok' by 'is' where appropriate

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74216|0   |1
is obsolete||

--- Comment #220 from Julian Maurice  ---
Created attachment 74305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74305=edit
Bug 11708: Remove column aqbasketgroups.closed

It is redundant with aqbasketgroups.closeddate

Signed-off-by: Paola Rossi 

Patch updated: use atomic update

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74213|0   |1
is obsolete||

--- Comment #217 from Julian Maurice  ---
Created attachment 74302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74302=edit
Bug 11708: Add aqbasketgroups.closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 

Patch updated: Use atomic update

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74214|0   |1
is obsolete||

--- Comment #218 from Julian Maurice  ---
Created attachment 74303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74303=edit
Bug 11708: Unit tests for aqbasketgroups.closeddate

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74215|0   |1
is obsolete||

--- Comment #219 from Julian Maurice  ---
Created attachment 74304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74304=edit
Bug 11708: basketgroup.pl can now display basketgroups for all suppliers

This happens when no booksellerid is given.
This patch also adds 4 columns:
- No. of ordered titles
- No. of received titles
- Ordered amount
- Charged amount (amount of received orders)

Add filters to basketgroup tables columns
Show closed date in closed basketgroups tables

Signed-off-by: juliette levast 
Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #216 from Katrin Fischer  ---
Hi Julian, can you give it another go? I think your branch might have been
missing the latest commits (bug 18791).


Apply? [(y)es, (n)o, (i)nteractive] y  
Applying: Bug 11708: Add aqbasketgroups.closeddate
Applying: Bug 11708: Unit tests for aqbasketgroups.closeddate
Applying: Bug 11708: basketgroup.pl can now display basketgroups for all
suppliers
Applying: Bug 11708: Remove column aqbasketgroups.closed
Applying: Bug 11708: Place "Basket groups" menu entry on top of the side
navigation
Applying: Bug 11708: New page for basket groups
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
M   koha-tmpl/intranet-tmpl/prog/js/datatables.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/datatables.js
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/js/datatables.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
Failed to merge in the changes.
Patch failed at 0001 Bug 11708: New page for basket groups
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-11708-New-page-for-basket-groups-pzWRYQ.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #214 from Julian Maurice  ---
Created attachment 74222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74222=edit
Bug 11708: Use Asset plugin in acqui/basketgroups.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #215 from Julian Maurice  ---
Patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72699|0   |1
is obsolete||

--- Comment #213 from Julian Maurice  ---
Created attachment 74221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74221=edit
Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace

and fix Koha::Acquisition::Order usage everywhere

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72696|0   |1
is obsolete||

--- Comment #210 from Julian Maurice  ---
Created attachment 74218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74218=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

In the process, this patch adds 4 new "Koha::Object" modules:
- Koha::Bookseller(s)
- Koha::Basket(s)
- Koha::Basketgroup(s)
- Koha::Order(s)

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72697|0   |1
is obsolete||

--- Comment #211 from Julian Maurice  ---
Created attachment 74219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74219=edit
Bug 11708: UT: Replace 'ok' by 'is' where appropriate

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/