[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 --- Comment #6 from M. de Rooy --- Created attachment 27230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27230&action=edit Bug 11826: Use xslt handler object in showmarc, Record.pm Modifies showmarc and opac-showmarc to use new xslt handler. Removes cardview.pl as obsolete script. Modifies C4/Record.pm and a typo in the test Record.t. Test plan: [1] catalogue/showmarc: Go to Cataloging. Search. Click Card. [2] opac-showmarc: Go to opac detail, MARC view. Open URL for plain view in new tab. Change URL: Change viewas=html to viewas=card [3] Verify that there are no references in the codebase to cardview.pl [4] C4/Record.pm: Run the Record.t test in db_dependent. This test uses marc2modsxml, triggering the change. Additional: export to MODS from opac-detail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826
--- Comment #5 from M. de Rooy ---
Created attachment 27229
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27229&action=edit
Bug 11826: Using the XSLT handler in C4/XSLT module
Incorporate the new object into C4/XSLT module.
The handler object needed one adjustment to allow for passing URLs.
Removed the GetURI function; it is no longer needed.
Added some documentation lines.
Moved a file-level lexical upwards in the code for visibility.
Removed some tabs (on two lines).
Note: The handler could perhaps be moved up to the Context module, or be saved
in a global ('our') variable. But I would rather not do that now, making
testing not too complex at this moment.
Test plan:
Enable XSLT preferences for opac and intranet.
Check result and detail pages.
Check individual list display (virtual shelves).
Force an XSLT error by editing one of your xsl files. Check the
corresponding display.
Put an URL in one the XSLT prefs (could just be to your own server).
Check the display.
Signed-off-by: Marcel de Rooy
Running XSLTParse4Display in a loop showed no significant performance change.
One pass cost me around 0.012 sec (except for the first pass).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 M. de Rooy changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #4 from M. de Rooy --- (In reply to Magnus Enger from comment #3) > Kudos for splitting code into smaller patches! But I don't think it makes > sense to add code to Koha before it is used somewhere - the bigger project > might get abandoned and we are left with dead code. I'm setting this to "In > discussion" and we can set it back to "Needs signoff" when the functionality > that builds on this also needs signoff. Back to Needs Signoff. Please look at the dependency. (Bug 11915.) You are most welcome to sign off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||mag...@enger.priv.no --- Comment #3 from Magnus Enger --- Kudos for splitting code into smaller patches! But I don't think it makes sense to add code to Koha before it is used somewhere - the bigger project might get abandoned and we are left with dead code. I'm setting this to "In discussion" and we can set it back to "Needs signoff" when the functionality that builds on this also needs signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 M. de Rooy changed: What|Removed |Added Blocks||11915 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6536 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 M. de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826
--- Comment #1 from M. de Rooy ---
Created attachment 25573
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25573&action=edit
Bug 11826: Add XSLT handler object to Koha namespace
In achieving the goals of umbrella report 6536 (Z3950 improvements), this
report adds a XSLT handler object to the Koha namespace.
A follow-up adds unit tests for this module.
This patch does not yet incorporate the new object into Z3950 search. So
it does not change any behavior and is therefore harder to test.
Test plan:
Run the unit tests of the follow-up patch on report 11826.
Signed-off-by: Marcel de Rooy
I tested the new module in two additional ways:
[1] Made a simple script (four lines as below) that ran a larger xml file
with 1500 records through a test XSLT file modifying the title.
my $eng= Koha::XSLT_Handler->new;
open my $fh1, '<', '_example_file';
my @xml= <$fh1>;
print $eng->transform( join('', @xml), '_example_xsl_file');
[2] Incorporated the object into my local changes of Breeding.pm (based on
older work, not ready for submittal now).
Ran transformation on Z3950 search results. Worked well :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 --- Comment #2 from M. de Rooy --- Created attachment 25574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25574&action=edit Bug 11826: Add unit tests for Koha::XSLT_Handler Test plan: Verify if XSLT_Handler.t passes. You could also sabotage the test by removing one of the test xsl files. Or you could 'repair' the bad xsl file (test02). Remove the second line redefining the xsl variable. In all those cases the unit test should fail now.. Discard your changes :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11826] Add XSLT handler object to Koha namespace
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826 M. de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
