[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #59 from Julian Maurice  ---
(In reply to David Cook from comment #57)
> I didn't mean to sound so critical...
> 
> Could someone elaborate as to how these patches might benefit Koha and
> developers? Perhaps I'm missing something.
I don't know how to say it better than in the first comment of this bug.
It's only a simpler way to send messages to UI, and it works across redirects
(that's why I use CGI::Session).
Of course we can have strings in a separate .tt file or a resource file like in
Java, but I think it's not worth it.
To me the message is not part of the presentation, it's only data, but I
believe that's where our opinions differ  ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #58 from Katrin Fischer  ---
Moving this to 'Discussion' - could be a topic next meeting or go on the
mailing list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #57 from David Cook  ---
I didn't mean to sound so critical...

Could someone elaborate as to how these patches might benefit Koha and
developers? Perhaps I'm missing something.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #56 from David Cook  ---
(In reply to Jonathan Druart from comment #54)
> I personally do not like the idea to move the strings to the pl scripts.
> Moreover we have tried to use the KohaDates plugin as much as possible in
> template files, which you are reverting with this patch.

I'm also not a fan.

One of the major reasons for having a template system is to use it to manage
your presentation (ie your strings). The Perl should be responsible for the
logic. 

Personally, if we were to move some strings out of the templates, I'd want to
move them to a resources file like you have in a lot of Java projects. You
reference the string in the template using an identifier, and it makes changes
and translations way easier. Of course, that would probably have a negative
performance impact with Perl unless you're using Plack or mod_perl.

My other question is... why are we using CGI::Session, if we're trying to move
to Plack? 

I haven't thoroughly investigated the code, but I don't see this bug offering a
lot of benefit to Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #55 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #54)
> I personally do not like the idea to move the strings to the pl scripts.

Why ? :)
I sometimes feel that extra effort is put into moving strings to template file
(and we do this only because that's the only place where they can be
translated)

> Moreover we have tried to use the KohaDates plugin as much as possible in
> template files, which you are reverting with this patch.

I don't understand why this is an issue, the message is now in .pl script so
the date formatting happens here. It seems logical.

Note that moving message from .tt to .pl is not the main purpose of this bug,
if you have another solution in mind I will gladly hear it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #54 from Jonathan Druart  
---
I personally do not like the idea to move the strings to the pl scripts.
Moreover we have tried to use the KohaDates plugin as much as possible in
template files, which you are reverting with this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #53 from Julian Maurice  ---
You understand it correctly.

I started to do some performance tests for bug 15395 (which is not used at the
moment, but I hope it will replace the existing Koha::I18N) and it's
encouraging: for 1000 different strings translated through a TT plugin, it
takes only 0.02 seconds more to process the template. Things get worse with
1 strings (0.7 seconds more) but I don't think we will have to translate so
many strings on a single page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #52 from Katrin Fischer  ---
Hm, taking a first look at this.

If I understand it correctly, this will replace the strings 'on the fly' from
the new po file 'messages' as the string is in the .pl file and no longer in
the .tt file?

I am concerned how this will impact performance especially if we start using
this more and more and when the .po file grows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49061|0   |1
is obsolete||

--- Comment #51 from Owen Leonard  ---
Created attachment 49265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49265=edit
[SIGNED-OFF] Bug 11904: Example usage of new module Koha::Messages

Test plan:
1/ Go to members/moremember.pl
2/ Click on "More" -> "Renew patron" and confirm
3/ A message should appear "Patron's account has been renewed until ..."
4/ In a shell, go to misc/translator and run
  ./translate create fr-FR (or ./translate update fr-FR)
  ./translate install fr-FR
  (you can use your own language of course)
5/ Edit po/fr-FR-messages.po and translate the string "Patron's account
   has been renewed until ..."
6/ In staff interface change language to French and renew patron once
again.
7/ The translated message should appear.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49060|0   |1
is obsolete||

--- Comment #50 from Owen Leonard  ---
Created attachment 49264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49264=edit
[SIGNED-OFF] Bug 11904: Unit tests for Koha::Messages

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49059|0   |1
is obsolete||

--- Comment #49 from Owen Leonard  ---
Created attachment 49263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49263=edit
[SIGNED-OFF] Bug 11904: New module Koha::Messages

This patch provides a uniform way to send messages to user interface.
It uses CGI::Session to store messages and allow to render them thanks
to a Template::Toolkit plugin (Koha::Template::Plugin::Messages)
and a template include file (messages.inc)

This patch doesn't introduce the new template include file anywhere. It
will require additional patches to make it work.

To use it, simply call messages_set() in a Perl script or module, then
put [% INCLUDE 'messages.inc' %] at the right place in the right
template file.

See POD documentation of Koha::Messages for more information.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

  Attachment #48418|0   |1
is obsolete||

--- Comment #48 from Julian Maurice  ---
Created attachment 49061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49061=edit
Bug 11904: Example usage of new module Koha::Messages

Test plan:
1/ Go to members/moremember.pl
2/ Click on "More" -> "Renew patron" and confirm
3/ A message should appear "Patron's account has been renewed until ..."
4/ In a shell, go to misc/translator and run
  ./translate create fr-FR (or ./translate update fr-FR)
  ./translate install fr-FR
  (you can use your own language of course)
5/ Edit po/fr-FR-messages.po and translate the string "Patron's account
   has been renewed until ..."
6/ In staff interface change language to French and renew patron once
again.
7/ The translated message should appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

  Attachment #48417|0   |1
is obsolete||

--- Comment #47 from Julian Maurice  ---
Created attachment 49060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49060=edit
Bug 11904: Unit tests for Koha::Messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

  Attachment #48415|0   |1
is obsolete||
  Attachment #48416|0   |1
is obsolete||

--- Comment #46 from Julian Maurice  ---
Created attachment 49059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49059=edit
Bug 11904: New module Koha::Messages

Rebased on master
Use current style for dialogs instead of adding a new style

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #45 from Julian Maurice  ---
(In reply to Owen Leonard from comment #44)
> #2 is more difficult because it's a matter of opinion. You like message
> boxes that have a 100% width. I don't. Because we disagree we have to get
> more opinions. Moving the issue to a new bug will help keep the discussions
> focused.

I don't care about the width of boxes, as long as it is the same for all types
of boxes.

I can remove CSS changes from these patches and use existing style instead if
this is what you meant for #1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #44 from Owen Leonard  ---
(In reply to Julian Maurice from comment #43)
> Should I start by replacing the "home-made" icons by Font Awesome ones ?

I think this bug should be split into two parts:

1. Implementing the way to send messages to the user.

2. Proposing a system-wide revision of the style of messages.

#1 is easy to move forward because it can be explained as a potential
simplification, and can be done without revising the interface (for now).

#2 is more difficult because it's a matter of opinion. You like message boxes
that have a 100% width. I don't. Because we disagree we have to get more
opinions. Moving the issue to a new bug will help keep the discussions focused.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #43 from Julian Maurice  ---
Should I start by replacing the "home-made" icons by Font Awesome ones ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15584

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #42 from Owen Leonard  ---
After some brief testing I have some comments:

- I think the core idea of this bug is good, and I have no comment about the
implementation. I'll leave the Perl to those who know it better.

- I still have an issue with the addition of new styles of messages. This is
something which is in discussion on other bugs (See the comments on Bug 15584),
and at the same time work is being done to alter the style of existing messages
(Bug 15785 and related bugs). We do need to come to an agreement about how this
should work.

I think perhaps we should separate the structural functional aspect of this bug
from the presentational aspect. Move this bug forward using the existing
styling of messages and alerts and start a new bug with a proposal for altering
the existing standard for how we display messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #41 from Julian Maurice  ---
All patches rebased on master + opac.css changes put in their own patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

  Attachment #40962|0   |1
is obsolete||

--- Comment #40 from Julian Maurice  ---
Created attachment 48418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48418=edit
Bug 11904: Example usage of new module Koha::Messages

Test plan:
1/ Go to members/moremember.pl
2/ Click on "More" -> "Renew patron" and confirm
3/ A message should appear "Patron's account has been renewed until ..."
4/ In a shell, go to misc/translator and run
  ./translate create fr-FR (or ./translate update fr-FR)
  ./translate install fr-FR
  (you can use your own language of course)
5/ Edit po/fr-FR-messages.po and translate the string "Patron's account
   has been renewed until ..."
6/ In staff interface change language to French and renew patron once
again.
7/ The translated message should appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

  Attachment #40961|0   |1
is obsolete||

--- Comment #39 from Julian Maurice  ---
Created attachment 48417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48417=edit
Bug 11904: Unit tests for Koha::Messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

  Attachment #40960|0   |1
is obsolete||

--- Comment #37 from Julian Maurice  ---
Created attachment 48415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48415=edit
Bug 11904: New module Koha::Messages

This patch provides a uniform way to send messages to user interface.
It uses CGI::Session to store messages and allow to render them thanks
to a Template::Toolkit plugin (Koha::Template::Plugin::Messages)
and a template include file (messages.inc)

This patch doesn't introduce the new template include file anywhere. It
will require additional patches to make it work.

To use it, simply call messages_set() in a Perl script or module, then
put [% INCLUDE 'messages.inc' %] at the right place in the right
template file.

See POD documentation of Koha::Messages for more information.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #38 from Julian Maurice  ---
Created attachment 48416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48416=edit
Bug 11904: Update compiled opac.css file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #36 from Owen Leonard  ---
Sorry, this doesn't apply anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Fridolin SOMERS fridolin.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #38522|0   |1
is obsolete||

--- Comment #33 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 40960
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40960action=edit
Bug 11904: New module Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #38523|0   |1
is obsolete||

--- Comment #34 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 40961
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40961action=edit
Bug 11904: Unit tests for Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #38524|0   |1
is obsolete||

--- Comment #35 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 40962
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40962action=edit
Bug 11904: Example usage of new module Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #32 from M. Tompsett mtomp...@hotmail.com ---
There are a couple of things that I just don't have the time to check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #30581|0   |1
is obsolete||

--- Comment #30 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38524
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38524action=edit
Bug 11904: Example usage of new module Koha::Messages

Test plan:
1/ Go to members/moremember.pl
2/ Click on More - Renew patron and confirm
3/ A message should appear Patron's account has been renewed until ...
4/ In a shell, go to misc/translator and run
  ./translate create fr-FR (or ./translate update fr-FR)
  ./translate install fr-FR
  (you can use your own language of course)
5/ Edit po/fr-FR-messages.po and translate the string Patron's account
   has been renewed until ...
6/ In staff interface change language to French and renew patron once
again.
7/ The translated message should appear.

Needs patches from bugs 8044 and 11848 for string translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #31 from M. Tompsett mtomp...@hotmail.com ---
Hopefully this rebase is correct. One less Patch does not apply. YAY! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #30580|0   |1
is obsolete||

--- Comment #29 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38523
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38523action=edit
Bug 11904: Unit tests for Koha::Messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #30579|0   |1
is obsolete||

--- Comment #28 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38522
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38522action=edit
Bug 11904: New module Koha::Messages

This patch provides a uniform way to send messages to user interface.
It uses CGI::Session to store messages and allow to render them thanks
to a Template::Toolkit plugin (Koha::Template::Plugin::Messages)
and a template include file (messages.inc)

This patch doesn't introduce the new template include file anywhere. It
will require additional patches to make it work.

To use it, simply call messages_set() in a Perl script or module, then
put [% INCLUDE 'messages.inc' %] at the right place in the right
template file.

See POD documentation of Koha::Messages for more information.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||mtomp...@hotmail.com

--- Comment #27 from M. Tompsett mtomp...@hotmail.com ---
Please put the css files (because they are minified) in a seperate patch, so
the person testing, can skip and rebuild them easily.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904
Bug 11904 depends on bug 8044, which changed state.

Bug 8044 Summary: Localization for Perl scripts and modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl ---
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/less/opac.less
Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css


Besides that this patch does not apply, could you, Julian, further explain the
reason why these patches touch the css and less files? Is the third example
patch meant for a push to mainstream, or just as a test file?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29552|0   |1
is obsolete||

--- Comment #23 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30579
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30579action=edit
Bug 11904: New module Koha::Messages

Rebased on master
Reintroduce bootstrap/less/opac.less and bootstrap/css/opac.css that where
removed by a previous rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29553|0   |1
is obsolete||

--- Comment #24 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30580
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30580action=edit
Bug 11904: Unit tests for Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29554|0   |1
is obsolete||

--- Comment #25 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30581
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30581action=edit
Bug 11904: Example usage of new module Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #26 from Julian Maurice julian.maur...@biblibre.com ---
 (In reply to M. de Rooy from comment #22)
 Besides that this patch does not apply, could you, Julian, further explain
 the reason why these patches touch the css and less files?
If you mean why they touch both instead of just one ?, it's because I
recompiled the less file I modified and included the result of this compilation
in the patch. Is this a problem ?

 Is the third example patch meant for a push to mainstream, or just as a test
 file?
I submitted this patch only to demonstrate how to use the new module, so this
is just a test file. I think it can be pushed to master, but it should not
block the other patches to pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #14 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
(In reply to Julian Maurice from comment #13)
 Can you look at the log file ? Maybe there's a clue in it.

Julian, tested and works well. Test pass and no koha-qa errors.
(was a problem on my side)

But... you are touching some opac prog files
As we are on PROG/CCSR deprecation, and this is a new feature,
those will never be included.

Could you reset those files?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27940|0   |1
is obsolete||
  Attachment #27941|0   |1
is obsolete||
  Attachment #27942|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29545
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29545action=edit
Bug 11904: New module Koha::Messages

This patch provides a uniform way to send messages to user interface.
It uses CGI::Session to store messages and allow to render them thanks
to a Template::Toolkit plugin (Koha::Template::Plugin::Messages)
and a template include file (messages.inc)

This patch doesn't introduce the new template include file anywhere. It
will require additional patches to make it work.

To use it, simply call messages_set() in a Perl script or module, then
put [% INCLUDE 'messages.inc' %] at the right place in the right
template file.

See POD documentation of Koha::Messages for more information.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29547
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29547action=edit
Bug 11904: Example usage of new module Koha::Messages

Test plan:
1/ Go to members/moremember.pl
2/ Click on More - Renew patron and confirm
3/ A message should appear Patron's account has been renewed until ...
4/ In a shell, go to misc/translator and run
  ./translate create fr-FR (or ./translate update fr-FR)
  ./translate install fr-FR
  (you can use your own language of course)
5/ Edit po/fr-FR-messages.po and translate the string Patron's account
   has been renewed until ...
6/ In staff interface change language to French and renew patron once
again.
7/ The translated message should appear.

Needs patches from bugs 8044 and 11848 for string translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29546
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29546action=edit
Bug 11904: Unit tests for Koha::Messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Bernardo Gonzalez Kriegel from comment #14)
 But... you are touching some opac prog files
 As we are on PROG/CCSR deprecation, and this is a new feature,
 those will never be included.
 
 Could you reset those files?

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #29546|0   |1
is obsolete||

--- Comment #20 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 29553
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29553action=edit
[SIGNED-OFF] Bug 11904: Unit tests for Koha::Messages

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Test pass, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #29547|0   |1
is obsolete||

--- Comment #21 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 29554
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29554action=edit
[SIGNED-OFF] Bug 11904: Example usage of new module Koha::Messages

Test plan:
1/ Go to members/moremember.pl
2/ Click on More - Renew patron and confirm
3/ A message should appear Patron's account has been renewed until ...
4/ In a shell, go to misc/translator and run
  ./translate create fr-FR (or ./translate update fr-FR)
  ./translate install fr-FR
  (you can use your own language of course)
5/ Edit po/fr-FR-messages.po and translate the string Patron's account
   has been renewed until ...
6/ In staff interface change language to French and renew patron once
again.
7/ The translated message should appear.

Needs patches from bugs 8044 and 11848 for string translation

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Bugs 8044 and 11484 already in master
Tested using es-ES, works as described.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #29545|0   |1
is obsolete||

--- Comment #19 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 29552
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29552action=edit
[SIGNED-OFF] Bug 11904: New module Koha::Messages

This patch provides a uniform way to send messages to user interface.
It uses CGI::Session to store messages and allow to render them thanks
to a Template::Toolkit plugin (Koha::Template::Plugin::Messages)
and a template include file (messages.inc)

This patch doesn't introduce the new template include file anywhere. It
will require additional patches to make it work.

To use it, simply call messages_set() in a Perl script or module, then
put [% INCLUDE 'messages.inc' %] at the right place in the right
template file.

See POD documentation of Koha::Messages for more information.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Originally there was a conflict on bootstrap less/opac.less and
css/opac.css, not now, but can't access git at this moment.

No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #13 from Julian Maurice julian.maur...@biblibre.com ---
By both translated, you mean you have translated the string in
fr-FR-messages.po and es-ES-messages.po ?
I just retried, applying patches on current master, and the translation works
for me.
Can you look at the log file ? Maybe there's a clue in it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #12 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Julian,
message is always in english, tried with fr-FR and es-ES,
both translated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #25910|0   |1
is obsolete||

--- Comment #9 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 27940
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27940action=edit
Bug 11904: New module Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #25911|0   |1
is obsolete||

--- Comment #10 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 27941
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27941action=edit
Bug 11904: Unit tests for Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #25912|0   |1
is obsolete||

--- Comment #11 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 27942
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27942action=edit
Bug 11904: Example usage of new module Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from Owen Leonard oleon...@myacpl.org ---
Why doesn't this work with the existing two types of message box styles, div
class=dialog message and div class=dialog alert ?

Following the test plan the message I get is unstyled, wrapped in this:

div class=messages ok

Is this new system designed to work with a greater number/different kind of
messages? What can we do to keep the styling consistent?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #8 from Julian Maurice julian.maur...@biblibre.com ---
 Why doesn't this work with the existing two types of message box
 styles, div class=dialog message and div class=dialog alert ?
Because those two divs haven't the same width and I wanted all message
boxes to have the same width (and I didn't want to change existing rules
to avoid breaking things)

 Following the test plan the message I get is unstyled
If Koha is in English, did you try to clean all possible caches (http
server, browser, ...) ? I had to hit Ctrl-F5 many times during
development ;)

 Is this new system designed to work with a greater number/different
 kind of messages? What can we do to keep the styling consistent?
I think we can keep dialog for message boxes that asks something to
the user. And use messages for all others message boxes.
These two kind of message boxes serve different purposes. Is there a
real need to keep styling consistent between them?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Depends on||8044, 11848

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #6 from Julian Maurice julian.maur...@biblibre.com ---
(In reply to Kyle M Hall from comment #5)
 I've been unable to test this because I cannot apply the patches for 11848,
 but I think this is a most excellent idea! It reminds me of stash for Perl
 Catalyst.

Did you apply the patches for 8044 first ?
I just rebased them on master, so they all apply nicely if you apply them in
this order: 8044, 11848, 11904.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
I've been unable to test this because I cannot apply the patches for 11848, but
I think this is a most excellent idea! It reminds me of stash for Perl
Catalyst.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25910
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25910action=edit
Bug 11904: New module Koha::Messages

This patch provides a uniform way to send messages to user interface.
It uses CGI::Session to store messages and allow to render them thanks
to a Template::Toolkit plugin (Koha::Template::Plugin::Messages)
and a template include file (messages.inc)

This patch doesn't introduce the new template include file anywhere. It
will require additional patches to make it work.

To use it, simply call messages_set() in a Perl script or module, then
put [% INCLUDE 'messages.inc' %] at the right place in the right
template file.

See POD documentation of Koha::Messages for more information.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #2 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25911
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25911action=edit
Bug 11904: Unit tests for Koha::Messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #4 from Julian Maurice julian.maur...@biblibre.com ---
Note: These patches don't introduce the new template include file anywhere. It
will requires additional patches to make it work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #3 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25912
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25912action=edit
Bug 11904: Example usage of new module Koha::Messages

Test plan:
1/ Go to members/moremember.pl
2/ Click on More - Renew patron and confirm
3/ A message should appear Patron's account has been renewed until ...
4/ In a shell, go to misc/translator and run
  ./translate create fr-FR (or ./translate update fr-FR)
  ./translate install fr-FR
  (you can use your own language of course)
5/ Edit po/fr-FR-messages.po and translate the string Patron's account
   has been renewed until ...
6/ In staff interface change language to French and renew patron once
again.
7/ The translated message should appear.

Needs patches from bugs 8044 and 11848 for string translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/