[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #20 from Jonathan Druart --- Created attachment 75737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75737=edit Bug 11911: (follow-up) Hide suggestion box on acq start page if no permission When the user is not superlibrarian or has the manage_suggestions permission, the suggestion box on the left of the acq start page needs to be hidden. Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart changed: What|Removed |Added Attachment #75630|0 |1 is obsolete|| Attachment #75631|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart --- Created attachment 75736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75736=edit Bug 11911: Add a separate permission for managing suggestions Without this patch only catalogue permission was required for managing suggestions. This patch adds a new permission in the acquisition module do manage suggestions and updates staff user permissions accordingly. To test: - Make sure there is a pending suggestion - Create a few users with different permission sets: - User 1: only catalogue - User 2: any acquisition permission - User 3: cataloguing permission - Check all of them can access: /cgi-bin/koha/suggestion/suggestion.pl - Apply the patch - Verify all of them now have the suggestions_manage permission - Verify everything displays correctly on: - intranet start page - patron account in staff - acquisition start page - suggestion page (try to access by URL too) - Remove suggestions_manage for a staff user - Repeat tests above, access should be denied/links not visible Bonus: - Fixes the link on the acquisition start page for late orders to mage the permissions of the page itself: order_receive Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > After the require the new { acquisition => 'suggestions_manage' } they* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed --- Comment #17 from Jonathan Druart --- We should highlight the change in the release notes: Before: members/purchase-suggestions.pl required { borrowers => 'edit_borrowers' } suggestion/suggestion.pl required { catalogue => 1 } After the require the new { acquisition => 'suggestions_manage' } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #16 from Katrin Fischer --- Sorry Joubu, but I don't understand what you mean. I look for staff users with catalogue permission and the new permission is under acquisitions... where does the borrowers permission play in? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- I am not sure it's a big deal but since bug 18403 the "borrowers" permissions has subpermissions and so the SQL query should be adjusted a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #14 from Séverine Queune --- Both patchs ok for me, thank you Katrin ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Séverine Queune changed: What|Removed |Added Attachment #75616|0 |1 is obsolete|| --- Comment #13 from Séverine Queune --- Created attachment 75631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75631=edit Bug 11911: (follow-up) Hide suggestion box on acq start page if no permission When the user is not superlibrarian or has the manage_suggestions permission, the suggestion box on the left of the acq start page needs to be hidden. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Séverine Queune changed: What|Removed |Added Attachment #75448|0 |1 is obsolete|| --- Comment #12 from Séverine Queune --- Created attachment 75630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75630=edit Bug 11911: Add a separate permission for managing suggestions Without this patch only catalogue permission was required for managing suggestions. This patch adds a new permission in the acquisition module do manage suggestions and updates staff user permissions accordingly. To test: - Make sure there is a pending suggestion - Create a few users with different permission sets: - User 1: only catalogue - User 2: any acquisition permission - User 3: cataloguing permission - Check all of them can access: /cgi-bin/koha/suggestion/suggestion.pl - Apply the patch - Verify all of them now have the suggestions_manage permission - Verify everything displays correctly on: - intranet start page - patron account in staff - acquisition start page - suggestion page (try to access by URL too) - Remove suggestions_manage for a staff user - Repeat tests above, access should be denied/links not visible Bonus: - Fixes the link on the acquisition start page for late orders to mage the permissions of the page itself: order_receive Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #11 from Katrin Fischer --- Hi Severine, thx for catching this! Could you maybe sign the follow-up too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #10 from Katrin Fischer --- Created attachment 75616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75616=edit Bug 11911: (follow-up) Hide suggestion box on acq start page if no permission When the user is not superlibrarian or has the manage_suggestions permission, the suggestion box on the left of the acq start page needs to be hidden. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Séverine Queunechanged: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #9 from Séverine Queune --- All behaviours are correct (the bonus one too !). I just wondered about this setting : any acquisition permission except suggestions_manage : "Suggestions" link on acqui-home side menu is hidden, shouldn't it be the same for the "Manage suggestions" link on the "Pending suggestions" frame ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #8 from Katrin Fischer--- Created attachment 75448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75448=edit Bug 11911: Add a separate permission for managing suggestions Without this patch only catalogue permission was required for managing suggestions. This patch adds a new permission in the acquisition module do manage suggestions and updates staff user permissions accordingly. To test: - Make sure there is a pending suggestion - Create a few users with different permission sets: - User 1: only catalogue - User 2: any acquisition permission - User 3: cataloguing permission - Check all of them can access: /cgi-bin/koha/suggestion/suggestion.pl - Apply the patch - Verify all of them now have the suggestions_manage permission - Verify everything displays correctly on: - intranet start page - patron account in staff - acquisition start page - suggestion page (try to access by URL too) - Remove suggestions_manage for a staff user - Repeat tests above, access should be denied/links not visible Bonus: - Fixes the link on the acquisition start page for late orders to mage the permissions of the page itself: order_receive -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischerchanged: What|Removed |Added Assignee|indr...@l2c2.co.in |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischerchanged: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Ruth Smalleychanged: What|Removed |Added CC||rsmalley@livewirewarrington ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #7 from Fiona Borthwick--- I definitely think a separate permission to manage suggestions would be very welcome. We have a range of customers who make use of purchase suggestions but want to have the ability to control which members of the staff can actually manage the suggestions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Fiona Borthwickchanged: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Indranil Das Guptachanged: What|Removed |Added CC||indr...@l2c2.co.in Assignee|koha-b...@lists.koha-commun |indr...@l2c2.co.in |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #6 from Katrin Fischer--- Hi Ray, that's exactly what I suggested here. We should add a new permission and make sure it's set for all existing staff acounts - that way there will be no change of behaviour on update. We also use the suggestions outside of the acquisitions module. We have added the link to the suggestions to the intranet navigation bar using IntranetNav. A downside of the curent behaviour is that the dashboard doesn't show information about new suggestions to users without acq permissions. Having a separate permission we could also fix this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Ray Delahuntychanged: What|Removed |Added CC||r.delahu...@arts.ac.uk --- Comment #5 from Ray Delahunty --- May I respectfully ask that this bug **not** be fixed to ensure that permissions are checked, without the action in duplicate 15506 being attended to at the same time. Here we are delighted at this permissions bug as only a handful of central office staff have Acquisitions permissions (and hence Purchase Suggestions permissions). We have distributed the link included below out to college library staff at all of our various sites, and this means the staff there can deal with Suggestions themselves without central bibliographic services staff having to be involved. Perhaps Purchase Suggestions permissions belong under Tools, rather than Acquisitions? Ray Delahunty University of the Arts London -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischerchanged: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #2 from Katrin Fischer --- *** Bug 13160 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #4 from Katrin Fischer--- *** Bug 6889 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #3 from Katrin Fischer--- *** Bug 15506 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischerchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12219 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Nicole C. Engardchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=15506 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Summary|purchase suggestions|Purchase suggestions can be |permission can be bypassed |accessed by all staff ||members / no specific ||permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|major |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/