[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #47 from Tomás Cohen Arazi --- Enhancement pushed to master. Well done, Marc! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #46 from Katrin Fischer --- Created attachment 45022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45022&action=edit [PASSED QA] Bug 12072: Make datepicker and templates to be aware of dmydot format This patch is to display corrextly the new dmydot date format e.g. after using the datepicker or in messages for the user, in following files: - koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc - koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc - koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc - koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc - tools/holidays.pl To test: - Apply patch - Make sure that you have syspref dateformat set to dmydot - Use datepicker in OPAC (modify birth date), verify that after choosing a date, it is displayed correctly in the datepicker - Use datepicker at several places in OPAC, verify that after choosing a date the date displays properly in datepicker and that the dater format is properly indicated (e.g. near birth date or near "Specify due date"). - Verify that datepicker works well with hoiday editing and that "From date:" displays properly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Katrin Fischer changed: What|Removed |Added Attachment #44747|0 |1 is obsolete|| Attachment #44980|0 |1 is obsolete|| --- Comment #45 from Katrin Fischer --- Created attachment 45020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45020&action=edit [PASSED QA] Bug 12072 - Add system preference for New dateformat dd.mm. (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. - go through Opac and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. Signed-off-by: Josef Moravec Works as expected Amended to apply on top of Bug 15166 11.11.2015/mv Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Attachment #44966|0 |1 is obsolete|| --- Comment #44 from Marc Véron --- Created attachment 44980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44980&action=edit Bug 12072: Make datepicker and templates to be aware of dmydot format This patch is to display corrextly the new dmydot date format e.g. after using the datepicker or in messages for the user, in following files: - koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc - koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc - koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc - koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc - tools/holidays.pl To test: - Apply patch - Make sure that you have syspref dateformat set to dmydot - Use datepicker in OPAC (modify birth date), verify that after choosing a date, it is displayed correctly in the datepicker - Use datepicker at several places in OPAC, verify that after choosing a date the date displays properly in datepicker and that the dater format is properly indicated (e.g. near birth date or near "Specify due date"). - Verify that datepicker works well with hoiday editing and that "From date:" displays properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #43 from paxed --- I think all that repeated if (dateformat == "us") blah elseif (dateformat == "metric") blah elseif (dateformat == ... code in multiple places is fragile and errorprone, and therefore should be replaced with perl code that gets the date format string to the templating system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Attachment #44964|0 |1 is obsolete|| --- Comment #42 from Marc Véron --- Created attachment 44966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44966&action=edit Bug 12072: Make datepicker and templates to be aware of dmydot format This patch is to display corrextly the new dmydot date format e.g. after using the datepicker or in messages for the user, in following files: - koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc - koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc - koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc - koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc - tools/holidays.pl To test: - Apply patch - Make sure that you have syspref dateformat set to dmydot - Use datepicker in OPAC (modify birth date), verify that after choosing a date, it is displayed correctly in the datepicker - Use datepicker at several places in OPAC, verify that after choosing a date the date displays properly in datepicker and that the dater format is properly indicated (e.g. near birth date or near "Specify due date"). - Verify that datepicker works well with hoiday editing and that "From date:" displays properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #41 from Marc Véron --- Created attachment 44964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44964&action=edit Bug 12072: Make datepicker and templates to be aware of dmydot format This patch is to display corrextly the new dmydot date format e.g. after using the datepicker or in messages for the user, in following files: - koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc - koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc - koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc - koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc - tools/holidays.pl To test: - Apply patch - Make sure that you have syspref dateformat set to dmydot - Use datepicker in OPAC (modify birth date), verify that after choosing a date, it is displayed correctly in the datepicker - Use datepicker at several places in OPAC, verify that after choosing a date the date displays properly in datepicker and that the dater format is properly indicated (e.g. near birth date or near "Specify due date"). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Depends on||15166 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 [Bug 15166] Make output_pref accept a string as parameter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Attachment #44606|0 |1 is obsolete|| --- Comment #40 from Marc Véron --- Created attachment 44747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44747&action=edit Bug 12072 - Add system preference for New dateformat dd.mm. (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. - go through Opac and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. Signed-off-by: Josef Moravec Works as expected Amended to apply on top of Bug 15166 11.11.2015/mv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Josef Moravec changed: What|Removed |Added Attachment #44463|0 |1 is obsolete|| --- Comment #39 from Josef Moravec --- Created attachment 44606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44606&action=edit Bug 12072 - Add system preference for New dateformat dd.mm. (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. - go through Opac and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. Signed-off-by: Josef Moravec Works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #38 from Marc Véron --- Addition to test plan: Run DateUtils.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Attachment #43318|0 |1 is obsolete|| --- Comment #37 from Marc Véron --- Created attachment 44463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44463&action=edit Bug 12072 - Add system preference for New dateformat dd.mm. (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. - go through Opac and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #36 from Marc Véron --- Depends on 13 bugs left to sign off as of today (see list in Bug 14870). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Keywords||rel_3_22_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #35 from Marc Véron --- For preliminary testing it is a good idea to have Bug 14985 applied. For full testing we need all Bugs where Bug 14870 depends on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Attachment #43317|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #34 from Marc Véron --- Created attachment 43318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43318&action=edit Bug 12072 - Add system preference for New dateformat dd.mm. (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Attachment #36761|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #33 from Marc Véron --- Created attachment 43317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43317&action=edit Bug 12072 - Step 1: Add system preference for New dateformat dd.mm. As a first step, this patch adds a new system preference for the dateformat dd.mm.yyy No other changes are made. To test: 1. apply the patch 2. run updatedatabase.pl 3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save 4. verify that the value was saved Signed-off-by: Bernardo Gonzalez Kriegel New preference brakes a lot of things, hopefully will be fixed on 13813 No koha-qa errors Amended to replace changes to updatedatabase.pl with atomic update. /mv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7899 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #32 from Marc Véron --- Note for development: See also: tools/exceptionHolidays.pl tools/holidays.pl tools/newHolidays.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14936 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Depends on|13813 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 [Bug 13813] Remove deprecated module C4::Dates from system -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Depends on||14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14794 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #31 from Marc Véron --- Still blocked by Bug 13813. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13601| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14060 --- Comment #30 from Marc Véron --- Added Bug 14060 as related because of function validate_date in intranet-tmpl/prog/en/includes/calendar.inc (will need adjustments for new date format dd.mm.). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13813 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27130|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #36726|0 |1 is obsolete|| --- Comment #29 from Bernardo Gonzalez Kriegel --- Created attachment 36761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36761&action=edit [SIGNED-OFF] Bug 12072 - Step 1: Add system preference for New dateformat dd.mm. As a first step, this patch adds a new system preference for the dateformat dd.mm.yyy No other changes are made. To test: 1. apply the patch 2. run updatedatabase.pl 3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save 4. verify that the value was saved Signed-off-by: Bernardo Gonzalez Kriegel New preference brakes a lot of things, hopefully will be fixed on 13813 No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Depends on||13813 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #28 from Marc Véron --- For the next steps we have the following problem: - It is not allowed to touch C4::Dates (deprecated module, Comment #25) - A new date format leads to error messages for example with C4::Dates->new(), which is used by about 50 files *). - Koha::DateUtils is a temporary module for wrappers to hide the complexity of switch to DateTime. It contains some functions, but it is not really a replacement for the C4::Dates object. - Replacing C4::Dates affects a lot of files and needs a lot of testing (side effects) Plumbing 50+ files is far outside the scope of this bug. It is an architecural task. We should move the replacement of C4::Dates to a separate architectural / plumbing bug (that blocks this one and others as well). *) Files using C4::Dates->new() C4/Acquisition.pm C4/Barcodes/annual.pm C4/Barcodes/hbyymmincr.pm C4/Calendar.pm C4/Circulation.pm C4/Items.pm C4/Log.pm C4/Members.pm C4/Reserves.pm C4/Utils/DataTables.pm acqui/histsearch.pl acqui/invoice.p acqui/invoices.pl acqui/orderreceive.pl acqui/parcel.pl acqui/parcels.pl labels/label-item-search.pl members/memberentry.pl members/moremember.pl members/readingrec.pl misc/cronjobs/gather_print_notices.pl misc/cronjobs/overdue_notices.pl misc/cronjobs/serialsUpdate.pl misc/cronjobs/staticfines.pl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl misc/maintenance/fix_accountlines_date.pl opac/opac-memberentry.pl opac/opac-showreviews.pl opac/opac-user.pl patroncards/members-search.pl reports/dictionary.pl reports/guided_reports.pl serials/member-search.pl serials/serials-edit.pl serials/showpredictionpattern.pl serials/subscription-renew.pl t/Dates.t t/Dates.t t/db_dependent/Holds.t t/db_dependent/Koha_template_plugin_KohaDates.t t/db_dependent/Log.t tools/exceptionHolidays.pl tools/export.pl tools/holidays.pl tools/import_borrowers.pl tools/newHolidays.pl tools/scheduler.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7899 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13601 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #27 from Marc Véron --- Created attachment 36726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36726&action=edit Bug 12072 - Step 1: Add system preference for New dateformat dd.mm. As a first step, this patch adds a new system preference for the dateformat dd.mm.yyy No other changes are made. To test: 1. apply the patch 2. run updatedatabase.pl 3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save 4. verify that the value was saved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added Status|Failed QA |ASSIGNED Assignee|koha-b...@lists.koha-commun |ve...@veron.ch |ity.org | --- Comment #26 from Marc Véron --- I will try to move this forward by splitting it up to several steps / patches based on paxed's work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 paxed changed: What|Removed |Added Assignee|pasi.kalli...@pttk.fi |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #25 from Jonathan Druart --- (In reply to Mirko Tietgen from comment #24) > I would like to see this resolved somehow, it's the standard date format for > Germany too. Do I understand correctly that this is not going in before > someone refactors stuff that is currently done in C4::Dates to be done in > Koha::DateUtils (which is not really within the scope of this bug)? The patch adds new enh in a deprecated module, so yes it's in the scope of this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net --- Comment #24 from Mirko Tietgen --- I would like to see this resolved somehow, it's the standard date format for Germany too. Do I understand correctly that this is not going in before someone refactors stuff that is currently done in C4::Dates to be done in Koha::DateUtils (which is not really within the scope of this bug)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #23 from Marc Véron --- We need this feature for Switzerland and it would be great to have it soon. Is anybody working on it at the moment? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- After consulting with Galen and as we now have officially deprecated the use of C4::Dates, this will need a follow-up moving the code to Koha::DateUtils. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Katrin Fischer changed: What|Removed |Added Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #21 from Jonathan Druart --- This needs others QA points of view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #20 from paxed --- (In reply to Jonathan Druart from comment #19) > (In reply to paxed from comment #18) > > > 1/ Prefer to use Koha::DateUtils instead of C4::Dates. > > > 2/ C4::Dates is not used in C4::Templates. > > > 3/ Prefer to sent variable to template in C4::Auth (common way to do). > > > 4/ Very good initiative! > > > > 1/ Because Koha::DateUtils doesn't do what is needed here - it knows nothing > > about the actual formatting string, just a user-friendly format name like > > Is is not a good idea to continue to add code in C4::Dates. Yes, someone should move the missing functionality from there to Koha::DateUtil then. That doesn't sound like it's relevant to this feature enhancement, though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #19 from Jonathan Druart --- (In reply to paxed from comment #18) > > 1/ Prefer to use Koha::DateUtils instead of C4::Dates. > > 2/ C4::Dates is not used in C4::Templates. > > 3/ Prefer to sent variable to template in C4::Auth (common way to do). > > 4/ Very good initiative! > > 1/ Because Koha::DateUtils doesn't do what is needed here - it knows nothing > about the actual formatting string, just a user-friendly format name like Is is not a good idea to continue to add code in C4::Dates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072
--- Comment #18 from paxed ---
(In reply to Jonathan Druart from comment #16)
> Comment on attachment 27130 [details] [review]
> [SIGNED-OFF] Bug 12072: Add date format dd.mm..
>
> Review of attachment 27130 [details] [review]:
> -
>
> ::: C4/Dates.pm
> @@ +40,4 @@
> >
> > sub _prefformat {
> > unless ( defined $prefformat ) {
> > +$prefformat = C4::Context->preference('dateformat') || 'us';
>
> I disagree with setting a default value for this pref. It must exist in DB.
How can it exist before Koha is installed? The installer uses templates, and
as dateformatstyle is passed on to templates... I guess part 2 below solves
that problem then.
>
> ::: C4/Templates.pm
> @@ +112,4 @@
> > $vars->{opacsmallimage} = C4::Context->preference('opacsmallimage');
> > $vars->{opaclayoutstylesheet} =
> > C4::Context->preference('opaclayoutstylesheet');
> > +$vars->{dateformatstyle} = C4::Dates->new()->formatstr();
>
> 1/ Prefer to use Koha::DateUtils instead of C4::Dates.
> 2/ C4::Dates is not used in C4::Templates.
> 3/ Prefer to sent variable to template in C4::Auth (common way to do).
> 4/ Very good initiative!
1/ Because Koha::DateUtils doesn't do what is needed here - it knows nothing
about the actual formatting string, just a user-friendly format name like
"metric".
2/ True, that needs to be added.
3/ Didn't know about that.
4/ Just bare necessity.
>
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
> @@ +283,4 @@
> > return;
> > }
> > var date_due = new Date($('#duedatespec').datepicker('getDate'));
> > +date_due.setHours(23, 59);
>
> Hum... why this change?
Because offline UI showed the date AND the time in the datetimepicker... but
the time was always hardcoded to 23:59. The other change in the offline UI was
to remove the time display from the datepicker.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072
--- Comment #16 from Jonathan Druart ---
Comment on attachment 27130
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27130
[SIGNED-OFF] Bug 12072: Add date format dd.mm..
Review of attachment 27130:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12072&attachment=27130)
-
::: C4/Dates.pm
@@ +40,4 @@
>
> sub _prefformat {
> unless ( defined $prefformat ) {
> +$prefformat = C4::Context->preference('dateformat') || 'us';
I disagree with setting a default value for this pref. It must exist in DB.
::: C4/Templates.pm
@@ +112,4 @@
> $vars->{opacsmallimage} = C4::Context->preference('opacsmallimage');
> $vars->{opaclayoutstylesheet} =
> C4::Context->preference('opaclayoutstylesheet');
> +$vars->{dateformatstyle} = C4::Dates->new()->formatstr();
1/ Prefer to use Koha::DateUtils instead of C4::Dates.
2/ C4::Dates is not used in C4::Templates.
3/ Prefer to sent variable to template in C4::Auth (common way to do).
4/ Very good initiative!
::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
@@ +283,4 @@
> return;
> }
> var date_due = new Date($('#duedatespec').datepicker('getDate'));
> +date_due.setHours(23, 59);
Hum... why this change?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #17 from Jonathan Druart --- Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #15 from Bernardo Gonzalez Kriegel --- Signed, again :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27118|0 |1 is obsolete|| --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 27130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27130&action=edit [SIGNED-OFF] Bug 12072: Add date format dd.mm.. Make it much easier to add other date formats by passing the date format string to the templates, instead of hard-coding the allowed formats. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 paxed changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 paxed changed: What|Removed |Added Attachment #27108|0 |1 is obsolete|| Attachment #27109|0 |1 is obsolete|| --- Comment #13 from paxed --- Created attachment 27118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27118&action=edit Add dateformat dd.mm. This patch fixes the qa errors fixed in bgkriegel's patch, and also fixes the offline circulation UI to show the dates in correct format. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 27109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27109&action=edit Bug 12072 - Follow up to fix koha-qa errors Removed one tab, and two unnecessary 'my' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27107|0 |1 is obsolete|| --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 27108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27108&action=edit [SIGNED-OFF] Add date format dd.mm., known internally as dmydot. Make it much easier to add other date formats by passing the date format string to the templates, instead of hard-coding the allowed formats. http://bugs.koha-community.org/show_bug.cgi?id=12072 Signed-off-by: Bernardo Gonzalez Kriegel Better version. Works as described. Small koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27082|0 |1 is obsolete|| --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 27107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27107&action=edit Add date format dd.mm., known internally as dmydot. Make it much easier to add other date formats by passing the date format string to the templates, instead of hard-coding the allowed formats. http://bugs.koha-community.org/show_bug.cgi?id=12072 Signed-off-by: Bernardo Gonzalez Kriegel Better version. Works as described. Small koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Assignee|bgkrie...@gmail.com |pasi.kalli...@pttk.fi --- Comment #8 from Bernardo Gonzalez Kriegel --- Setting back to paxed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27069|0 |1 is obsolete|| --- Comment #9 from Bernardo Gonzalez Kriegel --- Comment on attachment 27069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27069 Bug 12072 - New dateformat dd.mm. Obsoleted, paxed version is better -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 paxed changed: What|Removed |Added CC||pasi.kalli...@pttk.fi --- Comment #7 from paxed --- Created attachment 27082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27082&action=edit Add dateformat dd.mm. Here's my version, which makes things a bit more generic. Add date format dd.mm., known internally as dmydot. Make it much easier to add other date formats by passing the date format string to the templates, instead of hard-coding the allowed formats. Testing: (same as bgkriegel's) Things that should be revisited one day: -tinyCME init uses hard-coded dateformat, but the dateformat plugin is not enabled. -dt_add_type_uk_date() should perhaps be made more general. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #27068|0 |1 is obsolete|| --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 27069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27069&action=edit Bug 12072 - New dateformat dd.mm. I changed bug description, not quite apropriate language. Really, it's hard :( This patch adds dd.mm. format as requested. For lack of a better name, I used 'dol', for 'dot on the line' To test: 1. apply the patch 2. run updatedatabase.pl 3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save 4. Test. There are some places where dates are in iso format by design (-mm-dd), others must shows new 'dol' format Works for circulation, reserves, staff & opac, patrons... But... built-in offline shows correct format on datepicker, but not on checked out items, have not discovered yet how this works. So, not ready for sign-off I suppose, but can be tested Resubmited, bad message on updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #5 from Bernardo Gonzalez Kriegel --- A question: in this format a leading zero (as 01.04.2014) is forbidden or allowed? Switch to Needs Signoff, for your consideration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 27068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27068&action=edit Bug 12072 - New dateformat dd.mm. I changed bug description, not quite apropriate language. Really, it's hard :( This patch adds dd.mm. format as requested. For lack of a better name, I used 'dol', for 'dot on the line' To test: 1. apply the patch 2. run updatedatabase.pl 3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm., save 4. Test. There are some places where dates are in iso format by design (-mm-dd), others must shows new 'dol' format Works for circulation, reserves, staff & opac, patrons... But... built-in offline shows correct format on datepicker, but not on checked out items, have not discovered yet how this works. So, not ready for sign-off I suppose, but can be tested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Assignee|pasi.kalli...@pttk.fi |bgkrie...@gmail.com Summary|New dateformats are |New dateformat dd.mm. |stupidly hard to add| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
