[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #22 from Fridolin Somers --- This is great :D could we have the same for OPAC ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 David Roberts changed: What|Removed |Added Attachment #27157|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #4 from David Roberts --- Created attachment 104629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104629&action=edit Bug 12093: Add css classes to item statuses in detail view This patch adds classes where necessary to detail.pl To test: 1) Apply patch 2) View source of /cgi-bin/koha/catalogue/detail.pl to check that there are no orphaned statuses without classes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 David Roberts changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #5 from David Roberts --- A great deal of the original patch is now obsolete. I've worked through the file and added classes where I think they are necessary - hopefully I haven't missed too many. I can't think of a nice way to test this, other than to view the page source so I hope that is OK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #6 from Katrin Fischer --- Created attachment 105299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105299&action=edit Bug 12093: Add CSS classes to item statuses in detail view This patch adds classes where necessary to detail.pl To test: 1) Apply patch 2) View source of /cgi-bin/koha/catalogue/detail.pl to check that there are no orphaned statuses without classes. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What|Removed |Added Summary|Add css classes to item |Add CSS classes to item |statuses in detail view |statuses in detail view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What|Removed |Added Attachment #104629|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #8 from Katrin Fischer --- Created attachment 105860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105860&action=edit Bug 12093: (QA follow-up) Fix typo 'noteforloan' Just changes one character in the noteforloan class to notforloan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What|Removed |Added Attachment #105299|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 105859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105859&action=edit Bug 12093: Add CSS classes to item statuses in detail view This patch adds classes where necessary to detail.pl To test: 1) Apply patch 2) View source of /cgi-bin/koha/catalogue/detail.pl to check that there are no orphaned statuses without classes. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #9 from Katrin Fischer --- I realized a little late that I was also the one to sign this off. Since it has already been sitting for almost a month and I actually tested it twice, risking to leave it as PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 didier changed: What|Removed |Added CC||didier.gautheron@biblibre.c ||om --- Comment #11 from didier --- Hi, In my understanding is plain text https://html.spec.whatwg.org/#the-title-element An after this commit we get stuff like Koha › Catalog › Details for The Korean Go Association's learn to play go / Regards Didier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #12 from Katrin Fischer --- Argh. You are right, I missed the change to the title tag that can't contain other HTML tags. I will try to provide a follow up if David doesn't beat me to it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.01 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #13 from Lucas Gass --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #14 from Katrin Fischer --- Hi Lucas please revert, this will cause issues in display. We need a follow-up first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Owen Leonard changed: What|Removed |Added Blocks||25804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25804 [Bug 25804] Remove HTML from title tag of bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #15 from Owen Leonard --- See Bug 25804 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00, 20.05.01 |20.11.00 released in|| --- Comment #16 from Lucas Gass --- Thanks Cait, This patchset has been reverted from 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #17 from Aleisha Amohia --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #18 from Tomás Cohen Arazi --- (In reply to Aleisha Amohia from comment #17) > enhancement, not backported to 19.11.x One could argue that this makes some strings translatable as well, so a mix of an enhancement and a bugfix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #19 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Aleisha Amohia from comment #17) > > enhancement, not backported to 19.11.x > > One could argue that this makes some strings translatable as well, so a mix > of an enhancement and a bugfix. Hm, I don't think that's the case here - strings will change from the different formatting, but all should have translated ok before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.02 released in|| --- Comment #20 from Lucas Gass --- backported to 20.05.x for 20.05.02 along with bz25804 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #21 from Aleisha Amohia --- enhancement, not backported to 19.11.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 --- Comment #3 from David Roberts --- Looks like the code in detail.tt has changed so completely this bug might not even still be relevant. Will check. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #1 from Katrin Fischer --- Assignee is not set and bug number is missing from commit message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 David Roberts changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om CC||david.roberts@ptfs-europe.c ||om --- Comment #2 from David Roberts --- This wasn't my patch, but will pick this up to try to resolve it as it is currently unassigned. Looks like most of the work has already been done. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/