[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #1 from Kyle M Hall --- Created attachment 27402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27402&action=edit Bug 12123 - HTML notices can break the notice viewer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | --- Comment #2 from Kyle M Hall --- I do not consider this patch to be an optimal solution, but it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #27402|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 27403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27403&action=edit Bug 12123 - HTML notices can break the notice viewer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- Please provide a proper commit message with a test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|CLOSED |REOPENED Resolution|FIXED |--- --- Comment #16 from Kyle M Hall --- This is still a problem if the html of a notice is malformed. For example, an html notice missing a closing tag or quote can break all the things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #33976|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #33876|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #33876|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 73650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73650&action=edit Bug 12123 - HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken Signed-off-by: Owen Leonard I followed the test plan successfully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #18 from Marcel de Rooy --- Note: srcdoc seems not to be supported by IE/Edge. Ignoring that fact since this is a staff page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Marcel de Rooy changed: What|Removed |Added Attachment #73650|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 73758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73758&action=edit Bug 12123 - HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken Signed-off-by: Owen Leonard I followed the test plan successfully. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #20 from Jonathan Druart --- I do not recreate the problem, the message is collapsed and the link behaves as expected. Can I get more details to recreate? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #21 from Katrin Fischer --- I've tried it with the example from the commit message in Firefox and Chromium and no problems found (without patch). Maybe something is missing from the test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #22 from Kyle M Hall --- (In reply to Katrin Fischer from comment #21) > I've tried it with the example from the commit message in Firefox and > Chromium and no problems found (without patch). Maybe something is missing > from the test plan? The original example doesn't break the page html anymore. Try leaving an open anchor tag or some other badly malformed html in a notice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #23 from Jonathan Druart --- I tried that: The following items have been checked out: <> Thank you for visiting <>. And it looks ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #24 from Kyle M Hall --- Try something like: <> Thank you for visiting <>. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #25 from Jonathan Druart --- Still works: https://screenshots.firefox.com/XkVBMvtHEg4P3sfT/pro.kohadev.org https://screenshots.firefox.com/cmfWvx4WeOHNkELn/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #26 from Kyle M Hall --- (In reply to Jonathan Druart from comment #25) > Still works: > https://screenshots.firefox.com/XkVBMvtHEg4P3sfT/pro.kohadev.org > https://screenshots.firefox.com/cmfWvx4WeOHNkELn/pro.kohadev.org Try adding this to the end of you notice: http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Needs Signoff --- Comment #27 from Jonathan Druart --- Still working. SO is from 2014, Marcel did not confirm it recreates the issues. Switch back to NSO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #28 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #27) > Still working. > > SO is from 2014, Marcel did not confirm it recreates the issues. Will have another look at this report tomorrow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #29 from Kyle M Hall --- (In reply to Jonathan Druart from comment #27) > Still working. > > SO is from 2014, Marcel did not confirm it recreates the issues. > > Switch back to NSO. Demonstration of bug with and without patch: https://www.youtube.com/watch?v=IAr-ht3b5kw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #30 from Jonathan Druart --- hum, I recreate it now, with the same notice as yesterday. Sounds like PEBCAK... Let me try again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #31 from Jonathan Druart --- Created attachment 74113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74113&action=edit [ALTERNATIVE-PATCH] Bug 12123: Do not render HTML in notice viewer if invalid If a notice contains malformed HTML it should not be displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #32 from Jonathan Druart --- I'd like your opinions on this alternative patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #33 from Kyle M Hall --- (In reply to Jonathan Druart from comment #32) > I'd like your opinions on this alternative patch. Your patch will definitely fix any issues with malformed html, but it doesn't check to see if the notices *is* html, does it? Also, it feels like just another band-aid to me. Using an iframe completely sandboxes the message html so it will protect the page from problems that we haven't anticipated. It also adds more overhead since it is not doing xml processing on each notice a patron has. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #34 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #32) > I'd like your opinions on this alternative patch. Can we add that test to saving the letter in tools/letter.pl ? I would rather test once if we saved valid HTML and not check every message in the queue. (In the assumption that we do not add invalid constructs during processing.) To be safe, we present it here in an iframe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #35 from Marcel de Rooy --- The example Kyle suggested in comment26 is sufficient to demonstrate that this patch makes a difference. I recommend to restore PQA status and move the html check to a new report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #36 from Katrin Fischer --- Be careful with the check - HTML5 is not valid XML. Unclosed tags are perfectly valid. Often browsers are forgiving and probably mail clients too. We don't want to break display in more cases than now, that will annoy the libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #37 from David Cook --- (In reply to Katrin Fischer from comment #36) > Be careful with the check - HTML5 is not valid XML. Unclosed tags are > perfectly valid. Often browsers are forgiving and probably mail clients too. > We don't want to break display in more cases than now, that will annoy the > libraries. Good call. In PHP, I used to use http://php.net/manual/en/book.tidy.php but that was pre-HTML5 I think. Might be worth looking for a HTML specific module? Also, I'm pretty sure XML::Simple is a bad choice of XML modules. The author of it even discourages its use. No one should ever use it again I reckon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #38 from Kyle M Hall --- It seems like the consensus is that the new alternative patch is not acceptable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #39 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #35) > The example Kyle suggested in comment26 is sufficient to demonstrate that > this patch makes a difference. I recommend to restore PQA status and move > the html check to a new report. Agreed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #74113|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #40 from Jonathan Druart --- We are going to use iframe with a weird display (scrollbars) to catch possible malformed notices. I still do not like the solution. Something else to suggest? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #41 from Kyle M Hall --- Created attachment 74169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74169&action=edit Bug 12123 - Make iframe large enough to remove scroll bars -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #42 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Katrin Fischer changed: What|Removed |Added CC||bar...@bywatersolutions.com --- Comment #43 from Katrin Fischer --- *** Bug 20675 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #27403|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 33863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33863&action=edit Bug 12123 - HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard changed: What|Removed |Added Attachment #33863|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 33876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33876&action=edit [SIGNED-OFF] Bug 12123 - HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken Signed-off-by: Owen Leonard I followed the test plan successfully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Created attachment 33882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33882&action=edit Screenshot I am not sure about this - it seems to work, but should it look like on the screenshot? Do we really need an iframe here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Liz Rea changed: What|Removed |Added Attachment #33876|0 |1 is obsolete|| --- Comment #8 from Liz Rea --- Created attachment 33885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33885&action=edit Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Also changes the layout of the table a bit to be a little more user friendly. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Liz Rea changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 David Cook changed: What|Removed |Added Attachment #33885|1 |0 is obsolete|| --- Comment #10 from David Cook --- Comment on attachment 33885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33885 Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Review of attachment 33885: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12123&attachment=33885) - I definitely prefer Liz's patch over Kyle's. I don't think iframes are needed at all. It looks like the problem is that we were trying to stuff HTML into a "p" element which couldn't take them as children. The only thing stopping my sign off would be the inline CSS. I find the CSS isn't necessary when I test it, and I suppose if it is necessary for other browsers, I would just prefer it to be in a stylesheet somewhere else so we can control our styles better. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt @@ +41,4 @@ > Sent notices for [% INCLUDE 'patron-title.inc' %] > > [% IF ( QUEUED_MESSAGES ) %] > + Using Chrome on Windows, I don't find this CSS does anything. If anything, it makes the presentation slightly worse. However, if we do include it, my only request would be to not use inline CSS and to put this in a separate stylesheet somewhere like staff-global.css or something like that. @@ +55,4 @@ > > > [% QUEUED_MESSAGE.subject %] > + Switching to a div fixes this problem nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Liz Rea changed: What|Removed |Added Attachment #33885|0 |1 is obsolete|| --- Comment #9 from Liz Rea --- Created attachment 33888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33888&action=edit Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard changed: What|Removed |Added Attachment #33885|0 |1 is obsolete|| Attachment #33888|0 |1 is obsolete|| --- Comment #11 from Owen Leonard --- Created attachment 33950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33950&action=edit [SIGNED-OFF] Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken Signed-off-by: Owen Leonard This patch appears to fix the problem with the minimum required change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #12 from David Cook --- Thinking again... I can see the merit of using an iframe instead of a div. After all, the div only works because "p" and "blockquote" can be children of a "div". If a person put "html" and "body" tags into the message, those the HTML would be invalid. *does a test* Mmm, instead of busting the notice viewer, Chrome removes the "html" and "body" tags. (So the viewer continues to work fine, although you'll still notice the "html" and "body" tags in the message_queue.) I've noticed libraries put "html" and "body" tags in their notices before, which is why this comes into my mind. Chrome is pretty rad at cleaning up tag soup, but I'm not sure about Firefox or Internet Explorer... Microsoft Outlook seems capable of handling a HTML email with "html" and "body" tags inside of a "body" tag. I suppose most email clients are pretty flexible when it comes to invalid HTML markup. In any case, I think Liz's solution works. If any problems arise in the future, I suppose we can address them then. (Or possibly strip "body" and "html" tags when saving notice templates.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Katrin Fischer changed: What|Removed |Added Attachment #33950|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 33976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33976&action=edit [PASSED QA] Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken Signed-off-by: Owen Leonard This patch appears to fix the problem with the minimum required change. Signed-off-by: Katrin Fischer Works nicely, no problems found. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Kyle and Liz! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Tom Misilo changed: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
