[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This enhancement makes two  |This enhancement makes two
  release notes|changes to guarantors and   |changes to guarantors and
   |guarantees when registering |guarantees when registering
   |a new patron:
  |a new patron:
   |
   |
   |- A child   |- A child
   |patron must have a  |patron must have a
   |guarantor - this is |guarantor - this is
   |controlled by
  |controlled by
   |  the new   |  the new
   |ChildNeedsGuarantor system  |`ChildNeedsGuarantor`
   |preference.
|system preference.
   |- A guarantor   |- A
   |cannot be a guarantee.  |guarantor cannot be a
   ||guarantee.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #69 from Emmi Takkinen  ---
(In reply to Jonathan Druart from comment #65)
> I don't understand why this has been designed in a so limited way.
> 
> Why only children?
> 
> This should have been a patron's category flag, or the syspref should accept
> a list of patron's categories.
> 
> At some point only children were allowed to have guarantor, but since bug
> 12446 this limitation should not persist.

It does take into account if patrons category has setting "Can be guarantee"
enabled. In Koha::Patron::store:

if (C4::Context->preference('ChildNeedsGuarantor')
and ( $self->is_child or $self->category->can_be_guarantee
)
and $self->contactname eq ""
and !@$guarantors )
{
   
Koha::Exceptions::Patron::Relationship::NoGuarantor->throw();
}

But yeah, syspref and errors don't implicate that syspref has anything to do
with other than child patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #68 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #67)
> Created attachment 158979 [details] [review]
> Bug 12133: (follow-up) Fix failing tests
> 
> Tests were still failing
> 
>  #   Failed test 'No tests run for subtest "Test where parameter for
> SendQueuedMessages"'
>  #   at t/db_dependent/Letters.t line 1274.
>  [Child patron needs a guarantor]# Looks like your test exited with 11 just
> after 97.
> 
> Signed-off-by: Jonathan Druart 

Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #67 from Jonathan Druart  ---
Created attachment 158979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158979=edit
Bug 12133: (follow-up) Fix failing tests

Tests were still failing

 #   Failed test 'No tests run for subtest "Test where parameter for
SendQueuedMessages"'
 #   at t/db_dependent/Letters.t line 1274.
 [Child patron needs a guarantor]# Looks like your test exited with 11 just
after 97.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #66 from Jonathan Druart  ---
The test is still failing

koha_1   | #   Failed test 'No tests run for subtest "Test where parameter
for SendQueuedMessages"'
koha_1   | #   at t/db_dependent/Letters.t line 1274.
koha_1   | [Child patron needs a guarantor]# Looks like your test exited
with 11 just after 97.
koha_1   | [19:28:21] t/db_dependent/Letters.t
 
koha_1   | Dubious, test returned 11 (wstat 2816, 0xb00)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #65 from Jonathan Druart  ---
I don't understand why this has been designed in a so limited way.

Why only children?

This should have been a patron's category flag, or the syspref should accept a
list of patron's categories.

At some point only children were allowed to have guarantor, but since bug 12446
this limitation should not persist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #64 from Tomás Cohen Arazi  ---
Follow-up pushed, thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #63 from Tomás Cohen Arazi  ---
(In reply to Emmi Takkinen from comment #62)
> Created attachment 158919 [details] [review]
> Bug 12133: Fix failing tests
> 
> Tests in erm_users.t and Letters.t failed because when
> we mock patrons they receive category where setting
> can_be_guarantee is not 0. This triggers error "Child
> patron cannot be a guarantor". We also need to mock
> syspref "ChildNeedsGuarantor" accordingly.
> 
> To test prove t/db_dependent/api/v1/erm_users.t and
> t/db_dependent/Letters.t.
> 
> Sponsored-by: Koha-Suomi Oy

Ha, just had written almost the same patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #62 from Emmi Takkinen  ---
Created attachment 158919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158919=edit
Bug 12133: Fix failing tests

Tests in erm_users.t and Letters.t failed because when
we mock patrons they receive category where setting
can_be_guarantee is not 0. This triggers error "Child
patron cannot be a guarantor". We also need to mock
syspref "ChildNeedsGuarantor" accordingly.

To test prove t/db_dependent/api/v1/erm_users.t and
t/db_dependent/Letters.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #61 from Jonathan Druart  ---
Please attach here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #60 from Emmi Takkinen  ---


(In reply to Jonathan Druart from comment #59)
> Tests are failing
> 
> koha_1   | #   Failed test 'No tests run for subtest "list() tests"'
> koha_1   | #   at t/db_dependent/api/v1/erm_users.t line 92.
> koha_1   | Child patron cannot be a guarantor.# Looks like your test
> exited with 2 just after 1.
> koha_1   | [08:24:56] t/db_dependent/api/v1/erm_users.t
> 
> koha_1   | #   Failed test 'Test guarantor handling in
> SendQueuedMessages'
> koha_1   | #   at t/db_dependent/Letters.t line 1163.
> koha_1   | Child patron cannot be a guarantor.# Looks like your test
> exited with 11 just after 95.
> koha_1   | [08:23:02] t/db_dependent/Letters.t 
> 
> Please fix ASAP!

Fixed tests, but should I create new bug or add patch here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #59 from Jonathan Druart  ---
Tests are failing

koha_1   | #   Failed test 'No tests run for subtest "list() tests"'
koha_1   | #   at t/db_dependent/api/v1/erm_users.t line 92.
koha_1   | Child patron cannot be a guarantor.# Looks like your test exited
with 2 just after 1.
koha_1   | [08:24:56] t/db_dependent/api/v1/erm_users.t

koha_1   | #   Failed test 'Test guarantor handling in SendQueuedMessages'
koha_1   | #   at t/db_dependent/Letters.t line 1163.
koha_1   | Child patron cannot be a guarantor.# Looks like your test exited
with 11 just after 95.
koha_1   | [08:23:02] t/db_dependent/Letters.t 

Please fix ASAP!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Needs documenting

--- Comment #58 from Fridolin Somers  ---
Enhancement not pushed to 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #57 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #56 from Katrin Fischer  ---
Restored the patch, but might be better if Kyle uploaded all again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #156446|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #55 from Emmi Takkinen  ---
Thank you Kyle for Passed QA! But it seems you signed off only part of patches
and obsoleted the main patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #54 from Kyle M Hall  ---
Created attachment 158346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158346=edit
Bug 12133: (QA follow-up) Tidy for qa script

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #53 from Kyle M Hall  ---
Created attachment 158345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158345=edit
Bug 12133: (QA follow-up) Fix number of tests

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #156446|0   |1
is obsolete||
 Attachment #156447|0   |1
is obsolete||

--- Comment #52 from Kyle M Hall  ---
Created attachment 158344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158344=edit
Bug 12133: Fix QA issue

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement makes two
  release notes||changes to guarantors and
   ||guarantees when registering
   ||a new patron:
   ||
   ||- A child
   ||patron must have a
   ||guarantor - this is
   ||controlled by
   ||  the new
   ||ChildNeedsGuarantor system
   ||preference.
   ||- A guarantor
   ||cannot be a guarantee.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

David Nind  changed:

   What|Removed |Added

 Attachment #156387|0   |1
is obsolete||

--- Comment #51 from David Nind  ---
Created attachment 156447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156447=edit
Bug 12133: Fix QA issue

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

David Nind  changed:

   What|Removed |Added

 Attachment #154316|0   |1
is obsolete||

--- Comment #50 from David Nind  ---
Created attachment 156446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156446=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #49 from Emmi Takkinen  ---
Created attachment 156387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156387=edit
Bug 12133: Fix QA issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #48 from Jonathan Druart  ---
(In reply to Emmi Takkinen from comment #47)
> (In reply to Marcel de Rooy from comment #46)
> >  FAIL   members/memberentry.pl
> >FAIL   critic
> > # Variables::ProhibitConditionalDeclarations: Got 1
> > violation(s).
> 
> Any ideas where that comes from?

perlcritic. You should be able to recreate easily with `perlcritic
members/memberentry.pl` it will give you more info.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #47 from Emmi Takkinen  ---
(In reply to Marcel de Rooy from comment #46)
>  FAIL   members/memberentry.pl
>FAIL   critic
> # Variables::ProhibitConditionalDeclarations: Got 1
> violation(s).

Any ideas where that comes from?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||m.de.r...@rijksmuseum.nl

--- Comment #46 from Marcel de Rooy  ---
 FAIL   members/memberentry.pl
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 1
violation(s).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #45 from David Nind  ---
Testing notes (using KTD):

1. After apply the patch, run updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

David Nind  changed:

   What|Removed |Added

 Attachment #154300|0   |1
is obsolete||

--- Comment #44 from David Nind  ---
Created attachment 154316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154316=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #43 from Emmi Takkinen  ---
I deleted the unnecessary comment, tests should now pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #153154|0   |1
is obsolete||

--- Comment #42 from Emmi Takkinen  ---
Created attachment 154300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154300=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #41 from Emmi Takkinen  ---
(In reply to Sam Lau from comment #40)
> I am still failing subtest 'safe_to_delete() tests'. The only thing that
> changed in that subtest was that you commented out this line: 
> 
> $patron->account->pay({ amount => 10, debits => [ $debit ] });
> 
> Uncommenting it made all tests successful for me

Ouch, that comment was there to make tests pass for me and I forgot to remove
it. They failed because of that line, but that wasn't in scope of this bug,
maybe it's now fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #40 from Sam Lau  ---
I am still failing subtest 'safe_to_delete() tests'. The only thing that
changed in that subtest was that you commented out this line: 

$patron->account->pay({ amount => 10, debits => [ $debit ] });

Uncommenting it made all tests successful for me

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #153082|0   |1
is obsolete||

--- Comment #39 from Emmi Takkinen  ---
Created attachment 153154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153154=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #38 from Emmi Takkinen  ---
Okay, "Child cannot be guarantor" error happens because $patron_category needs
"can_be_guarantee" value set as 0. 

"Invalid value passed, borrowers.updated_on=SCALAR(0x558a5143c3d8) expected
type is datetime#" happens because calling store for $child2 a.k.a modding
patron sends "updated_on" as a scalar. This can be solved with calling
discard_changes() after first time calling $child2->store succesfully.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #37 from Emmi Takkinen  ---
Okay, now I got the same error. I'll take a look ->

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #36 from Lucas Gass  ---
Emmi,

When I apply this patch, run the database update, and restart services the
tests fail the same as what Sam notes:

# Subtest: guarantor requirements tests
1..6
ok 1 - Child patron can be stored without guarantor when
ChildNeedsGuarantor is off.
ok 2 - Exception thrown when guarantor is required but not provided.
ok 3 - Exception thrown when child patron is added as guarantor.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Incorrect datetime value: 'SCALAR(0x558a5143c3d8)' for column
`koha_kohadev`.`borrowers`.`updated_on` at row 1 at
/kohadevbox/koha/Koha/Object.pm line 170
# Looks like you planned 6 tests but ran 3.
not ok 25 - guarantor requirements tests

#   Failed test 'guarantor requirements tests'
#   at t/db_dependent/Koha/Patron.t line 1589.
Invalid value passed, borrowers.updated_on=SCALAR(0x558a5143c3d8) expected type
is datetime# Looks like your test exited with 255 just after 25.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/25 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #35 from Emmi Takkinen  ---
I'm setting status back to "Needs Signoff" since Im' unable to repeat Sams
problem with tests. However if it recurs then I'll look again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #152706|0   |1
is obsolete||

--- Comment #34 from Emmi Takkinen  ---
Created attachment 153082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153082=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #33 from Emmi Takkinen  ---
(In reply to Sam Lau from comment #32)
> Everything in test plan worked fine for me, just failing
> t/db_dependent/Koha/Patron.t. 
> 
> # Subtest: guarantor requirements tests
> 1..6
> ok 1 - Child patron can be stored without guarantor when
> ChildNeedsGuarantor is off.
> ok 2 - Exception thrown when guarantor is required but not provided.
> ok 3 - Exception thrown when child patron is added as guarantor.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
> execute failed: Incorrect datetime value: 'SCALAR(0xaaab1c4b5b58)' for
> column `koha_kohadev`.`borrowers`.`updated_on` at row 1 at
> /kohadevbox/koha/Koha/Object.pm line 170
> # Looks like you planned 6 tests but ran 3.
> not ok 25 - guarantor requirements tests
> 
> #   Failed test 'guarantor requirements tests'
> #   at t/db_dependent/Koha/Patron.t line 1588.
> Invalid value passed, borrowers.updated_on=SCALAR(0xaaab1c4b5b58) expected
> type is datetime# Looks like your test exited with 255 just after 25.
> Dubious, test returned 255 (wstat 65280, 0xff00)
> Failed 1/25 subtests

Hmm, I'm unable to repeat this. Did you test this with current master? However
for some reason 'guarantor requirements tests' fail for me randomly with error
"Child patron cannot be a guarantor." This probably happens because $child2 is
first attempted to be stored with child as guarantor and then without it..?
Adding $child2->discard_changes after first store seems to help.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Sam Lau  changed:

   What|Removed |Added

 CC||sama...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #32 from Sam Lau  ---
Everything in test plan worked fine for me, just failing
t/db_dependent/Koha/Patron.t. 

# Subtest: guarantor requirements tests
1..6
ok 1 - Child patron can be stored without guarantor when
ChildNeedsGuarantor is off.
ok 2 - Exception thrown when guarantor is required but not provided.
ok 3 - Exception thrown when child patron is added as guarantor.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Incorrect datetime value: 'SCALAR(0xaaab1c4b5b58)' for column
`koha_kohadev`.`borrowers`.`updated_on` at row 1 at
/kohadevbox/koha/Koha/Object.pm line 170
# Looks like you planned 6 tests but ran 3.
not ok 25 - guarantor requirements tests

#   Failed test 'guarantor requirements tests'
#   at t/db_dependent/Koha/Patron.t line 1588.
Invalid value passed, borrowers.updated_on=SCALAR(0xaaab1c4b5b58) expected type
is datetime# Looks like your test exited with 255 just after 25.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/25 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #148070|0   |1
is obsolete||

--- Comment #31 from Emmi Takkinen  ---
Created attachment 152706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152706=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #30 from Emmi Takkinen  ---
There's still some work to do with this. If one deletes patron information and
tries to save patron, error "Child patron needs a guarantor" is lifted as it
should be. But if patron modification is canceled after deleting the guarantor,
all guarantor info is lost because there is no check if patron would end up
without guarantor due delete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #148058|0   |1
is obsolete||

--- Comment #29 from Emmi Takkinen  ---
Created attachment 148070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148070=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #147440|0   |1
is obsolete||

--- Comment #28 from Emmi Takkinen  ---
Created attachment 148058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148058=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #146827|0   |1
is obsolete||

--- Comment #27 from Emmi Takkinen  ---
Created attachment 147440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147440=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #26 from Emmi Takkinen  ---
Combined and rebased patches into one patch. They became a nightmare to handle
:D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #134013|0   |1
is obsolete||
 Attachment #134014|0   |1
is obsolete||
 Attachment #134015|0   |1
is obsolete||

--- Comment #25 from Emmi Takkinen  ---
Created attachment 146827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146827=edit
Bug 12133: Add requirements for guarantor and guarantee

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Test plan:
1. Add a child patron without guarantor or child patron with guarantee
as guarantor succesfully.
2. Apply this patch.
3. Add a child patron as a guarantor.
=> Error is raised.
4. Turn syspref "ChildNeedsGuarantor" ON.
5. Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
6. Add guarantor. Guarantor can either be existing patron or added with
"Contact" section.
=> Save without errors.

Also prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

solene.nga...@inlibro.com changed:

   What|Removed |Added

 CC||solene.nga...@inlibro.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #24 from solene.nga...@inlibro.com ---
Bug 12133 - Guarantor requirements when registering a patron

134013 - Bug 12133: Add requirements for guarantor and guarantee
134014 - Bug 12133: Fix issues with modifying child patron and adding
guarantors
134015 - Bug 12133: Enforce guarantor restrictions on Koha::Patron->store()

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12133: Add requirements for guarantor and guarantee
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
M   members/memberentry.pl
Falling back to patching base and 3-way merge...
Auto-merging members/memberentry.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
error: Failed to merge in the changes.
Patch failed at 0001 Bug 12133: Add requirements for guarantor and guarantee
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-12133-Add-requirements-for-guarantor-and-guara-ofLCAA.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #113100|0   |1
is obsolete||

--- Comment #23 from Emmi Takkinen  ---
Created attachment 134015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134015=edit
Bug 12133: Enforce guarantor restrictions on Koha::Patron->store()

This patch adds checks for new guarantor requirements
to Koha::Patron->store(). If requirements aren't met
exception is raised.

To test prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #113099|0   |1
is obsolete||

--- Comment #22 from Emmi Takkinen  ---
Created attachment 134014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134014=edit
Bug 12133: Fix issues with modifying child patron and adding guarantors

Child patrons couldn't be modified when guarantor was
patron due missing guarantor_id value. Also if multiple
guarantors were added one could easily add child patron
as a guarantor.

This patch adds Instead of one guarantor id all new and
existing guarantor ids are checked in case of child patron.

To test:
1. Add child patron with syspref ChildNeedsGuarantor and
GuarantorNeedsToBePatron on.
2. Add two guarantors for the patron, first one should be
an adult patron and second a child.
3. Save patron.
=> Error "A guarantor cannot be a guarantee." should be
raised but isn't.
4. Modify patron and save.
=> Error "Child needs guarantor" is raised even if (valid)
guarantor exists.
5. Apply patch.
6. Repeat steps 1 to 4.
=> This time while saving a new patron error "A guarantor
cannot be a guarantee." is raised but modifying is
successful.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

  Attachment #94544|0   |1
is obsolete||

--- Comment #21 from Emmi Takkinen  ---
Created attachment 134013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134013=edit
Bug 12133: Add requirements for guarantor and guarantee

Add three requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor has to be a patron. This is controlled by
  a new syspref GuarantorHasToBePatron.
- A guarantor cannot be a guarantee.

Test plan:
-Add child patron without guarantor or child patron with guarantee
as guarantor succesfully.
- Apply this patch.
- Add a child patron with a guarantee as guarantor. Error is raised.
- Turn syspref "ChildNeedsGuarantor" ON.
- Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
- Add guarantor. Guarantor can either be existing patron or added with
"Contact" section. Save without errors.
- Turn syspref "GuarantorNeedsToBePatron" ON.
- Form fields for "Contact" section aren't displayed and only existing
patron can be added as guarantor.

Signed-off-by: Johanna Raisa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #20 from Emmi Takkinen  ---
Created attachment 113100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113100=edit
Bug 12133: Enforce guarantor restrictions on Koha::Patron->store()

This patch adds checks for new guarantor requirements
to Koha::Patron->store(). If requirements aren't met
exception is raised.

To test prove t/db_dependent/Koha/Patron.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #19 from Emmi Takkinen  ---
Finally had time to look at this again and noticed that the latest patch didn't
take into account possible multiple guarantor ids. It fixed issue with
modifying but one could add child patron as guarantor. Since these stem up from
same a problem, missing guarantor ids, I obsoleted the latest patch and
provided a new one which fixes both of these issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

  Attachment #99629|0   |1
is obsolete||

--- Comment #18 from Emmi Takkinen  ---
Created attachment 113099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113099=edit
Bug 12133: Fix issues with modifying child patron and adding guarantors

Child patrons couldn't be modified when guarantor was
patron due missing guarantor_id value. Also if multiple
guarantors were added one could easily add child patron
as a guarantor.

This patch adds Instead of one guarantor id all new and
existing guarantor ids are checked in case of child patron.

To test:
1. Add child patron with syspref ChildNeedsGuarantor and
GuarantorNeedsToBePatron on.
2. Add two guarantors for the patron, first one should be
an adult patron and second a child.
3. Save patron.
=> Error "A guarantor cannot be a guarantee." should be
raised but isn't.
4. Modify patron and save.
=> Error "Child needs guarantor" is raised even if (valid)
guarantor exists.
5. Apply patch.
6. Repeat steps 1 to 4.
=> This time while saving a new patron error "A guarantor
cannot be a guarantee." is raised but modifying is
successful.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #17 from Jonathan Druart  
---
(In reply to Emmi Takkinen from comment #16)
> (In reply to Jonathan Druart from comment #14)
> > I think this new restriction needs to be enforced at module level, when the
> > patron is added/updated (Koha::Patron->store), with changes covered by test
> 
> You mean "guarantor can't be guarantee"?

And "child patron must have a guarantor".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #16 from Emmi Takkinen  ---
(In reply to Jonathan Druart from comment #14)
> I think this new restriction needs to be enforced at module level, when the
> patron is added/updated (Koha::Patron->store), with changes covered by test

You mean "guarantor can't be guarantee"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #15 from Emmi Takkinen  ---
Created attachment 99629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99629=edit
Bug 12133: Fix issue with modify

Child patrons couldn't be modified when guarantor was
patron due missing guarantor_id value. This patch fixes
that.

To test:
1. Add child patron with syspref ChildNeedsGuarantor and
GuarantorNeedsToBePatron on.
2. Modify patron and save.
3. Error "Child needs guarantor" is raised even if
guarantor exists.
4. Apply patch.
5. Edit again and save. No error should be raised.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from Jonathan Druart  
---
I think this new restriction needs to be enforced at module level, when the
patron is added/updated (Koha::Patron->store), with changes covered by tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Johanna Räisä  changed:

   What|Removed |Added

  Attachment #94538|0   |1
is obsolete||
 CC||johanna.ra...@koha-suomi.fi

--- Comment #13 from Johanna Räisä  ---
Created attachment 94544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94544=edit
Bug 12133: Add requirements for guarantor and guarantee

Add three requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor has to be a patron. This is controlled by
  a new syspref GuarantorHasToBePatron.
- A guarantor cannot be a guarantee.

Test plan:
-Add child patron without guarantor or child patron with guarantee
as guarantor succesfully.
- Apply this patch.
- Add a child patron with a guarantee as guarantor. Error is raised.
- Turn syspref "ChildNeedsGuarantor" ON.
- Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
- Add guarantor. Guarantor can either be existing patron or added with
"Contact" section. Save without errors.
- Turn syspref "GuarantorNeedsToBePatron" ON.
- Form fields for "Contact" section aren't displayed and only existing
patron can be added as guarantor.

Signed-off-by: Johanna Raisa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Johanna Räisä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

  Attachment #94371|0   |1
is obsolete||

--- Comment #12 from Emmi Takkinen  ---
Created attachment 94538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94538=edit
Bug 12133: Add requirements for guarantor and guarantee

Changed header of the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

  Attachment #91482|0   |1
is obsolete||

--- Comment #11 from Emmi Takkinen  ---
Created attachment 94371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94371=edit
Bug 12133: (QA Follow up) Guarantor requirements when registering a patron

Add three requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor has to be a patron. This is controlled by
  a new syspref GuarantorHasToBePatron.
- A guarantor cannot be a guarantee.

Test plan:
-Add child patron without guarantor or child patron with guarantee
as guarantor successfully.
- Apply this patch.
- Add a child patron with a guaranteer as guarantor. Error is raised.
- Turn syspref "ChildNeedsGuarantor" ON.
- Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
- Add guarantor. Guarantor can either be existing patron or added with
"Contact" section. Save without errors.
- Turn syspref "GuarantorNeedsToBePatron" ON.
- Form fields for "Contact" section aren't displayed and only existing
patron can be added as guarantor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Blocks||23687


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23687
[Bug 23687] Guarantor info not asked when patron is changed to child
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #10 from Emmi Takkinen  ---
Spoke too soon, syspref to require a guarantor for a child is still needed :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Emmi Takkinen  ---
That's due changes made in bug 14570 which also makes changes proposed in this
bugs. Marking this as resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Mwoo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mary.woodw...@bedfordtx.gov

--- Comment #8 from Mwoo  ---
After install patch.  When chose new patron child got this error.
Error trace

Could not compile /kohadevbox/koha/members/memberentry.pl: Global symbol
"$guarantorid" requires explicit package name (did you forget to declare "my
$guarantorid"?) at /kohadevbox/koha/members/memberentry.pl line 270.
Global symbol "$guarantorid" requires explicit package name (did you forget to
declare "my $guarantorid"?) at /kohadevbox/koha/members/memberentry.pl line
271.
Global symbol "$guarantordata" requires explicit package name (did you forget
to declare "my $guarantordata"?) at /kohadevbox/koha/members/memberentry.pl
line 272.
Global symbol "$guarantordata" requires explicit package name (did you forget
to declare "my $guarantordata"?) at /kohadevbox/koha/members/memberentry.pl
line 273.
Global symbol "$guarantorinfo" requires explicit package name (did you forget
to declare "my $guarantorinfo"?) at /kohadevbox/koha/members/memberentry.pl
line 274.
Global symbol "$guarantordata" requires explicit package name (did you forget
to declare "my $guarantordata"?) at /kohadevbox/koha/members/memberentry.pl
line 274.
Global symbol "$guarantordata" requires explicit package name (did you forget
to declare "my $guarantordata"?) at /kohadevbox/koha/members/memberentry.pl
line 274.
Global symbol "$guarantordata" requires explicit package name (did you forget
to declare "my $guarantordata"?) at /kohadevbox/koha/members/memberentry.pl
line 275.
Global symbol "$guarantordata" requires explicit package name (did you forget
to declare "my $guarantordata"?) at /kohadevbox/koha/members/memberentry.pl
line 276.
Global symbol "$guarantordata" requires explicit package name (did you forget
to declare "my $guarantordata"?) at /kohadevbox/koha/members/memberentry.pl
line 277.
Global symbol "$guarantordata" requires explicit package name (did you forget
to declare "my $guarantordata"?) at /kohadevbox/koha/members/memberentry.pl
line 283.
Global symbol "$guarantordata" requires explicit package name (did you forget
to declare "my $guarantordata"?) at /kohadevbox/koha/members/memberentry.pl
line 287.
syntax error at /kohadevbox/koha/members/memberentry.pl line 292, near "HEAD
my "
  (Might be a runaway multi-line '< string starting on line 287)
/kohadevbox/koha/members/memberentry.pl has too many errors.
 at /usr/share/perl5/CGI/Compile.pm line 132

in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 132

  129: my $code = $self->_eval($eval);
  130: my $exception = $@;
  131: 
  132: die "Could not compile $script: $exception" if $exception;
  133: 
  134: sub {
  135: my @args = @_;

Show function arguments
in Plack::App::WrapCGI::prepare_app at
/usr/share/perl5/Plack/App/WrapCGI.pm line 81

   78: };
   79: $self->_app($app);
   80: } else {
   81: my $sub = CGI::Compile->compile($script);
   82: my $app = CGI::Emulate::PSGI->handler($sub);
   83: 
   84: $self->_app($app);

Show function arguments
in Plack::Component::to_app at /usr/share/perl5/Plack/Component.pm line 49

   46: 
   47: sub to_app {
   48: my $self = shift;
   49: $self->prepare_app;
   50: return sub { $self->call(@_) };
   51: }
   52: 

Show function arguments
in Plack::App::CGIBin::serve_path at /usr/share/perl5/Plack/App/CGIBin.pm
line 47

   44: 
   45: local @{$env}{qw(SCRIPT_NAME PATH_INFO)} = @{$env}{qw(
plack.file.SCRIPT_NAME plack.file.PATH_INFO )};
   46: 
   47: my $app = $self->{_compiled}->{$file} ||=
Plack::App::WrapCGI->new(
   48: script => $file, execute => $self->would_exec($file),
   49: )->to_app;
   50: $app->($env);

Show function arguments
in Plack::App::File::call at /usr/share/perl5/Plack/App/File.pm line 34

   31: $env->{'plack.file.PATH_INFO'}   = '';
   32: }
   33: 
   34: return $self->serve_path($env, $file);
   35: }
   36: 
   37: sub locate_file {

Show function arguments
in Plack::Component::__ANON__ at /usr/share/perl5/Plack/Component.pm line
50

   47: sub to_app {
   48: my $self = shift;
   49: $self->prepare_app;
   50: return sub { $self->call(@_) };
   51: }
   52: 
   53: 

Show function arguments
in Plack::App::URLMap::call at /usr/share/perl5/Plack/App/URLMap.pm line 71

   68: return $self->response_cb($app->($env), sub {
   69: $env->{PATH_INFO} = 

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

  Attachment #33459|0   |1
is obsolete||

--- Comment #7 from Emmi Takkinen  ---
Created attachment 91482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91482=edit
Bug 12133: Guarantor requirements when registering a  patron

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor doesn't have to be a patron. This is controlled by
  a new syspref GuarantorHasToBePatron.
- A guarantor cannot be a guarantee.

Note that syspref "GuarantorHasToBePatron" depends on
"ChildNeedsGuarantor" being ON.

Test plan:
- Add a child patron without a guarantor. Saving the patron
is successful.
- Add a child patron with a guarantor who has a guarantor. Saving is
successful.
- Apply this patch.
- Turn syspref "ChildNeedsGuarantor" ON.
- Add a child patron with a guarantor who has a guarantor. Error
- Add a child patron without a guarantor and error "Child needs a
guarantor" is raised.
- Add the guarantor info (only surname is needed) and saving the patron
 should be succesful.
- Turn syspref "GuarantorNeedsToBePatron" ON.
- Add a child patron this time with guarantor info and error
"Guarantor has to be a patron" is raised.
- Add existing patron as guarantor and now saving the patron
should be succesful.
- Add a child patron with a guarantor who is also a guarantee.
Error is raised.
- Turn syspref "ChildNeedsGuarantor" OFF.
- Add a child patron without a guarantor. Saving patron should
be successful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Emmi Takkinen  changed:

   What|Removed |Added

 CC||emmi.takki...@outlook.com
   Assignee|pasi.kalli...@koha-suomi.fi |emmi.takki...@outlook.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Blou  changed:

   What|Removed |Added

 CC|p...@inlibro.com |philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27584|0   |1
is obsolete||
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
On master, you can set a firstname+surname as guarantor. You are not forced to
choose an existing patron.
With you patch, pref enabled, it's not possible to do that.
Worse, if you try to edit a patron without guarantorid, you are not allowed to
save any changes.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #5 from p...@inlibro.com ---
Created attachment 33459
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33459action=edit
[SIGNED-OFF] Bug 12133: Guarantor requirements when registering a patron

Add two requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor.
- A guarantor cannot be a guarantee.

Signed-off-by: ppp p...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

p...@inlibro.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||p...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #4 from paxed pasi.kalli...@pttk.fi ---
To test:

1) Add a new child patron. It will be successful without a guarantor.
2) Add a new child patron, with guarantor set to some other patron who already
has a guarantor. Adding the child patron is successful.
3) Add a new non-child patron, with guarantor set to some other patron who
already has a guarantor. Adding the patron is successful.
4) Install patch
5) Add a new child patron. It will be successful without a guarantor.
6) Add a new child patron, with guarantor set to some other patron who already
has a guarantor. Adding the child patron should fail with error message.
7) Add a new non-child patron, with guarantor set to some other patron who
already has a guarantor. Adding the patron should fail with error message.
8) Set syspref ChildNeedsGuarantor to ON
9) Try to add a new child patron without a guarantor. It should fail with error
message.
10) Add a new non-child patron. It will be successful without a guarantor.
11) Set syspref ChildNeedsGuarantor to OFF
12) Repeat the steps 5-10, but instead of adding a patron, edit already
existing patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

paxed pasi.kalli...@pttk.fi changed:

   What|Removed |Added

  Attachment #27517|0   |1
is obsolete||
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |pasi.kalli...@pttk.fi
   |ity.org |

--- Comment #2 from paxed pasi.kalli...@pttk.fi ---
Created attachment 27584
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27584action=edit
Guarantor requirements when registering a patron

Add two requirements when registering a new patron

Attached patch adds two new requirements when registering a new patron:

- A child patron must have a guarantor. This is controlled by
  a new syspref ChildNeedsGuarantor, which defaults to off.
- A guarantor cannot be a guarantee.

Both of these stem from legal requirements in Finland.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com
  Component|Staff Client|Patrons
   Severity|trivial |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
Please provide a test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
(In reply to paxed from comment #0)

 so perhaps a syspref to control one, or both,
 might be in order?

My library would definitely want a system preference to control the first
option (child must have a guarantor). The second option seems like simple logic
to me, but I've learned not to trust my sense of logic in these matters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/