[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23283

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
   Severity|minor   |enhancement
 Resolution|--- |FIXED

--- Comment #48 from Martin Renvoize  ---
Architectural enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #47 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #46 from Nick Clemens  ---
Discussion is unclear - this now blocks 20443 - do we want these pushed
together, or can this one go now and then be followed by 20443 when it is
ready?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #44 from Marcel de Rooy  ---
Created attachment 86884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86884=edit
Bug 12159: (QA follow-up) Rename relation in Patron::Attributes

It seems that we do not need the extra belongs_to in the schema result
files if we rename the relation to code.

Test plan:
Run t/db_dependent/Koha/Patrons.t
Run t/db_dependent/Koha/Patron/Attributes.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86166|0   |1
is obsolete||

--- Comment #42 from Marcel de Rooy  ---
Created attachment 86882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86882=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Marcel de Rooy 
[EDIT] Removed Koha/Schema/Result/BorrowerAttribute.pm
[EDIT] Added missing semicolon on L114 in Koha/Patron/Attribute.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #45 from Marcel de Rooy  ---
Created attachment 86885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86885=edit
Bug 12159: (QA follow-up) Remove double use module

Speaks for itself.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #41 from Marcel de Rooy  ---
QA Comment:
Saw this warning once:
Argument "" isn't numeric in numeric gt (>) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
line 84.

False warning from qa tools:
Koha/Patron/Attribute.pm
critic/forbidden patterns: forbidden pattern: Warning: The 'sub type' may be
wrong is declared in a Koha::* package (see bug 15446) (line 127)

A dumb question:
+ return Koha::Patron::Attributes->search({
+borrowernumber => $self->borrowernumber,
+branchcode => $self->branchcode,
+});
=> Is the branchcode needed?

Koha/Patron/Attribute.pm L114
return $av->next->lib if $av->count
Amended: adding a semicolon for future ease.

Koha/Schema/Result/BorrowerAttribute.pm 
=> Please do not add DBIx schema files in a regular patch. I removed it now.
Btw it seems no longer necessary if we rename the relation in the Koha object.
See follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86167|0   |1
is obsolete||

--- Comment #43 from Marcel de Rooy  ---
Created attachment 86883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86883=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #86168|0   |1
is obsolete||

--- Comment #40 from Marcel de Rooy  ---
Comment on attachment 86168
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86168
Bug 12159: (QA follow-up) Silencing POD warn from qa tools

No longer needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #39 from Josef Moravec  ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

  Attachment #77051|0   |1
is obsolete||

--- Comment #37 from Josef Moravec  ---
Created attachment 86167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86167=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

  Attachment #77050|0   |1
is obsolete||

--- Comment #36 from Josef Moravec  ---
Created attachment 86166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86166=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

  Attachment #77052|0   |1
is obsolete||

--- Comment #38 from Josef Moravec  ---
Created attachment 86168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86168=edit
Bug 12159: (QA follow-up) Silencing POD warn from qa tools

*** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Jonathan Druart  changed:

   What|Removed |Added

 Status|BLOCKED |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #35 from Jonathan Druart  
---
Conflicts with bug 20805 fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #33 from Jonathan Druart  
---
Created attachment 77051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77051=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #34 from Jonathan Druart  
---
Created attachment 77052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77052=edit
Bug 12159: (QA follow-up) Silencing POD warn from qa tools

*** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #76945|0   |1
is obsolete||
  Attachment #76946|0   |1
is obsolete||
  Attachment #76947|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart  
---
Created attachment 77050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77050=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #31 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #29)
> Why BLOCKED?

See comment 20.

(In reply to Martin Renvoize from comment #30)
> I believe Tomas is working on bug 20443.. which I think is the blocker here.

See assignee field, I am working on it. Please do not change anything here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #30 from Martin Renvoize  ---
I believe Tomas is working on bug 20443.. which I think is the blocker here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #29 from Katrin Fischer  ---
Why BLOCKED?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #28 from Jonathan Druart  
---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #26 from Jonathan Druart  
---
Created attachment 76946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76946=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #27 from Jonathan Druart  
---
Created attachment 76947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76947=edit
Bug 12159: (QA follow-up) Silencing POD warn from qa tools

*** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75811|0   |1
is obsolete||
  Attachment #75812|0   |1
is obsolete||
  Attachment #75822|0   |1
is obsolete||

--- Comment #25 from Jonathan Druart  
---
Created attachment 76945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76945=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #24 from Katrin Fischer  ---
How can we make progress here? Waiting for patches for bug 20443?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #23 from Josef Moravec  ---
(In reply to Jonathan Druart from comment #20)
> IMO we should push this one along with bug 20443 (which does not have
> patches yet). Otherwise we are going to have 2 different ways to fetch
> patron's attributes.
> Before we only had GetBorrowerAttributes.

Does make sense. I'll try to look at it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #22 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #18)
> FAIL Koha/Patron/Attribute.pm
> forbidden pattern: Warning: The 'sub type' may be wrong is declared in a
> Koha::* package (see bug 15446) (line 127)
> 
> Josef:
> This is a more nasty one.
> Could you consider renaming this method?
> The Koha objects also use _type and it might be confusing.
> What do you think?

We could rename it of course, but isn't that the reason why the type in
Koha::Object was renamed to _type? To avoid conflicts with type accessor if
needed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #21 from Martin Renvoize  ---
I agree with Jonathan here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #20 from Jonathan Druart  
---
IMO we should push this one along with bug 20443 (which does not have patches
yet). Otherwise we are going to have 2 different ways to fetch patron's
attributes.
Before we only had GetBorrowerAttributes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #19 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #18)
> FAIL Koha/Patron/Attribute.pm
> forbidden pattern: Warning: The 'sub type' may be wrong is declared in a
> Koha::* package (see bug 15446) (line 127)
> 
> Josef:
> This is a more nasty one.
> Could you consider renaming this method?
> The Koha objects also use _type and it might be confusing.
> What do you think?

It already exists.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #18 from Marcel de Rooy  ---
FAIL Koha/Patron/Attribute.pm
forbidden pattern: Warning: The 'sub type' may be wrong is declared in a
Koha::* package (see bug 15446) (line 127)

Josef:
This is a more nasty one.
Could you consider renaming this method?
The Koha objects also use _type and it might be confusing.
What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #17 from Marcel de Rooy  ---
Created attachment 75822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75822=edit
Bug 12159: (QA follow-up) Silencing POD warn from qa tools

*** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #16 from Josef Moravec  ---
Created attachment 75812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75812=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

  Attachment #74791|0   |1
is obsolete||
  Attachment #74792|0   |1
is obsolete||

--- Comment #15 from Josef Moravec  ---
Created attachment 75811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75811=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Séverine Queune  changed:

   What|Removed |Added

 Blocks||20648


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648
[Bug 20648] Attribute option "Display in check-out" should be renamed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #14 from Séverine Queune  ---
(In reply to Josef Moravec from comment #13)
> (In reply to Séverine Queune from comment #12)
> > Attributes checked "Display in check-out" are now displayed on side panel of
> > all tabs in patron account (that's useful).
> > 
> > Maybe the description of this option on the "Attribute menu" should be
> > modifiy now.
> > "Display in check-out: Check to show this attribute in patron check-out."
> > --> "Display in patron's brief information" ?
> 
> Definitely makes sense to me, would you mind to fill a bug for this?

No problem ! Done with Bug 20648.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #13 from Josef Moravec  ---
(In reply to Séverine Queune from comment #12)
> Attributes checked "Display in check-out" are now displayed on side panel of
> all tabs in patron account (that's useful).
> 
> Maybe the description of this option on the "Attribute menu" should be
> modifiy now.
> "Display in check-out: Check to show this attribute in patron check-out."
> --> "Display in patron's brief information" ?

Definitely makes sense to me, would you mind to fill a bug for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #12 from Séverine Queune  ---
Attributes checked "Display in check-out" are now displayed on side panel of
all tabs in patron account (that's useful).

Maybe the description of this option on the "Attribute menu" should be modifiy
now.
"Display in check-out: Check to show this attribute in patron check-out."
--> "Display in patron's brief information" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74781|0   |1
is obsolete||

--- Comment #10 from Séverine Queune  ---
Created attachment 74791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74791=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74782|0   |1
is obsolete||

--- Comment #11 from Séverine Queune  ---
Created attachment 74792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74792=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

  Attachment #73018|0   |1
is obsolete||
  Attachment #73019|0   |1
is obsolete||

--- Comment #8 from Josef Moravec  ---
Created attachment 74781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74781=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #9 from Josef Moravec  ---
Created attachment 74782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74782=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #7 from Séverine Queune  ---
I couldn't apply the patch on master branch (17.12.00.037) :

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12159: Fix getting extended patron attributes for circ-menu
Using index info to reconstruct a base tree...
M   Koha/Patron.pm
M   circ/circulation.pl
M   koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
M   members/boraccount.pl
M   members/member-flags.pl
M   members/memberentry.pl
M   members/moremember.pl
M   members/paycollect.pl
Falling back to patching base and 3-way merge...
Auto-merging members/paycollect.pl
Auto-merging members/moremember.pl
Auto-merging members/memberentry.pl
Auto-merging members/member-flags.pl
Auto-merging members/boraccount.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
Auto-merging circ/circulation.pl
Auto-merging Koha/Patron.pm
CONFLICT (content): Merge conflict in Koha/Patron.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 12159: Fix getting extended patron attributes for
circ-menu
The copy of the patch that failed is found in:
   /var/repositories/koha/.git/rebase-apply/patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159
Bug 12159 depends on bug 18789, which changed state.

Bug 18789 Summary: Send a Koha::Patron object to the templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

 Blocks||20443


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443
[Bug 20443] Move C4::Members::Attributes to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

   Assignee|mtomp...@hotmail.com|josef.mora...@gmail.com

--- Comment #6 from Josef Moravec  ---
The problem is a bit complicated, this sub was wrong at all (sorry for
mystification you Mark).

I added new method Koha::Patron->attributes and use it instead

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

  Attachment #72902|0   |1
is obsolete||

--- Comment #4 from Josef Moravec  ---
Created attachment 73018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73018=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #5 from Josef Moravec  ---
Created attachment 73019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73019=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #3 from M. Tompsett  ---
Haven't written the tests yet, so feel free to take it, write them, and ask for
sign off. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
   Assignee|gmcha...@gmail.com  |mtomp...@hotmail.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #2 from M. Tompsett  ---
Created attachment 72902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72902=edit
Bug 12159: Move borrower_add_additional_fields to Koha::Patron

The same function was effectively coded twice.
It was removed from members/pay.pl and members/paycollect.pl
and placed in Koha/Patron.pm instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec  changed:

   What|Removed |Added

 Blocks||16846
 Depends on||18789
 CC||josef.mora...@gmail.com

--- Comment #1 from Josef Moravec  ---
Should be removed and functionality added to Koha::Patron


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
[Bug 16846] Move patron related code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789
[Bug 18789] Send a Koha::Patron object to the templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Component|Staff Client|Architecture, internals,
   ||and plumbing
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6427
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|koha-b...@lists.koha-commun |gmcha...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/