[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer changed: What|Removed |Added Depends on||2546 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #1 from Katrin Fischer --- Created attachment 27821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27821&action=edit Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Katrin Fischer changed: What|Removed |Added Blocks||11573 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #2 from Marc Véron --- Created attachment 27879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27879&action=edit [Signed-off] Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. Tested by changing accounttype in table accountlines to all possible values like Pay, Pay00, Pay01 etc. Both themes display the same values, e.g. "Payment, thanks (cash via SIP2)" for Pay00 Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Marc Véron changed: What|Removed |Added Attachment #27821|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #4 from Jonathan Druart --- Created attachment 28101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28101&action=edit Bug 12165: Display record title The code introduced by bug 2546 uses an undefined variable (line.title). It should be ACCOUNT_LINE.title. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Jonathan Druart changed: What|Removed |Added Attachment #27879|0 |1 is obsolete|| CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 --- Comment #3 from Jonathan Druart --- Created attachment 28100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28100&action=edit Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme 1) Create an account with lots of different charges, fines, fees, etc. 2) Look at the accouts tab in the prog OPAC theme 3) Compare the page to bootstrap theme 4) Verify display is now the same In my tests I found some things that could still be improved, but for the goal is to make all OPAC themes behave the same. Tested by changing accounttype in table accountlines to all possible values like Pay, Pay00, Pay01 etc. Both themes display the same values, e.g. "Payment, thanks (cash via SIP2)" for Pay00 Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton --- Pushed to master and 3.16.x. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Galen Charlton changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Nick Clemens changed: What|Removed |Added Blocks|11573 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/